All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ryan England <rcengland@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	outreachy@lists.linux.dev
Subject: Re: [PATCH v2] staging: rtl8712: fix open parentheses alignment
Date: Thu, 21 Dec 2023 08:50:29 +0100	[thread overview]
Message-ID: <2023122151-denial-speed-1b4c@gregkh> (raw)
In-Reply-To: <ZYM3APIhUHxupDnq@kernel.ryanengland.xyz>

On Wed, Dec 20, 2023 at 06:48:32PM +0000, Ryan England wrote:
> Made corrections given we have 100 lines. Thanks for the update.

Why is this in the changelog text now?  As per the documentation,
something like this should go below the --- line, as my bot says:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

thanks,

greg k-h

  reply	other threads:[~2023-12-21  7:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-20 18:48 [PATCH v2] staging: rtl8712: fix open parentheses alignment Ryan England
2023-12-21  7:50 ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-12-21 20:22 Ryan England
2023-12-22  8:40 ` Nam Cao
2023-12-22  8:47 ` Nam Cao
2024-01-03 13:19   ` Dan Carpenter
2024-01-03 13:32     ` Nam Cao
2023-12-22  8:52 ` Nam Cao
2023-12-22  8:56   ` Nam Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023122151-denial-speed-1b4c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=rcengland@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.