From: "Michael S. Tsirkin" <mst@redhat.com>
To: Dragos Tatulea <dtatulea@nvidia.com>
Cc: "eperezma@redhat.com" <eperezma@redhat.com>,
"xuanzhuo@linux.alibaba.com" <xuanzhuo@linux.alibaba.com>,
Parav Pandit <parav@nvidia.com>, Gal Pressman <gal@nvidia.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"si-wei.liu@oracle.com" <si-wei.liu@oracle.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
"leon@kernel.org" <leon@kernel.org>
Subject: Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag
Date: Fri, 22 Dec 2023 03:29:02 -0500 [thread overview]
Message-ID: <20231222032713-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <17abeefd02c843cddf64efbeadde49ad15c365a1.camel@nvidia.com>
On Thu, Dec 21, 2023 at 03:07:22PM +0000, Dragos Tatulea wrote:
> > > > In that case you're right, we don't need feature flags. But I think it
> > > > would be great to also move the error return in case userspace tries
> > > > to modify vq parameters out of suspend state.
> > > >
> > > On the driver side or on the core side?
> > >
> >
> > Core side.
> >
> Checking my understanding: instead of the feature flags there would be a check
> (for .set_vq_addr and .set_vq_state) to return an error if they are called under
> DRIVER_OK and not suspended state?
Yea this looks much saner, if we start adding feature flags for
each OPERATION_X_LEGAL_IN_STATE_Y then we will end up with N^2
feature bits which is not reasonable.
--
MST
next prev parent reply other threads:[~2023-12-22 8:29 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 18:08 [PATCH vhost v4 00/15] vdpa/mlx5: Add support for resumable vqs Dragos Tatulea
2023-12-19 18:08 ` [PATCH mlx5-vhost v4 01/15] vdpa/mlx5: Expose resumable vq capability Dragos Tatulea
2023-12-20 3:46 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag Dragos Tatulea
2023-12-20 3:46 ` Jason Wang
2023-12-20 4:05 ` Jason Wang
2023-12-20 12:57 ` Dragos Tatulea
2023-12-20 13:32 ` Eugenio Perez Martin
2023-12-21 2:03 ` Jason Wang
2023-12-21 7:46 ` Eugenio Perez Martin
2023-12-21 11:52 ` Dragos Tatulea
2023-12-21 12:08 ` Eugenio Perez Martin
2023-12-21 14:38 ` Dragos Tatulea
2023-12-21 14:55 ` Eugenio Perez Martin
2023-12-21 15:07 ` Dragos Tatulea
2023-12-22 7:30 ` Eugenio Perez Martin
2023-12-22 8:29 ` Michael S. Tsirkin [this message]
2023-12-22 10:51 ` Dragos Tatulea
2023-12-25 13:45 ` Dragos Tatulea
2023-12-22 2:50 ` Jason Wang
2023-12-20 16:09 ` Eugenio Perez Martin
2023-12-19 18:08 ` [PATCH vhost v4 03/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_STATE_IN_SUSPEND flag Dragos Tatulea
2023-12-20 16:10 ` Eugenio Perez Martin
2023-12-19 18:08 ` [PATCH vhost v4 04/15] vdpa: Accept VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND backend feature Dragos Tatulea
2023-12-20 16:11 ` Eugenio Perez Martin
2023-12-19 18:08 ` [PATCH vhost v4 05/15] vdpa: Accept VHOST_BACKEND_F_CHANGEABLE_VQ_STATE_IN_SUSPEND " Dragos Tatulea
2023-12-20 16:12 ` Eugenio Perez Martin
2023-12-19 18:08 ` [PATCH vhost v4 06/15] vdpa: Track device suspended state Dragos Tatulea
2023-12-20 3:46 ` Jason Wang
2023-12-20 12:55 ` Dragos Tatulea
2023-12-22 11:22 ` Dragos Tatulea
2023-12-25 4:11 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 07/15] vdpa: Block vq address change in DRIVER_OK unless device supports it Dragos Tatulea
2023-12-20 16:31 ` Eugenio Perez Martin
2023-12-19 18:08 ` [PATCH vhost v4 08/15] vdpa: Block vq state " Dragos Tatulea
2023-12-20 16:32 ` Eugenio Perez Martin
2023-12-19 18:08 ` [PATCH vhost v4 09/15] vdpa/mlx5: Allow modifying multiple vq fields in one modify command Dragos Tatulea
2023-12-20 3:46 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 10/15] vdpa/mlx5: Introduce per vq and device resume Dragos Tatulea
2023-12-20 3:47 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 11/15] vdpa/mlx5: Mark vq addrs for modification in hw vq Dragos Tatulea
2023-12-19 18:08 ` [PATCH vhost v4 12/15] vdpa/mlx5: Mark vq state " Dragos Tatulea
2023-12-20 3:47 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 13/15] vdpa/mlx5: Use vq suspend/resume during .set_map Dragos Tatulea
2023-12-20 3:47 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 14/15] vdpa/mlx5: Introduce reference counting to mrs Dragos Tatulea
2023-12-20 3:47 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 15/15] vdpa/mlx5: Add mkey leak detection Dragos Tatulea
2023-12-25 14:41 ` [PATCH vhost v4 00/15] vdpa/mlx5: Add support for resumable vqs Michael S. Tsirkin
2023-12-25 15:05 ` Dragos Tatulea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222032713-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dtatulea@nvidia.com \
--cc=eperezma@redhat.com \
--cc=gal@nvidia.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.