From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/swupdate: bump version to 2023.12
Date: Sat, 23 Dec 2023 18:43:09 +0100 [thread overview]
Message-ID: <20231223184309.63501a74@windsurf> (raw)
In-Reply-To: <20231218224747.545311-1-giulio.benetti@benettiengineering.com>
Hello,
On Mon, 18 Dec 2023 23:47:47 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> * make json-c mandatory according to [0]
> * make libubootenv mandatory according to [1]
> * drop local patch that has been upstreamed [2]
> * libconfig is not mandatory anymore if no lua parser is enabled
> * adjust Config.in comment according to json-c and libubootenv
>
> [0]: https://github.com/sbabic/swupdate/commit/82e75322443e021d119a026a3476c410f4705d67
> [1]: https://github.com/sbabic/swupdate/commit/75838874e2575f822ed85d89532f47e9adf781b6
> [2]: https://github.com/sbabic/swupdate/commit/1999685830d6e9b57014666b9e53e46de17a471c
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Thanks for the extensive commit log. I applied with one fix, see below.
> diff --git a/package/swupdate/Config.in b/package/swupdate/Config.in
> index 7d9fc90e10..171805bea9 100644
> --- a/package/swupdate/Config.in
> +++ b/package/swupdate/Config.in
> @@ -3,9 +3,9 @@ config BR2_PACKAGE_SWUPDATE
> depends on !BR2_STATIC_LIBS
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_USE_MMU # fork()
> - # swupdate requires a parser and uses libconfig as default
> - select BR2_PACKAGE_LIBCONFIG if !BR2_PACKAGE_JSON_C && \
> - !BR2_PACKAGE_HAS_LUAINTERPRETER
> + depends on BR2_TOOLCHAIN_HAS_SYNC_4 # json-c
You forgot to replicate this dependency in the Config.in comment of
swupdate, i.e:
comment "swupdate needs a toolchain w/ dynamic library, threads"
depends on BR2_USE_MMU
+ depends on BR2_TOOLCHAIN_HAS_SYNC_4
depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
I fixed that when applying. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-12-23 17:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 22:47 [Buildroot] [PATCH v2] package/swupdate: bump version to 2023.12 Giulio Benetti
2023-12-23 17:43 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231223184309.63501a74@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.