From: Lukas Wunner <lukas@wunner.de>
To: Ethan Zhao <haifeng.zhao@linux.intel.com>
Cc: bhelgaas@google.com, baolu.lu@linux.intel.com,
dwmw2@infradead.org, will@kernel.org, robin.murphy@arm.com,
linux-pci@vger.kernel.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v6 2/4] iommu/vt-d: don's issue devTLB flush request when device is disconnected
Date: Sun, 24 Dec 2023 11:32:25 +0100 [thread overview]
Message-ID: <20231224103225.GA31197@wunner.de> (raw)
In-Reply-To: <20231224050657.182022-3-haifeng.zhao@linux.intel.com>
On Sun, Dec 24, 2023 at 12:06:55AM -0500, Ethan Zhao wrote:
> --- a/drivers/iommu/intel/pasid.c
> +++ b/drivers/iommu/intel/pasid.c
> @@ -481,6 +481,9 @@ devtlb_invalidation_with_pasid(struct intel_iommu *iommu,
> if (!info || !info->ats_enabled)
> return;
>
> + if (pci_dev_is_disconnected(to_pci_dev(dev)))
> + return;
> +
> sid = info->bus << 8 | info->devfn;
> qdep = info->ats_qdep;
> pfsid = info->pfsid;
Do you even need this or is patch [4/4] sufficient?
Is there a benefit to the hunk above on top of patch [4/4]?
Thanks,
Lukas
next prev parent reply other threads:[~2023-12-24 10:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 5:06 [RFC PATCH v6 0/4] fix vt-d hard lockup when hotplug ATS capable device Ethan Zhao
2023-12-24 5:06 ` [RFC PATCH v6 1/4] PCI: make pci_dev_is_disconnected() helper public for other drivers Ethan Zhao
2023-12-24 5:06 ` [RFC PATCH v6 2/4] iommu/vt-d: don's issue devTLB flush request when device is disconnected Ethan Zhao
2023-12-24 10:32 ` Lukas Wunner [this message]
2023-12-25 1:00 ` Ethan Zhao
2023-12-25 1:56 ` Ethan Zhao
2023-12-24 22:43 ` Bjorn Helgaas
2023-12-25 1:19 ` Ethan Zhao
2023-12-25 1:46 ` Ethan Zhao
2023-12-25 2:21 ` Bjorn Helgaas
2023-12-25 2:35 ` Ethan Zhao
2023-12-25 9:12 ` Ethan Zhao
2023-12-27 2:40 ` Ethan Zhao
2023-12-24 5:06 ` [RFC PATCH v6 3/4] iommu/vt-d: add flush_target_dev member to struct intel_iommu and pass device info to all needed functions Ethan Zhao
2023-12-24 5:06 ` [RFC PATCH v6 4/4] iommu/vt-d: break out devTLB invalidation if target device is gone Ethan Zhao
2023-12-24 10:47 ` Lukas Wunner
2023-12-25 1:16 ` Ethan Zhao
2023-12-25 8:57 ` Ethan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231224103225.GA31197@wunner.de \
--to=lukas@wunner.de \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=haifeng.zhao@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.