Re: [Buildroot] [PATCH 5/6] package/google-breakpad: add 0002-dont-include-stab.h.patch

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Adam,

On Sat,  2 Dec 2023 21:18:38 -0700
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:

> diff --git a/package/google-breakpad/0002-dont-include-stab.h.patch b/package/google-breakpad/0002-dont-include-stab.h.patch
> new file mode 100644
> index 0000000000..0817f1928f
> --- /dev/null
> +++ b/package/google-breakpad/0002-dont-include-stab.h.patch
> @@ -0,0 +1,103 @@
> +From 569af712da94637091080943f6a0d69ccb35864e Mon Sep 17 00:00:00 2001
> +From: Khem Raj <raj.khem@gmail.com>
> +Date: Thu, 14 Sep 2017 23:24:08 -0700
> +Subject: [PATCH] don't include stab.h
> +
> +From openembeddeds patch found at the following path:
> +meta-oe/recipes-devtools/breakpad/breakpad/0003-Dont-include-stab.h.patch
> +
> +  - Backported to c85eb4a59b618f3beaad5445ceb1f865ffa8efdf
> +  - Added || defined(__UCLIBC__) in stabs_reader.h, as uClibc provides the
> +    a.out.h file but does not include the N_* macros.
> +
> +Upstream: Pending
> +
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +[Backported to c85eb4a59b618f3beaad5445ceb1f865ffa8efdf]
> +Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>

I am not too sure about wanting to include this patch. The patch has
been written in 2017 apparently, and it says "Upstream: Pending", but I
couldn't find it having been submitted anywhere. So it's really a patch
that apparently has never been submitted upstream, which we would carry
forever. So unless someone has a particular interested in getting
google-breakpad to work on uClibc systems, who would take care of
taking the time to upstream this change, I'd prefer to keep
google-breakpad available only for glibc configurations for now. If the
patch was being submitted upstream, I would be fully OK to include it
in Buildroot.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot