All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Antoine Tenart <atenart@kernel.org>,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	buildroot@buildroot.org, Romain Naour <romain.naour@smile.fr>,
	"Yann E. MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH 1/1] package/libselinux: fix build with BR2_TIME_BITS_64
Date: Mon, 25 Dec 2023 11:15:37 +0100	[thread overview]
Message-ID: <20231225111537.7d46ac11@windsurf> (raw)
In-Reply-To: <20231130191305.5345-1-fontaine.fabrice@gmail.com>

On Thu, 30 Nov 2023 20:13:05 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> This LFS workaround for glibc < 2.23 was added in 2016 by commit
> ebcca24c953d8df4b16bc52c5ba31feae4ed8ad0 and is probably not needed
> anymore as glibc 2.23 was released in February 2016:
> https://sourceware.org/glibc/wiki/Release/2.23

We still have in our external toolchains
toolchain/toolchain-external/toolchain-external-codesourcery-arm/,
which is a toolchain from 2014, and it uses glibc 2.18. So I suspect
this change would break with this glibc toolchain. However, this older
glibc toolchain will clearly not support 64-bit time_t.

So either we decide that we stop supporting anything older than glibc
2.23, or we have to add some condition on the version of glibc being
used.

Let's see the opinion of the other maintainers.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-12-25 10:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30 19:13 [Buildroot] [PATCH 1/1] package/libselinux: fix build with BR2_TIME_BITS_64 Fabrice Fontaine
2023-12-01 20:29 ` Peter Korsgaard
2023-12-01 20:32   ` Fabrice Fontaine
2023-12-25 10:15 ` Thomas Petazzoni via buildroot [this message]
2024-01-11 14:08   ` Arnout Vandecappelle via buildroot
2024-03-03 20:13 ` Arnout Vandecappelle via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231225111537.7d46ac11@windsurf \
    --to=buildroot@buildroot.org \
    --cc=atenart@kernel.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=marcus.folkesson@gmail.com \
    --cc=romain.naour@smile.fr \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.