From: Leon Romanovsky <leonro@nvidia.com>
To: Jim Harris <jim.harris@samsung.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>,
"Alex Williamson" <alex.williamson@redhat.com>
Subject: Re: [PATCH 1/2] Revert "PCI/IOV: Serialize sysfs sriov_numvfs reads vs writes"
Date: Mon, 25 Dec 2023 13:20:08 +0200 [thread overview]
Message-ID: <20231225112008.GB59971@unreal> (raw)
In-Reply-To: <170311309712.2826.11254260046040224092.stgit@bgt-140510-bm01.eng.stellus.in>
On Wed, Dec 20, 2023 at 10:58:17PM +0000, Jim Harris wrote:
> The proper way to detect a change to the num_VFs value is to listen for a
> sysfs event, not to add a device_lock() on the attribute _show() in the
> kernel.
>
> This reverts commit 35ff867b76576e32f34c698ccd11343f7d616204.
> Revert had a small conflict, the sprintf() is now changed to sysfs_emit().
>
> Suggested-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Jim Harris <jim.harris@samsung.com>
> ---
> drivers/pci/iov.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-12-25 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231220225813uscas1p15c950a58c7de44d32199a63a13f1bb31@uscas1p1.samsung.com>
2023-12-20 22:58 ` [PATCH 0/2] pci/iov: avoid device_lock() when reading sriov_numvfs Jim Harris
2023-12-20 22:58 ` [PATCH 1/2] Revert "PCI/IOV: Serialize sysfs sriov_numvfs reads vs writes" Jim Harris
2023-12-25 11:20 ` Leon Romanovsky [this message]
2023-12-20 22:58 ` [PATCH 2/2] pci/iov: fix kobject_uevent() ordering in sriov_enable() Jim Harris
2023-12-25 11:19 ` Leon Romanovsky
2024-02-09 0:30 ` [PATCH 0/2] pci/iov: avoid device_lock() when reading sriov_numvfs Bjorn Helgaas
2024-02-09 23:06 ` Jim Harris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231225112008.GB59971@unreal \
--to=leonro@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=jgg@nvidia.com \
--cc=jim.harris@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.