From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 1/2] tests/intel/kms_psr2_sf: Fix primary_format setting
Date: Tue, 26 Dec 2023 11:54:14 +0530 [thread overview]
Message-ID: <20231226062415.23338-2-jeevan.b@intel.com> (raw)
In-Reply-To: <20231226062415.23338-1-jeevan.b@intel.com>
The format is being changed globally to DRM_FORMAT_NV12. Additionally,
FBC doesn't support the NV12 format, so this issue is being addressed.
v2: Initialize data members at the beginning of the loop.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
tests/intel/kms_psr2_sf.c | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/tests/intel/kms_psr2_sf.c b/tests/intel/kms_psr2_sf.c
index 76435f501..68cedf577 100644
--- a/tests/intel/kms_psr2_sf.c
+++ b/tests/intel/kms_psr2_sf.c
@@ -68,13 +68,13 @@
* SUBTEST: cursor-plane-update-sf
* Description: Test that selective fetch works on cursor plane
*
- * SUBTEST: fbc-cursor-plane-update-continuous-sf
+ * SUBTEST: fbc-cursor-plane-update-sf
* Description: Test that fbc with selective fetch works on cursor plane
*
* SUBTEST: overlay-plane-update-continuous-sf
* Description: Test that selective fetch works on overlay plane
*
- * SUBTEST: fbc-overlay-plane-update-continuous-sf-dmg-area
+ * SUBTEST: fbc-overlay-plane-update-sf-dmg-area
* Description: Test that fbc with selective fetch works on overlay plane
*
* SUBTEST: overlay-plane-update-sf-dmg-area
@@ -100,13 +100,13 @@
* SUBTEST: primary-plane-update-sf-dmg-area
* Description: Test that selective fetch works on primary plane
*
- * SUBTEST: fbc-primary-plane-update-continuous-sf-dmg-area
+ * SUBTEST: fbc-primary-plane-update-sf-dmg-area
* Description: Test that fbc with selective fetch works on primary plane
*
* SUBTEST: primary-plane-update-sf-dmg-area-big-fb
* Description: Test that selective fetch works on primary plane with big fb
*
- * SUBTEST: fbc-primary-plane-update-continuous-sf-dmg-area-big-fb
+ * SUBTEST: fbc-primary-plane-update-sf-dmg-area-big-fb
* Description: Test that fbc with selective fetch works on primary plane with big fb
*/
@@ -1014,10 +1014,6 @@ igt_main
"Error enabling PSR2\n");
data.damage_area_count = MAX_DAMAGE_AREAS;
- data.op = PLANE_UPDATE;
- data.test_plane_id = DRM_PLANE_TYPE_PRIMARY;
- data.primary_format = DRM_FORMAT_XRGB8888;
- data.big_fb_test = 0;
res = drmModeGetResources(data.drm_fd);
data.big_fb_width = res->max_width;
@@ -1043,6 +1039,11 @@ igt_main
}
for (y = 0; y < ARRAY_SIZE(fbc_status); y++) {
+ data.op = PLANE_UPDATE;
+ data.test_plane_id = DRM_PLANE_TYPE_PRIMARY;
+ data.primary_format = DRM_FORMAT_XRGB8888;
+ data.big_fb_test = 0;
+
data.op_fbc_mode = fbc_status[y];
/* Verify primary plane selective fetch */
igt_describe("Test that selective fetch works on primary plane");
@@ -1387,7 +1388,6 @@ igt_main
* plane and continuous updates.
*/
data.op = PLANE_UPDATE_CONTINUOUS;
- data.primary_format = DRM_FORMAT_NV12;
igt_describe("Test that selective fetch works on overlay plane");
igt_subtest_with_dynamic_f("%soverlay-%s-sf", append_fbc_subtest[y],
op_str(data.op)) {
@@ -1404,6 +1404,10 @@ igt_main
data.pipe = pipes[i];
data.output = outputs[i];
data.damage_area_count = 1;
+ if (data.op_fbc_mode == FBC_ENABLED)
+ data.primary_format = DRM_FORMAT_XRGB8888;
+ else
+ data.primary_format = DRM_FORMAT_NV12;
data.test_plane_id = DRM_PLANE_TYPE_OVERLAY;
data.coexist_feature = j;
prepare(&data);
--
2.25.1
next prev parent reply other threads:[~2023-12-26 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 6:24 [PATCH i-g-t 0/2] Fix primary_format setting and Skip bigfb test for FBC Jeevan B
2023-12-26 6:24 ` Jeevan B [this message]
2023-12-26 6:24 ` [PATCH i-g-t 2/2] tests/intel/kms_psr2_sf: Skip the test for bigfb with FBC enabled Jeevan B
-- strict thread matches above, loose matches on Subject: below --
2023-12-26 8:47 [PATCH i-g-t 0/2] Fix primary_format setting and Skip bigfb test for FBC Jeevan B
2023-12-26 8:47 ` [PATCH i-g-t 1/2] tests/intel/kms_psr2_sf: Fix primary_format setting Jeevan B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231226062415.23338-2-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.