From: Stephen Hemminger <stephen@networkplumber.org>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"Ori Kam" <orika@nvidia.com>, <dev@dpdk.org>
Subject: Re: [RFC] ethdev: fast path async flow API
Date: Wed, 27 Dec 2023 09:41:17 -0800 [thread overview]
Message-ID: <20231227094117.678ce828@hermes.local> (raw)
In-Reply-To: <20231227105709.1951231-1-dsosnowski@nvidia.com>
On Wed, 27 Dec 2023 12:57:09 +0200
Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:
> +/**
> + * @internal
> + *
> + * Fast path async flow functions and related data are held in a flat array, one entry per ethdev.
> + * It is assumed that each entry is read-only and cache aligned.
> + */
> +struct rte_flow_fp_ops {
> + void *ctx;
> + rte_flow_async_create_t async_create;
> + rte_flow_async_create_by_index_t async_create_by_index;
> + rte_flow_async_actions_update_t async_actions_update;
> + rte_flow_async_destroy_t async_destroy;
> + rte_flow_push_t push;
> + rte_flow_pull_t pull;
> + rte_flow_async_action_handle_create_t async_action_handle_create;
> + rte_flow_async_action_handle_destroy_t async_action_handle_destroy;
> + rte_flow_async_action_handle_update_t async_action_handle_update;
> + rte_flow_async_action_handle_query_t async_action_handle_query;
> + rte_flow_async_action_handle_query_update_t async_action_handle_query_update;
> + rte_flow_async_action_list_handle_create_t async_action_list_handle_create;
> + rte_flow_async_action_list_handle_destroy_t async_action_list_handle_destroy;
> + rte_flow_async_action_list_handle_query_update_t async_action_list_handle_query_update;
> +} __rte_cache_aligned;
If you go ahead with this then all usage should be const pointer.
Still think it is bad idea and creates even more technical debt.
next prev parent reply other threads:[~2023-12-27 17:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 10:57 [RFC] ethdev: fast path async flow API Dariusz Sosnowski
2023-12-27 17:39 ` Stephen Hemminger
2023-12-27 17:41 ` Stephen Hemminger [this message]
2023-12-28 13:53 ` Dariusz Sosnowski
2023-12-28 14:10 ` Ivan Malov
2024-01-03 18:01 ` Dariusz Sosnowski
2024-01-03 18:29 ` Ivan Malov
2024-01-04 13:13 ` Dariusz Sosnowski
2023-12-28 17:16 ` Stephen Hemminger
2024-01-03 19:14 ` Dariusz Sosnowski
2024-01-04 1:07 ` Stephen Hemminger
2024-01-23 11:37 ` Dariusz Sosnowski
2024-01-29 13:38 ` Dariusz Sosnowski
2024-01-29 17:36 ` Ferruh Yigit
2024-01-30 12:06 ` Dariusz Sosnowski
2024-01-30 12:17 ` Ferruh Yigit
2024-01-30 16:08 ` Dariusz Sosnowski
2024-01-04 8:47 ` Konstantin Ananyev
2024-01-04 16:08 ` Dariusz Sosnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231227094117.678ce828@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=ferruh.yigit@amd.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.