Re: [PATCH v2] Bluetooth: btnxpuart: Resolve TX timeout error in power save stress test

[kernel test robot <lkp@intel.com>]

Hi Neeraj,

kernel test robot noticed the following build errors:

[auto build test ERROR on bluetooth/master]
[also build test ERROR on bluetooth-next/master linus/master v6.7-rc7 next-20231222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Neeraj-Sanjay-Kale/Bluetooth-btnxpuart-Resolve-TX-timeout-error-in-power-save-stress-test/20231226-193718
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link:    https://lore.kernel.org/r/20231226113110.3923962-1-neeraj.sanjaykale%40nxp.com
patch subject: [PATCH v2] Bluetooth: btnxpuart: Resolve TX timeout error in power save stress test
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231227/202312271920.D4X4fO6I-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231227/202312271920.D4X4fO6I-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312271920.D4X4fO6I-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/bluetooth/btnxpuart.c: In function 'ps_control':
>> drivers/bluetooth/btnxpuart.c:356:25: error: implicit declaration of function 'usleep'; did you mean 'fsleep'? [-Werror=implicit-function-declaration]
     356 |                         usleep(2000); /* Allow chip to detect UART-break and enter sleep */
         |                         ^~~~~~
         |                         fsleep
   cc1: some warnings being treated as errors


vim +356 drivers/bluetooth/btnxpuart.c

   333	
   334	static void ps_control(struct hci_dev *hdev, u8 ps_state)
   335	{
   336		struct btnxpuart_dev *nxpdev = hci_get_drvdata(hdev);
   337		struct ps_data *psdata = &nxpdev->psdata;
   338		int status;
   339	
   340		if (psdata->ps_state == ps_state ||
   341		    !test_bit(BTNXPUART_SERDEV_OPEN, &nxpdev->tx_state))
   342			return;
   343	
   344		mutex_lock(&psdata->ps_lock);
   345		switch (psdata->cur_h2c_wakeupmode) {
   346		case WAKEUP_METHOD_DTR:
   347			if (ps_state == PS_STATE_AWAKE)
   348				status = serdev_device_set_tiocm(nxpdev->serdev, TIOCM_DTR, 0);
   349			else
   350				status = serdev_device_set_tiocm(nxpdev->serdev, 0, TIOCM_DTR);
   351			break;
   352		case WAKEUP_METHOD_BREAK:
   353		default:
   354			if (ps_state == PS_STATE_AWAKE) {
   355				status = serdev_device_break_ctl(nxpdev->serdev, 0);
 > 356				usleep(2000); /* Allow chip to detect UART-break and enter sleep */
   357			} else {
   358				status = serdev_device_break_ctl(nxpdev->serdev, -1);
   359			}
   360			bt_dev_dbg(hdev, "Set UART break: %s, status=%d",
   361				   str_on_off(ps_state == PS_STATE_SLEEP), status);
   362			break;
   363		}
   364		if (!status)
   365			psdata->ps_state = ps_state;
   366		mutex_unlock(&psdata->ps_lock);
   367	
   368		if (ps_state == PS_STATE_AWAKE)
   369			btnxpuart_tx_wakeup(nxpdev);
   370	}
   371	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki