From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
chandan.babu@oracle.com, linux-xfs@vger.kernel.org,
kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH 1/2] xfs: fix a use after free in xfs_defer_finish_recovery
Date: Thu, 28 Dec 2023 07:47:53 +0100 [thread overview]
Message-ID: <20231228064753.GA13395@lst.de> (raw)
In-Reply-To: <20231228062633.GR361584@frogsfrogsfrogs>
On Wed, Dec 27, 2023 at 10:26:33PM -0800, Darrick J. Wong wrote:
> > - error = dfp->dfp_ops->recover_work(dfp, capture_list);
> > + error = ops->recover_work(dfp, capture_list);
>
> Since I suck at remembering that dfp can be freed by recovery work, can
> you add a comment to that effect? e.g.
Sure.
prev parent reply other threads:[~2023-12-28 6:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 6:18 [PATCH 1/2] xfs: fix a use after free in xfs_defer_finish_recovery Christoph Hellwig
2023-12-28 6:18 ` [PATCH 2/2] xfs: use the op name in trace_xlog_intent_recovery_failed Christoph Hellwig
2023-12-28 6:27 ` Darrick J. Wong
2023-12-28 6:26 ` [PATCH 1/2] xfs: fix a use after free in xfs_defer_finish_recovery Darrick J. Wong
2023-12-28 6:47 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231228064753.GA13395@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=oliver.sang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.