From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
Daejun Park <daejun7.park@samsung.com>,
Kanchan Joshi <joshi.k@samsung.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Jeff Layton <jlayton@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH v8 06/19] block, fs: Propagate write hints to the block device inode
Date: Thu, 28 Dec 2023 08:12:06 +0100 [thread overview]
Message-ID: <20231228071206.GA13770@lst.de> (raw)
In-Reply-To: <20231219000815.2739120-7-bvanassche@acm.org>
On Mon, Dec 18, 2023 at 04:07:39PM -0800, Bart Van Assche wrote:
> Write hints applied with F_SET_RW_HINT on a block device affect the
> shmem inode only. Propagate these hints to the block device inode
> because that is the inode used when writing back dirty pages.
What shmem inode?
> @@ -317,6 +318,9 @@ static long fcntl_set_rw_hint(struct file *file, unsigned int cmd,
>
> inode_lock(inode);
> inode->i_write_hint = hint;
> + apply_whint = inode->i_fop->apply_whint;
> + if (apply_whint)
> + apply_whint(file, hint);
Setting the hint in file->f_mapping->inode is the right thing here,
not adding a method.
next prev parent reply other threads:[~2023-12-28 7:12 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 0:07 [PATCH v8 00/19] Pass data lifetime information to SCSI disk devices Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 01/19] fs: Fix rw_hint validation Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 02/19] fs: Verify write lifetime constants at compile time Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 03/19] fs: Split fcntl_rw_hint() Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 04/19] fs: Move enum rw_hint into a new header file Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 05/19] block, fs: Restore the per-bio/request data lifetime fields Bart Van Assche
2024-01-22 9:23 ` Kanchan Joshi
2024-01-22 20:05 ` Bart Van Assche
2024-01-23 12:35 ` Kanchan Joshi
2024-01-23 15:59 ` Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 06/19] block, fs: Propagate write hints to the block device inode Bart Van Assche
2023-12-28 7:12 ` Christoph Hellwig [this message]
2023-12-28 22:41 ` Bart Van Assche
2024-01-03 9:02 ` Christoph Hellwig
2024-01-03 23:09 ` Bart Van Assche
2024-01-04 6:08 ` Christoph Hellwig
2024-01-18 18:51 ` Kanchan Joshi
2024-01-18 18:54 ` Bart Van Assche
2024-01-19 13:56 ` Kanchan Joshi
2024-01-22 9:31 ` Kanchan Joshi
2024-01-22 20:09 ` Bart Van Assche
2024-01-23 12:16 ` Kanchan Joshi
2024-01-23 15:29 ` Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 07/19] fs/f2fs: Restore the whint_mode mount option Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 08/19] fs/f2fs: Restore support for tracing data lifetimes Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 09/19] scsi: core: Query the Block Limits Extension VPD page Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 10/19] scsi: scsi_proto: Add structures and constants related to I/O groups and streams Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 11/19] scsi: sd: Translate data lifetime information Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 12/19] scsi: scsi_debug: Reduce code duplication Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 13/19] scsi: scsi_debug: Support the block limits extension VPD page Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 14/19] scsi: scsi_debug: Rework page code error handling Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 15/19] scsi: scsi_debug: Rework subpage " Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 16/19] scsi: scsi_debug: Allocate the MODE SENSE response from the heap Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 17/19] scsi: scsi_debug: Implement the IO Advice Hints Grouping mode page Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 18/19] scsi: scsi_debug: Implement GET STREAM STATUS Bart Van Assche
2023-12-19 0:07 ` [PATCH v8 19/19] scsi: scsi_debug: Maintain write statistics per group number Bart Van Assche
2023-12-19 1:12 ` [PATCH v8 00/19] Pass data lifetime information to SCSI disk devices Jens Axboe
2023-12-27 16:25 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231228071206.GA13770@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=bvanassche@acm.org \
--cc=chuck.lever@oracle.com \
--cc=daejun7.park@samsung.com \
--cc=jlayton@kernel.org \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.