From: Florian Westphal <fw@strlen.de>
To: Linus Torvalds <torvalds@linuxfoundation.org>
Cc: Wander Lairson Costa <wander@redhat.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
security@kernel.org, Kevin Rich <kevinrich1337@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] netfilter/nf_tables: fix UAF in catchall element removal
Date: Thu, 28 Dec 2023 23:00:45 +0100 [thread overview]
Message-ID: <20231228220045.GA598@breakpoint.cc> (raw)
In-Reply-To: <CAHk-=wg1VJR4WFT4VhEqXgE14dogJe9kbpYGBZdtai3ORomfOw@mail.gmail.com>
Linus Torvalds <torvalds@linuxfoundation.org> wrote:
> On Thu, 28 Dec 2023 at 06:38, Wander Lairson Costa <wander@redhat.com> wrote:
> >
> > If the catchall element is gc'd when the pipapo set is removed, the element
> > can be deactivated twice.
> >
> > When a set is deleted, the nft_map_deactivate() is called to deactivate the
> > data of the set elements [1].
>
> Please send this to the netdev list and netfilter-devel, it's already
> on a public list thanks to the stable cc.
>
> Pablo & al - see
>
> https://lore.kernel.org/all/20231228143737.17712-1-wander@redhat.com/
>
> for the original full email.
Thanks. I suspect the correct fix is
https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git/commit/?id=7315dc1e122c85ffdfc8defffbb8f8b616c2eb1a
which missed the last pre-holiday-shutdown net pull request and
is thus still only in nf.git.
next prev parent reply other threads:[~2023-12-28 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 14:37 [PATCH] netfilter/nf_tables: fix UAF in catchall element removal Wander Lairson Costa
2023-12-28 21:09 ` Linus Torvalds
2023-12-28 22:00 ` Florian Westphal [this message]
2023-12-29 13:15 ` Wander Lairson Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231228220045.GA598@breakpoint.cc \
--to=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kevinrich1337@gmail.com \
--cc=pablo@netfilter.org \
--cc=security@kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linuxfoundation.org \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.