From: Rob Herring <robh@kernel.org>
To: Mark Hasemeyer <markhas@chromium.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Raul Rangel <rrangel@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource()
Date: Tue, 2 Jan 2024 09:01:04 -0700 [thread overview]
Message-ID: <20240102160104.GA2915145-robh@kernel.org> (raw)
In-Reply-To: <CANg-bXCrR2FKSi6ik7LZBqTQz9=HDW=0cy7GZN0yaB0PsKKjkQ@mail.gmail.com>
On Wed, Dec 27, 2023 at 11:21:14AM -0700, Mark Hasemeyer wrote:
> >
> > > + u32 irq_flags;
> > > const char *name = NULL;
> >
> > Don't know if OF style requires reversed xmas tree order. If so, this should be
> >
> > const char *name = NULL;
> > u32 irq_flags;
> >
>
> I see both methods used. For example, of_irq_init() uses normal xmas
> tree order. I'll leave it unless Rob says otherwise.
> It is Christmas time, so I do want to honor the Christmas trees appropriately!
DT requires sideways Christmas tree because we're special. You'll have
to add a 3rd variable. ;)
Rob
next prev parent reply other threads:[~2024-01-02 16:01 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 01/24] resource: Add DEFINE_RES_*_NAMED_FLAGS macro Mark Hasemeyer
2023-12-27 17:05 ` Andy Shevchenko
2023-12-26 19:21 ` [PATCH v3 02/24] gpiolib: acpi: Modify acpi_dev_irq_wake_get_by() to use resource Mark Hasemeyer
2023-12-27 17:12 ` Andy Shevchenko
2024-01-02 20:03 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 03/24] i2c: acpi: Modify i2c_acpi_get_irq() " Mark Hasemeyer
2023-12-27 17:17 ` Andy Shevchenko
2023-12-26 19:21 ` [PATCH v3 04/24] dt-bindings: power: Clarify wording for wakeup-source property Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 05/24] ARM: dts: tegra: Enable cros-ec-spi as wake source Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 06/24] ARM: dts: rockchip: rk3288: " Mark Hasemeyer
2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 07/24] ARM: dts: samsung: exynos5420: " Mark Hasemeyer
2023-12-26 19:21 ` Mark Hasemeyer
2023-12-27 11:54 ` Krzysztof Kozlowski
2023-12-27 11:54 ` Krzysztof Kozlowski
2023-12-26 19:21 ` [PATCH v3 08/24] ARM: dts: samsung: exynos5800: " Mark Hasemeyer
2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 09/24] arm64: dts: mediatek: mt8173: " Mark Hasemeyer
2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 10/24] arm64: dts: mediatek: mt8183: " Mark Hasemeyer
2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 11/24] arm64: dts: mediatek: mt8192: " Mark Hasemeyer
2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 12/24] arm64: dts: mediatek: mt8195: " Mark Hasemeyer
2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 13/24] arm64: dts: tegra: " Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 14/24] arm64: dts: qcom: sc7180: " Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 15/24] arm64: dts: qcom: sc7280: " Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 16/24] arm64: dts: qcom: sdm845: " Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 17/24] arm64: dts: rockchip: rk3399: " Mark Hasemeyer
2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource() Mark Hasemeyer
2023-12-27 17:19 ` Andy Shevchenko
2023-12-27 18:21 ` Mark Hasemeyer
2024-01-02 16:01 ` Rob Herring [this message]
2024-01-02 16:01 ` Rob Herring
2023-12-26 19:21 ` [PATCH v3 19/24] of: irq: Add default implementation for of_irq_to_resource() Mark Hasemeyer
2024-01-02 16:02 ` Rob Herring
2024-01-02 16:53 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 20/24] of: irq: Remove extern from function declarations Mark Hasemeyer
2024-01-02 16:02 ` Rob Herring
2023-12-26 19:21 ` [PATCH v3 21/24] device property: Modify fwnode irq_get() to use resource Mark Hasemeyer
2023-12-27 17:24 ` Andy Shevchenko
2023-12-27 19:09 ` Mark Hasemeyer
2024-01-06 14:05 ` Andy Shevchenko
2023-12-26 19:21 ` [PATCH v3 22/24] device property: Update functions to use EXPORT_SYMBOL_GPL Mark Hasemeyer
2023-12-27 17:26 ` Andy Shevchenko
2023-12-26 19:21 ` [PATCH v3 23/24] platform: Modify platform_get_irq_optional() to use resource Mark Hasemeyer
2023-12-27 17:30 ` Andy Shevchenko
2023-12-27 20:33 ` Mark Hasemeyer
2024-01-06 14:09 ` Andy Shevchenko
2023-12-26 19:21 ` [PATCH v3 24/24] platform/chrome: cros_ec: Use PM subsystem to manage wakeirq Mark Hasemeyer
2023-12-27 6:26 ` Tzung-Bi Shih
2023-12-27 20:45 ` Mark Hasemeyer
2023-12-27 17:34 ` Andy Shevchenko
2023-12-27 21:29 ` Mark Hasemeyer
2023-12-28 2:18 ` Tzung-Bi Shih
2024-02-14 17:57 ` (subset) [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Bjorn Andersson
2024-02-14 17:57 ` Bjorn Andersson
2024-02-16 11:31 ` Thierry Reding
2024-02-16 11:31 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240102160104.GA2915145-robh@kernel.org \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markhas@chromium.org \
--cc=rrangel@chromium.org \
--cc=sudeep.holla@arm.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.