From: "Marek Behún" <marek.behun@nic.cz>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Russell King <rmk+kernel@armlinux.org.uk>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/5] ethtool: add struct ethtool_keee and extend struct ethtool_eee
Date: Thu, 4 Jan 2024 17:27:08 +0100 [thread overview]
Message-ID: <20240104172708.2db5ddaa@dellmb> (raw)
In-Reply-To: <a044621e-07f3-4387-9573-015f255db895@gmail.com>
On Mon, 1 Jan 2024 22:23:15 +0100
Heiner Kallweit <hkallweit1@gmail.com> wrote:
> + * @is_member_of_keee: struct is member of a struct ethtool_keee
I don't like how the name of a field in a UAPI structure refers to
kernel internals.
Can we rename it somehow?
Marek
next prev parent reply other threads:[~2024-01-04 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-01 21:22 [PATCH net-next 0/5] ethtool: add support for EEE linkmodes beyond bit 32 Heiner Kallweit
2024-01-01 21:23 ` [PATCH net-next 1/5] ethtool: add struct ethtool_keee and extend struct ethtool_eee Heiner Kallweit
2024-01-04 16:27 ` Marek Behún [this message]
2024-01-04 16:46 ` Heiner Kallweit
2024-01-04 17:16 ` Andrew Lunn
2024-01-04 20:30 ` Heiner Kallweit
2024-01-05 22:35 ` Heiner Kallweit
2024-01-05 23:15 ` Andrew Lunn
2024-01-08 15:38 ` Russell King (Oracle)
2024-01-01 21:24 ` [PATCH net-next 2/5] ethtool: add basic handling of struct ethtool_keee Heiner Kallweit
2024-01-01 21:25 ` [PATCH net-next 3/5] ethtool: send EEE linkmode bitmaps to userspace Heiner Kallweit
2024-01-01 21:26 ` [PATCH net-next 4/5] net: phy: c45: prepare genphy_c45_ethtool_set_eee for follow-up extension Heiner Kallweit
2024-01-01 21:28 ` [PATCH net-next 5/5] net: phy: c45: extend genphy_c45_ethtool_[set|get]_eee Heiner Kallweit
2024-01-06 19:44 ` [PATCH net-next 0/5] ethtool: add support for EEE linkmodes beyond bit 32 Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104172708.2db5ddaa@dellmb \
--to=marek.behun@nic.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.