From: David Disseldorp <ddiss@suse.de>
To: Zorro Lang <zlang@redhat.com>
Cc: Chung-Chiang Cheng <cccheng@synology.com>,
fstests@vger.kernel.org, shepjeng@gmail.com, kernel@cccheng.net
Subject: Re: [PATCH] README: add a missing necessary package
Date: Thu, 4 Jan 2024 21:39:02 +1100 [thread overview]
Message-ID: <20240104213902.4e2a2386@echidna> (raw)
In-Reply-To: <20240104084108.m3ts24cee7nb7wom@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On Thu, 4 Jan 2024 16:41:08 +0800, Zorro Lang wrote:
> On Thu, Jan 04, 2024 at 01:42:36PM +0800, Chung-Chiang Cheng wrote:
> > src/dbtests.c requires 'gdbm-ndbm.h' or 'ndbm.h', both of which are
> > supplied by 'libgdbm-compat-dev' in the latest Ubuntu LTS. However,
> > this package is not a dependency of the currently listed packages.
> > Therefore, add it explicitly to the necessary packages list.
> >
> > $ dpkg -L libgdbm-compat-dev
> > /.
> > /usr
> > /usr/include
> > /usr/include/dbm.h
> > /usr/include/gdbm-ndbm.h
> > /usr/include/ndbm.h
> >
> > Signed-off-by: Chung-Chiang Cheng <cccheng@synology.com>
> > ---
> > README | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/README b/README
> > index e0dabe96503a..c46690c4eabb 100644
> > --- a/README
> > +++ b/README
> > @@ -11,7 +11,8 @@ Ubuntu or Debian
> > $ sudo apt-get install acl attr automake bc dbench dump e2fsprogs fio gawk \
> > gcc git indent libacl1-dev libaio-dev libcap-dev libgdbm-dev libtool \
> > libtool-bin liburing-dev libuuid1 lvm2 make psmisc python3 quota sed \
> > - uuid-dev uuid-runtime xfsprogs linux-headers-$(uname -r) sqlite3
> > + uuid-dev uuid-runtime xfsprogs linux-headers-$(uname -r) sqlite3 \
> > + libgdbm-compat-dev
>
> Oh, We call it "gdbm-devel" in Fedora. Thanks for this updating for Debian!
>
> Reviewed-by: Zorro Lang <zlang@redhat.com>
While you're there, please feel free to collapse in:
--- a/README
+++ b/README
@@ -76,7 +76,8 @@ SUSE Linux Enterprise or openSUSE
$ sudo zypper install acct automake bc dbench duperemove dump fio gcc git \
indent libacl-devel libaio-devel libattr-devel libcap libcap-devel \
- libtool liburing-devel libuuid-devel lvm2 make quota sqlite3 xfsprogs
+ libtool liburing-devel libuuid-devel lvm2 make quota sqlite3 xfsprogs \
+ gdbm-devel
Reviewed-by: David Disseldorp <ddiss@suse.de>
Thanks, David
prev parent reply other threads:[~2024-01-04 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 5:42 [PATCH] README: add a missing necessary package Chung-Chiang Cheng
2024-01-04 8:41 ` Zorro Lang
2024-01-04 10:39 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104213902.4e2a2386@echidna \
--to=ddiss@suse.de \
--cc=cccheng@synology.com \
--cc=fstests@vger.kernel.org \
--cc=kernel@cccheng.net \
--cc=shepjeng@gmail.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.