All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	Pavel Kozlov <Pavel.Kozlov@synopsys.com>,
	Vladimir Isaev <VVIsaev@gmail.com>,
	Alexey Brodkin via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] arch: Set max/common-page-size for libgcc & libstdc++
Date: Thu, 4 Jan 2024 22:38:23 +0100	[thread overview]
Message-ID: <20240104223823.1bb97896@windsurf> (raw)
In-Reply-To: <ZZckauC7K7-qR0lP@landeda>

On Thu, 4 Jan 2024 22:34:34 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> > But I'm surprised they are not needed also in the C library build. Why
> > are you not seeing the same problem with the C library build, it should
> > also need the same page size flags, doesn't it?  
> 
> It is my understanding that the toolchain wrapper is installed as a post
> initial gcc hook as well:
> 
>    package/gcc/gcc-initial/gcc-initial.mk:
>    59 HOST_GCC_INITIAL_POST_BUILD_HOOKS += TOOLCHAIN_WRAPPER_BUILD
>    60 HOST_GCC_INITIAL_POST_INSTALL_HOOKS += TOOLCHAIN_WRAPPER_INSTALL
>    61 HOST_GCC_INITIAL_POST_INSTALL_HOOKS += HOST_GCC_INSTALL_WRAPPER_AND_SIMPLE_SYMLINKS
> 
> So the C libraries are built using our wrapper.

Hum, indeed. But then, why doesn't that apply to libgcc and libstdc++
as well? It is because libgcc/libstdc++ are built with the second stage
gcc, before it is installed and wrapped by our wrapper? I guess so
because the first stage gcc isn't capable of building shared libraries,
or something like that.

So, indeed, my proposal to Alexey is to use ARCH_TOOLCHAIN_WRAPPER_OPTS
in gcc.mk. This will allow to get rid of the special -matomic addition.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-01-04 21:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-03 10:23 [Buildroot] [PATCH] arch: Set max/common-page-size for libgcc & libstdc++ Alexey Brodkin via buildroot
2024-01-04 21:19 ` Thomas Petazzoni via buildroot
2024-01-04 21:34   ` Yann E. MORIN
2024-01-04 21:38     ` Thomas Petazzoni via buildroot [this message]
2024-01-04 22:22       ` Alexey Brodkin via buildroot
2024-01-04 22:42         ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240104223823.1bb97896@windsurf \
    --to=buildroot@buildroot.org \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=Pavel.Kozlov@synopsys.com \
    --cc=VVIsaev@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.