Re: [meta-rockchip] [PATCH] rock 4c+: add

[Trevor Woerner <twoerner@gmail.com>]

Hi Stephen,

Thanks for the patch.

Please use the proposed Yocto name for the board you are adding.

On Thu 2023-12-21 @ 09:41:00 AM, Stephen Chen wrote:
> ROCK 4C+ is a Rockchip RK3399-T based SBC from Radxa.
> Main differences of ROCK 4C+ compared to other ROCK 4 SBC.
> - Rockchip RK3399-T SoC
> - DP from ROCK Pi 4C replaced with micro HDMI 2K@60fps
> - 4-lane MIPI DSI
> - RK817 Audio codec

I want to see the capabilities of the board that is being added. Not what
amounts to a diff between this new board and some other random board.

Could you add the new board to the README file as well (the list is sorted
chronologically, later entries are the most recently-added boards).

Also, do we need to add a COMPATIBLE_MACHINE entry for the kernel?

> 
> Signed-off-by: Stephen Chen <stephen@radxa.com>
> ---
>  conf/machine/rock-4c-plus.conf | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>  create mode 100644 conf/machine/rock-4c-plus.conf
> 
> diff --git a/conf/machine/rock-4c-plus.conf b/conf/machine/rock-4c-plus.conf
> new file mode 100644
> index 0000000..424fed2
> --- /dev/null
> +++ b/conf/machine/rock-4c-plus.conf
> @@ -0,0 +1,10 @@
> +#@TYPE: Machine
> +#@NAME: ROCK 4C+
> +#@DESCRIPTION: ROCK 4C+ based on Rockchip RK3399-T Processor is designed by Radxa.
> +#https://wiki.radxa.com/Rock4/4cplus
> +#https://docs.radxa.com/en/rock4/rock4c+
> +
> +require conf/machine/include/rock-pi-4.inc
> +
> +KERNEL_DEVICETREE = "rockchip/rk3399-rock-4c-plus.dtb"
> +UBOOT_MACHINE = "rock-4c-plus-rk3399_defconfig"
> -- 
> 2.34.1
>