From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67DB611CB1 for ; Sun, 7 Jan 2024 05:19:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Cbwz7mG8" Received: by mail-il1-f182.google.com with SMTP id e9e14a558f8ab-36071f2181cso5659805ab.2 for ; Sat, 06 Jan 2024 21:19:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704604764; x=1705209564; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=nSuwiElX6PlNT4aUpgUOVoJxMe2k+o3qKu2vP2pacdg=; b=Cbwz7mG8Z6JG2PVjpY6gE0OOhDXXS4I/mbbafKWz3bbn1ewx19X7h0xLgCMzLiMXnV cES7TLVGMd05F0F/+8vImI73Nk7h/HlRIl8AjPouuqyvXg66S5JVm9Z+6du2e8pifOvy LDGkQz0YWeZhZFGeGew7GCiI0Bk9y23iXx2c06l3DJcJV1sY9U5H6K5wphL/V4+FY71J B1LkTg0UCzR6LNNuWPNRBCBd2EeefJUBicJJwC8G9/Q1mTf2VXFyNrmLkeMGt/qAJ9VT BF6xAJMV6pgL3mmigMUfS2bU3TIboJxLwxqyCtZzGI09v0PM5MjePTurtHlVfD9zNaBO 5ILQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704604764; x=1705209564; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nSuwiElX6PlNT4aUpgUOVoJxMe2k+o3qKu2vP2pacdg=; b=RX/+4cbtzn4m+drGNOiDFIj2qdwv0Bv0/DZ3hoayxy7XolGSsCoDT239LOYFvvEkUp 0hTSyrwA+Rp1WQiEJgxADgjwrCK2wDX1Y1J5qcKg8GjSJzrvSUBsR6hEmkWIcjd5rKd6 OnGyPaMKPW4TecZAVSwHYgwpBIyGctGRlIBWzClgHOQrbGPBQMRX38pv+FmYgbxsQKTh /zZEv45pYBKs0KUch8EWppRS6IlwAX0I3H33nt7i6DIUY4SJq8AJU/PIGKz95AyyQzSI F8JSxvkF3gshl1So64C4Sh6WiahDwRhhQet0RI01xFHnkRhNCIVwQizqb6rizPRK7lpy XCUg== X-Gm-Message-State: AOJu0YxOsuoL38PhGnds3ekfGKxEeHcNNAtWdfMBZT/CmP64empkM3qe 4uww7kKuB8NlaVoO98Iy51p7eO6q69aO X-Google-Smtp-Source: AGHT+IEnEAm1Yc7lppJUT8BX2yQ4Qk4lMAc3HGwoofXeJi9xbmN1moHDvBu414uQ4we4GX7vBQDchQ== X-Received: by 2002:a05:6e02:3883:b0:360:5cd9:a73e with SMTP id cn3-20020a056e02388300b003605cd9a73emr3323633ilb.6.1704604764612; Sat, 06 Jan 2024 21:19:24 -0800 (PST) Received: from thinkpad ([103.197.115.97]) by smtp.gmail.com with ESMTPSA id jj4-20020a170903048400b001d078445059sm3857763plb.143.2024.01.06.21.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 21:19:24 -0800 (PST) Date: Sun, 7 Jan 2024 10:49:17 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v7 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ Message-ID: <20240107051917.GG3416@thinkpad> References: <20231227182727.1747435-1-Frank.Li@nxp.com> <20231227182727.1747435-5-Frank.Li@nxp.com> <20240107031506.GC3416@thinkpad> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Jan 06, 2024 at 11:47:36PM -0500, Frank Li wrote: > On Sun, Jan 07, 2024 at 08:45:06AM +0530, Manivannan Sadhasivam wrote: > > On Wed, Dec 27, 2023 at 01:27:15PM -0500, Frank Li wrote: > > > iMX8MQ have two pci controllers. Adds "linux,pci-domain" as required > > > proptery for iMX8MQ to indicate pci controller index. > > > > > > > property > > > > > This adjustment paves the way for eliminating the hardcoded check on the > > > base register for acquiring the controller_id. > > > > > > ... > > > if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) > > > imx6_pcie->controller_id = 1; > > > ... > > > > > > The controller_id is crucial and utilized for certain register bit > > > positions. It must align precisely with the controller index in the SoC. > > > An auto-incremented ID don't fit this case. The DTS or fuse configurations > > > may deactivate specific PCI controllers. > > > > > > > You cannot change the binding for the sake of driver. But you can make this > > change in other way. See below... > > > > > Signed-off-by: Frank Li > > > --- > > > > > > Notes: > > > Change from v5 to v6 > > > - rework commit message to explain why need required and why auto increase > > > id not work > > > > > > Change from v4 to v5 > > > - new patch at v5 > > > > > > .../bindings/pci/fsl,imx6q-pcie-common.yaml | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > > > index d91b639ae7ae7..8f39b4e6e8491 100644 > > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > > > @@ -265,6 +265,17 @@ allOf: > > > - const: apps > > > - const: turnoff > > > > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - fsl,imx8mq-pcie > > > + - fsl,imx8mq-pcie-ep > > > > "linux,pci-domain" is a generic property. So you cannot make it required only > > for certain SoCs. > > Sorry, why not? there are many generic property. > It doesn't make sense to make it required only for specific SoCs since it is not specific to any SoC. You can make it required for all. > > But you can make it so for all SoCs. This way, the drivers > > can also rely on it. > > > > Now, you should get rid of the commit message about driver internals: > > Not all dts already added "linux,pci-domain" yet. If required for all SOCs, > it will cause dtb check warnings. > You can safely add this property to all DTS. Nothing will break. - Mani > Frank > > > > > This adjustment paves the way for eliminating the hardcoded check on the > > > base register for acquiring the controller_id. > > > > > > ... > > > if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) > > > imx6_pcie->controller_id = 1; > > > ... > > > > > > The controller_id is crucial and utilized for certain register bit > > > positions. It must align precisely with the controller index in the SoC. > > > An auto-incremented ID don't fit this case. The DTS or fuse configurations > > > may deactivate specific PCI controllers. > > > > > > > - Mani > > > > > + then: > > > + required: > > > + - linux,pci-domain > > > + > > > additionalProperties: true > > > > > > ... > > > -- > > > 2.34.1 > > > > > > > -- > > மணிவண்ணன் சதாசிவம் -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDA20C47077 for ; Sun, 7 Jan 2024 05:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2YbyYob9ZGWYSb5Rjrk8W4ovQt8pOjNLsl1qrrdH67w=; b=DG/3O0vQt546T0 q5GYk1P79OQexz1vZLaK2/8rWhSwikwLoQGoWrW0tbzZtr/N+Jq1KFP/6JXGg8TjcklRTx20mGguO vVkAdKeKb4O26a8ToPPO/BVDmhq2DhZcYmVwC3uF8P5uhaB5J/0mojrfPwRqVymxsIkQrZK7p9i5q 9gVLBkLtiyp5f5+//+0b12HnNRG1CDejP5bJpZ5LZ9vj8d1gGOkf+hdBRlQzFsjRmcAEJkj7/yeOU z/vRGUWpYbo+JyoyVqCg87KAqSKr+DZfP+g8GtUqXBo+nRjInA403XJ/KuhfzksGxMat6EHs0I3yP gbQC3fQQ6EWfG7vofnag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rMLZK-002O46-0g; Sun, 07 Jan 2024 05:19:30 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rMLZH-002O3d-04 for linux-arm-kernel@lists.infradead.org; Sun, 07 Jan 2024 05:19:28 +0000 Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-7bc3e297bc9so30777139f.3 for ; Sat, 06 Jan 2024 21:19:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704604764; x=1705209564; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=nSuwiElX6PlNT4aUpgUOVoJxMe2k+o3qKu2vP2pacdg=; b=SBye/pHBCBsZKfwPV2PbBVuSY3edn3p2SSQxxGhyHIML1r8zPrF4K8JwVsR886m5qE u906p9vTXChAZja7VsaOMJIQd4kU1tB5cOKNnnq6OomeUamQsCWVoLOna9mafiwMlFlq UO1caCvXPZyqmCaIOgsvavfmlhpcVrkFwu8yX3EYhD6vyldxCWitq42UQqstw97of0oS tNlfuxMEbwRWFjT2xney2NpB3JjkpoHgp2mRbKx0FK5oxNJGmycjCy39edLThSrWwaZ2 TUJvYV6W6LLXZ1SuywiGb+Df+hGvIWiHqkIlFCo7yEFOmGfuHR/g4ktujkP0k2s346jW Hj+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704604764; x=1705209564; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nSuwiElX6PlNT4aUpgUOVoJxMe2k+o3qKu2vP2pacdg=; b=hP0Xl5fDKwAWZtIs6Q0Fv2q5ikysIEeuGh71Vo3mZBKvWnZOKB/BZE5eprqy4QlVWx 2DnMQ6Yliu9yDzVbpXG+X/T4u0M3h+7svZe5+jiIM6y/icrJ+6Tg+h9UmwLd0GxEc8rv GPwXcsaIPPesC1EBKxdmKz7ngNK36mDQAKkNfNrooF1wzG6cidfQb63JfnxqnxODAGCn Ku/xrKwNdzXPI04CFjpDJhRcrADmW3LYJBxwI7nPDH7flLpeCua68But8nq8iGIcAxWC iLpMUuxtxcgiT34UicOpvkIDkVilYufvbuElfbX2x4zC6r/A5uiF0zXBzNPSlQARad/R AjJg== X-Gm-Message-State: AOJu0YzcRyLuS7ZOm7YOFqxKxVeRSCpQ7s1O/9Ufao1pcyv0xh1hlEWw BJhsg97eMFglBPchP21+bSnZBYDEv9OO X-Google-Smtp-Source: AGHT+IEnEAm1Yc7lppJUT8BX2yQ4Qk4lMAc3HGwoofXeJi9xbmN1moHDvBu414uQ4we4GX7vBQDchQ== X-Received: by 2002:a05:6e02:3883:b0:360:5cd9:a73e with SMTP id cn3-20020a056e02388300b003605cd9a73emr3323633ilb.6.1704604764612; Sat, 06 Jan 2024 21:19:24 -0800 (PST) Received: from thinkpad ([103.197.115.97]) by smtp.gmail.com with ESMTPSA id jj4-20020a170903048400b001d078445059sm3857763plb.143.2024.01.06.21.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 21:19:24 -0800 (PST) Date: Sun, 7 Jan 2024 10:49:17 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v7 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ Message-ID: <20240107051917.GG3416@thinkpad> References: <20231227182727.1747435-1-Frank.Li@nxp.com> <20231227182727.1747435-5-Frank.Li@nxp.com> <20240107031506.GC3416@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240106_211927_067444_EEF0068A X-CRM114-Status: GOOD ( 34.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBKYW4gMDYsIDIwMjQgYXQgMTE6NDc6MzZQTSAtMDUwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gT24gU3VuLCBKYW4gMDcsIDIwMjQgYXQgMDg6NDU6MDZBTSArMDUzMCwgTWFuaXZhbm5hbiBT YWRoYXNpdmFtIHdyb3RlOgo+ID4gT24gV2VkLCBEZWMgMjcsIDIwMjMgYXQgMDE6Mjc6MTVQTSAt MDUwMCwgRnJhbmsgTGkgd3JvdGU6Cj4gPiA+IGlNWDhNUSBoYXZlIHR3byBwY2kgY29udHJvbGxl cnMuIEFkZHMgImxpbnV4LHBjaS1kb21haW4iIGFzIHJlcXVpcmVkCj4gPiA+IHByb3B0ZXJ5IGZv ciBpTVg4TVEgdG8gaW5kaWNhdGUgcGNpIGNvbnRyb2xsZXIgaW5kZXguCj4gPiA+IAo+ID4gCj4g PiBwcm9wZXJ0eQo+ID4gCj4gPiA+IFRoaXMgYWRqdXN0bWVudCBwYXZlcyB0aGUgd2F5IGZvciBl bGltaW5hdGluZyB0aGUgaGFyZGNvZGVkIGNoZWNrIG9uIHRoZQo+ID4gPiBiYXNlIHJlZ2lzdGVy IGZvciBhY3F1aXJpbmcgdGhlIGNvbnRyb2xsZXJfaWQuCj4gPiA+IAo+ID4gPiAJLi4uCj4gPiA+ IAlpZiAoZGJpX2Jhc2UtPnN0YXJ0ID09IElNWDhNUV9QQ0lFMl9CQVNFX0FERFIpCj4gPiA+IAkJ aW14Nl9wY2llLT5jb250cm9sbGVyX2lkID0gMTsKPiA+ID4gCS4uLgo+ID4gPiAKPiA+ID4gVGhl IGNvbnRyb2xsZXJfaWQgaXMgY3J1Y2lhbCBhbmQgdXRpbGl6ZWQgZm9yIGNlcnRhaW4gcmVnaXN0 ZXIgYml0Cj4gPiA+IHBvc2l0aW9ucy4gSXQgbXVzdCBhbGlnbiBwcmVjaXNlbHkgd2l0aCB0aGUg Y29udHJvbGxlciBpbmRleCBpbiB0aGUgU29DLgo+ID4gPiBBbiBhdXRvLWluY3JlbWVudGVkIElE IGRvbid0IGZpdCB0aGlzIGNhc2UuIFRoZSBEVFMgb3IgZnVzZSBjb25maWd1cmF0aW9ucwo+ID4g PiBtYXkgZGVhY3RpdmF0ZSBzcGVjaWZpYyBQQ0kgY29udHJvbGxlcnMuCj4gPiA+IAo+ID4gCj4g PiBZb3UgY2Fubm90IGNoYW5nZSB0aGUgYmluZGluZyBmb3IgdGhlIHNha2Ugb2YgZHJpdmVyLiBC dXQgeW91IGNhbiBtYWtlIHRoaXMKPiA+IGNoYW5nZSBpbiBvdGhlciB3YXkuIFNlZSBiZWxvdy4u Lgo+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEZyYW5rIExpIDxGcmFuay5MaUBueHAuY29tPgo+ ID4gPiAtLS0KPiA+ID4gCj4gPiA+IE5vdGVzOgo+ID4gPiAgICAgQ2hhbmdlIGZyb20gdjUgdG8g djYKPiA+ID4gICAgIC0gcmV3b3JrIGNvbW1pdCBtZXNzYWdlIHRvIGV4cGxhaW4gd2h5IG5lZWQg cmVxdWlyZWQgYW5kIHdoeSBhdXRvIGluY3JlYXNlCj4gPiA+ICAgICBpZCBub3Qgd29yawo+ID4g PiAgICAgCj4gPiA+ICAgICBDaGFuZ2UgZnJvbSB2NCB0byB2NQo+ID4gPiAgICAgLSBuZXcgcGF0 Y2ggYXQgdjUKPiA+ID4gCj4gPiA+ICAuLi4vYmluZGluZ3MvcGNpL2ZzbCxpbXg2cS1wY2llLWNv bW1vbi55YW1sICAgICAgICAgICB8IDExICsrKysrKysrKysrCj4gPiA+ICAxIGZpbGUgY2hhbmdl ZCwgMTEgaW5zZXJ0aW9ucygrKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kvZnNsLGlteDZxLXBjaWUtY29tbW9uLnlhbWwgYi9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2ZzbCxpbXg2cS1wY2llLWNvbW1v bi55YW1sCj4gPiA+IGluZGV4IGQ5MWI2MzlhZTdhZTcuLjhmMzliNGU2ZTg0OTEgMTAwNjQ0Cj4g PiA+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kvZnNsLGlteDZx LXBjaWUtY29tbW9uLnlhbWwKPiA+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL3BjaS9mc2wsaW14NnEtcGNpZS1jb21tb24ueWFtbAo+ID4gPiBAQCAtMjY1LDYgKzI2 NSwxNyBAQCBhbGxPZjoKPiA+ID4gICAgICAgICAgICAgIC0gY29uc3Q6IGFwcHMKPiA+ID4gICAg ICAgICAgICAgIC0gY29uc3Q6IHR1cm5vZmYKPiA+ID4gIAo+ID4gPiArICAtIGlmOgo+ID4gPiAr ICAgICAgcHJvcGVydGllczoKPiA+ID4gKyAgICAgICAgY29tcGF0aWJsZToKPiA+ID4gKyAgICAg ICAgICBjb250YWluczoKPiA+ID4gKyAgICAgICAgICAgIGVudW06Cj4gPiA+ICsgICAgICAgICAg ICAgIC0gZnNsLGlteDhtcS1wY2llCj4gPiA+ICsgICAgICAgICAgICAgIC0gZnNsLGlteDhtcS1w Y2llLWVwCj4gPiAKPiA+ICJsaW51eCxwY2ktZG9tYWluIiBpcyBhIGdlbmVyaWMgcHJvcGVydHku IFNvIHlvdSBjYW5ub3QgbWFrZSBpdCByZXF1aXJlZCBvbmx5Cj4gPiBmb3IgY2VydGFpbiBTb0Nz LiAKPiAKPiBTb3JyeSwgd2h5IG5vdD8gdGhlcmUgYXJlIG1hbnkgZ2VuZXJpYyBwcm9wZXJ0eS4K PiAKCkl0IGRvZXNuJ3QgbWFrZSBzZW5zZSB0byBtYWtlIGl0IHJlcXVpcmVkIG9ubHkgZm9yIHNw ZWNpZmljIFNvQ3Mgc2luY2UgaXQgaXMgbm90CnNwZWNpZmljIHRvIGFueSBTb0MuIFlvdSBjYW4g bWFrZSBpdCByZXF1aXJlZCBmb3IgYWxsLgoKPiA+IEJ1dCB5b3UgY2FuIG1ha2UgaXQgc28gZm9y IGFsbCBTb0NzLiBUaGlzIHdheSwgdGhlIGRyaXZlcnMKPiA+IGNhbiBhbHNvIHJlbHkgb24gaXQu Cj4gPiAKPiA+IE5vdywgeW91IHNob3VsZCBnZXQgcmlkIG9mIHRoZSBjb21taXQgbWVzc2FnZSBh Ym91dCBkcml2ZXIgaW50ZXJuYWxzOgo+IAo+IE5vdCBhbGwgZHRzIGFscmVhZHkgYWRkZWQgImxp bnV4LHBjaS1kb21haW4iIHlldC4gSWYgcmVxdWlyZWQgZm9yIGFsbCBTT0NzLAo+IGl0IHdpbGwg Y2F1c2UgZHRiIGNoZWNrIHdhcm5pbmdzLgo+IAoKWW91IGNhbiBzYWZlbHkgYWRkIHRoaXMgcHJv cGVydHkgdG8gYWxsIERUUy4gTm90aGluZyB3aWxsIGJyZWFrLgoKLSBNYW5pCgo+IEZyYW5rCj4g PiAKPiA+ID4gVGhpcyBhZGp1c3RtZW50IHBhdmVzIHRoZSB3YXkgZm9yIGVsaW1pbmF0aW5nIHRo ZSBoYXJkY29kZWQgY2hlY2sgb24gdGhlCj4gPiA+IGJhc2UgcmVnaXN0ZXIgZm9yIGFjcXVpcmlu ZyB0aGUgY29udHJvbGxlcl9pZC4KPiA+ID4gCj4gPiA+ICAgICAgIC4uLgo+ID4gPiAgICAgICBp ZiAoZGJpX2Jhc2UtPnN0YXJ0ID09IElNWDhNUV9QQ0lFMl9CQVNFX0FERFIpCj4gPiA+ICAgICAg ICAgICAgICAgaW14Nl9wY2llLT5jb250cm9sbGVyX2lkID0gMTsKPiA+ID4gICAgICAgLi4uCj4g PiA+IAo+ID4gPiBUaGUgY29udHJvbGxlcl9pZCBpcyBjcnVjaWFsIGFuZCB1dGlsaXplZCBmb3Ig Y2VydGFpbiByZWdpc3RlciBiaXQKPiA+ID4gcG9zaXRpb25zLiBJdCBtdXN0IGFsaWduIHByZWNp c2VseSB3aXRoIHRoZSBjb250cm9sbGVyIGluZGV4IGluIHRoZSBTb0MuCj4gPiA+IEFuIGF1dG8t aW5jcmVtZW50ZWQgSUQgZG9uJ3QgZml0IHRoaXMgY2FzZS4gVGhlIERUUyBvciBmdXNlIGNvbmZp Z3VyYXRpb25zCj4gPiA+IG1heSBkZWFjdGl2YXRlIHNwZWNpZmljIFBDSSBjb250cm9sbGVycy4K PiA+ID4gCj4gPiAKPiA+IC0gTWFuaQo+ID4gCj4gPiA+ICsgICAgdGhlbjoKPiA+ID4gKyAgICAg IHJlcXVpcmVkOgo+ID4gPiArICAgICAgICAtIGxpbnV4LHBjaS1kb21haW4KPiA+ID4gKwo+ID4g PiAgYWRkaXRpb25hbFByb3BlcnRpZXM6IHRydWUKPiA+ID4gIAo+ID4gPiAgLi4uCj4gPiA+IC0t IAo+ID4gPiAyLjM0LjEKPiA+ID4gCj4gPiAKPiA+IC0tIAo+ID4g4K6u4K6j4K6/4K614K6j4K+N 4K6j4K6p4K+NIOCumuCupOCuvuCumuCuv+CuteCuruCvjQoKLS0gCuCuruCuo+Cuv+CuteCuo+Cv jeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK