From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4678125A4 for ; Sun, 7 Jan 2024 05:34:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oYDgEcLe" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6d9f94b9186so736678b3a.0 for ; Sat, 06 Jan 2024 21:34:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704605659; x=1705210459; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=HqP4dggxSEGDvqw7GUe9RC6veZbTj2SMAyF3Y7WYNr4=; b=oYDgEcLe7ZPrQk5goqCS/c/7oQL9qiU9HL7bJkwUZp7t6n65Ad8wo97TipOQ9vk1OR 3hLH1Q5oWzriabIuxp7xI6awyB5UidTBozBF33/MwaD2SOWbahLfUbiU3sovL99DPk8h xhkscmlmW53B8JiUe3f31Zlt0xwOxwAxmu/EveVPJH08+C4vitvDdL0WFw7OhssUxNUn 9BXuieQ4CSLa2r67H000l2Ul3JLKR1UAOBTx5FVmKSrHzPZJI4FfJ7TV/KuEBTfeccyU dgkIcfXdYKE2wvTioVJIzXvp8HFHKtmLTxvcJBlPmaL8xposAYb8JnVQ6JoKmIk0GvE/ CheQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704605659; x=1705210459; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HqP4dggxSEGDvqw7GUe9RC6veZbTj2SMAyF3Y7WYNr4=; b=pMnRkGyUoeaGGi3hsRMwCF0AKbJnivaN/ciO5IMZUFpBKs0R+mhCJAjUFPiwq3vaIJ ekD5R9OUdbQcfa0NQhOSj15/UL6wtnBrZJfMsqiWkUaVhIciSX323fhYtT79UQDwVxbF 3NfG2++ltXrQYWDSt4qFHDLTBVT6CpAgG/FfKaOM0iHDcfadrtV4SKfnpsdcChY7HknL nxk2/vyZKViGbInpMSJ60xjUOB6T+tDRGqheybmqQPONgwj2WfjdzuhmGDoV4aRCksve DrRTwWRrYHzY+g6Ms595ywLMs61oltWq05hby+4N48V6pW5Q+agzqVDEmJvffVTo1GfD tYUA== X-Gm-Message-State: AOJu0YxqvuCMzyQJDz9N0/oY6DMhUA6qdGkOlv5M7oFPkLaOhXi/CJ46 TuUcacJubeLkBgv/uIHmyDDEAiA7bEVT X-Google-Smtp-Source: AGHT+IFoZocBFeWiLVzcqTN3OdY9HhgdnN/awWjktzfQJqf+UN8Fi6TZfXwXPnI0VGUphL3v4zXeLA== X-Received: by 2002:a62:ae0e:0:b0:6d9:9239:2bbc with SMTP id q14-20020a62ae0e000000b006d992392bbcmr1992593pff.55.1704605659283; Sat, 06 Jan 2024 21:34:19 -0800 (PST) Received: from thinkpad ([103.197.115.97]) by smtp.gmail.com with ESMTPSA id z28-20020a62d11c000000b006daa9c80ab0sm4111219pfg.147.2024.01.06.21.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 21:34:18 -0800 (PST) Date: Sun, 7 Jan 2024 11:04:10 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v7 09/16] dt-bindings: imx6q-pcie: Clean up irrationality clocks check Message-ID: <20240107053410.GI3416@thinkpad> References: <20231227182727.1747435-1-Frank.Li@nxp.com> <20231227182727.1747435-10-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231227182727.1747435-10-Frank.Li@nxp.com> On Wed, Dec 27, 2023 at 01:27:20PM -0500, Frank Li wrote: > The bindings referencing this file already define these constraints for > each of the variants, so the if not: then: is redundant. > > Acked-by: Rob Herring > Signed-off-by: Frank Li Acked-by: Manivannan Sadhasivam - Mani > --- > > Notes: > Change from v6 to v7 > - rewrite git commit message by using simple words > Change from v5 to v6 > - rewrite git commit message and explain why remove it safely. > - Add Rob's Ack > Change from v1 to v4 > - new patch at v4 > > .../bindings/pci/fsl,imx6q-pcie-common.yaml | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > index 8f39b4e6e8491..a284a27c5e873 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > @@ -150,22 +150,6 @@ allOf: > - {} > - const: pcie_phy > - const: pcie_aux > - - if: > - properties: > - compatible: > - not: > - contains: > - enum: > - - fsl,imx6sx-pcie > - - fsl,imx8mq-pcie > - - fsl,imx6sx-pcie-ep > - - fsl,imx8mq-pcie-ep > - then: > - properties: > - clocks: > - maxItems: 3 > - clock-names: > - maxItems: 3 > > - if: > properties: > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2EA4C47073 for ; Sun, 7 Jan 2024 05:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=czCRwVkzhckNMoQQoMiOOTkhGVRr3HDEsZ6iNwGGS2E=; b=x2NoMsv/RMDBA5 5JHqoIJEIc4ZjLRG7cKwFG3cVrT4R154fzy+5OhAOePr6kOxwVX7r8rIk2brSUlNqsmTfnrUO0sZk ACk1WHy3+eMDCfXAmgzuIoB/7WEG2jLEKxvoxe71sysL1SMcUUoIQdlA/2X0buXofAqskDxkJN5Gf iOpHSd1Jys+wmwb1NilCm2BZJY9EAJbGM3wvBR860dk7TTo574DqjMUvnYi+PEAjH9UwEoJEBHskw eK4J2fLF/JwYdqA7cSq9FmYRI5veYEOstxlbY2eh8veVnM6G3Nwsm+S6JmQ/vyLEYLpqhd/xmi0yc FwYqdRT9YQV5ag6YHUEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rMLnj-002PFH-2h; Sun, 07 Jan 2024 05:34:23 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rMLng-002PED-19 for linux-arm-kernel@lists.infradead.org; Sun, 07 Jan 2024 05:34:21 +0000 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6d9f94b9186so736677b3a.0 for ; Sat, 06 Jan 2024 21:34:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704605659; x=1705210459; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=HqP4dggxSEGDvqw7GUe9RC6veZbTj2SMAyF3Y7WYNr4=; b=vrwFBK7DT9TFSw7cIhLEh833uHp1Aqbdt60Oxn3eTsn6hAZuelrDtTXv995879kJhf XEqAa905PH2mynKFEjvyTQvEukAWdO2VaPFa7LhOdpFjz5VTc0zcp2Q6J0aECdaB9VTe ku8I9LdzKjFiexJfmxlmdsfmsULp2j1E+hw65ehUajUDfGrtevi+gOcGpaAWrQPXJqwo yNjRD8T4HjOX4yFQ04/IzlODwFqJAToGSP1e9tJOEThzqmo6RiqiCN9RQLZ684CWhGok gCW2/SIg8R7tQzmqx1Sb28ArxX0U4qsI/EKCbdnSw2Apig7TOkh4Z18c6unaOW3dsI1p 84fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704605659; x=1705210459; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HqP4dggxSEGDvqw7GUe9RC6veZbTj2SMAyF3Y7WYNr4=; b=SraDuW4qFWB3WqZJY/W+f960Le308du9CK/06sr9glsbF2H1bz9PbcwE7tafB0wmo+ kGPZjjb5jKtrDfqQk0K3UgZyNyGrC04VYwLdZTGgd9KboUGn9mw703i87DAyux/dEh2c eU2bUgOFk0fpzJqaH7eM9/WyQe85Mot8AYuYyu2XXNE5TZk6/uprGaxZbOIiImGWCVGk Xtk3XH3bhFkSKC9MivqWT6bYB7mRZ5WPDT25bsZbL23qu/tFC3PEXPwGXCLtJQTSK1kS YIsaArOEMTsXjh65AFDdrv6UNCOaKDYz6uGJ2OMtNHqriXS72NsPfAXRaeXj8A6CGY18 i5Cg== X-Gm-Message-State: AOJu0YyXge1UvMUlSK1QDlsdXQTGinBEDKOmug8jDr8b9BIMTQGy41/m +kjy7ZRjMPjABOa4aAaW8YyHP55Ea7i7 X-Google-Smtp-Source: AGHT+IFoZocBFeWiLVzcqTN3OdY9HhgdnN/awWjktzfQJqf+UN8Fi6TZfXwXPnI0VGUphL3v4zXeLA== X-Received: by 2002:a62:ae0e:0:b0:6d9:9239:2bbc with SMTP id q14-20020a62ae0e000000b006d992392bbcmr1992593pff.55.1704605659283; Sat, 06 Jan 2024 21:34:19 -0800 (PST) Received: from thinkpad ([103.197.115.97]) by smtp.gmail.com with ESMTPSA id z28-20020a62d11c000000b006daa9c80ab0sm4111219pfg.147.2024.01.06.21.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 21:34:18 -0800 (PST) Date: Sun, 7 Jan 2024 11:04:10 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v7 09/16] dt-bindings: imx6q-pcie: Clean up irrationality clocks check Message-ID: <20240107053410.GI3416@thinkpad> References: <20231227182727.1747435-1-Frank.Li@nxp.com> <20231227182727.1747435-10-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231227182727.1747435-10-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240106_213420_392789_F4554BFA X-CRM114-Status: GOOD ( 15.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBEZWMgMjcsIDIwMjMgYXQgMDE6Mjc6MjBQTSAtMDUwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gVGhlIGJpbmRpbmdzIHJlZmVyZW5jaW5nIHRoaXMgZmlsZSBhbHJlYWR5IGRlZmluZSB0aGVz ZSBjb25zdHJhaW50cyBmb3IKPiBlYWNoIG9mIHRoZSB2YXJpYW50cywgc28gdGhlIGlmIG5vdDog dGhlbjogaXMgcmVkdW5kYW50Lgo+IAo+IEFja2VkLWJ5OiBSb2IgSGVycmluZyA8cm9iaEBrZXJu ZWwub3JnPgo+IFNpZ25lZC1vZmYtYnk6IEZyYW5rIExpIDxGcmFuay5MaUBueHAuY29tPgoKQWNr ZWQtYnk6IE1hbml2YW5uYW4gU2FkaGFzaXZhbSA8bWFuaXZhbm5hbi5zYWRoYXNpdmFtQGxpbmFy by5vcmc+CgotIE1hbmkKCj4gLS0tCj4gCj4gTm90ZXM6Cj4gICAgIENoYW5nZSBmcm9tIHY2IHRv IHY3Cj4gICAgIC0gcmV3cml0ZSBnaXQgY29tbWl0IG1lc3NhZ2UgYnkgdXNpbmcgc2ltcGxlIHdv cmRzCj4gICAgIENoYW5nZSBmcm9tIHY1IHRvIHY2Cj4gICAgIC0gcmV3cml0ZSBnaXQgY29tbWl0 IG1lc3NhZ2UgYW5kIGV4cGxhaW4gd2h5IHJlbW92ZSBpdCBzYWZlbHkuCj4gICAgIC0gQWRkIFJv YidzIEFjawo+ICAgICBDaGFuZ2UgZnJvbSB2MSB0byB2NAo+ICAgICAtIG5ldyBwYXRjaCBhdCB2 NAo+IAo+ICAuLi4vYmluZGluZ3MvcGNpL2ZzbCxpbXg2cS1wY2llLWNvbW1vbi55YW1sICAgICAg fCAxNiAtLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNiBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9m c2wsaW14NnEtcGNpZS1jb21tb24ueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9wY2kvZnNsLGlteDZxLXBjaWUtY29tbW9uLnlhbWwKPiBpbmRleCA4ZjM5YjRlNmU4NDkx Li5hMjg0YTI3YzVlODczIDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9wY2kvZnNsLGlteDZxLXBjaWUtY29tbW9uLnlhbWwKPiArKysgYi9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2ZzbCxpbXg2cS1wY2llLWNvbW1vbi55YW1sCj4g QEAgLTE1MCwyMiArMTUwLDYgQEAgYWxsT2Y6Cj4gICAgICAgICAgICAgIC0ge30KPiAgICAgICAg ICAgICAgLSBjb25zdDogcGNpZV9waHkKPiAgICAgICAgICAgICAgLSBjb25zdDogcGNpZV9hdXgK PiAtICAtIGlmOgo+IC0gICAgICBwcm9wZXJ0aWVzOgo+IC0gICAgICAgIGNvbXBhdGlibGU6Cj4g LSAgICAgICAgICBub3Q6Cj4gLSAgICAgICAgICAgIGNvbnRhaW5zOgo+IC0gICAgICAgICAgICAg IGVudW06Cj4gLSAgICAgICAgICAgICAgICAtIGZzbCxpbXg2c3gtcGNpZQo+IC0gICAgICAgICAg ICAgICAgLSBmc2wsaW14OG1xLXBjaWUKPiAtICAgICAgICAgICAgICAgIC0gZnNsLGlteDZzeC1w Y2llLWVwCj4gLSAgICAgICAgICAgICAgICAtIGZzbCxpbXg4bXEtcGNpZS1lcAo+IC0gICAgdGhl bjoKPiAtICAgICAgcHJvcGVydGllczoKPiAtICAgICAgICBjbG9ja3M6Cj4gLSAgICAgICAgICBt YXhJdGVtczogMwo+IC0gICAgICAgIGNsb2NrLW5hbWVzOgo+IC0gICAgICAgICAgbWF4SXRlbXM6 IDMKPiAgCj4gICAgLSBpZjoKPiAgICAgICAgcHJvcGVydGllczoKPiAtLSAKPiAyLjM0LjEKPiAK Ci0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+N CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==