From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7C8F125A8 for ; Sun, 7 Jan 2024 05:55:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LrxJJSFn" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-5c21e185df5so620989a12.1 for ; Sat, 06 Jan 2024 21:55:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704606920; x=1705211720; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=npkPTWZbSrPT/J2qTivWUqWZDlbUUJa861d4n1crd6s=; b=LrxJJSFn81GnDC5l46tsoWX5WIzvEzfFRTgZXpCChS5mjlVUp7p4x3yNkQx54gV86s Hxc+/B+JM/VSOvBm7sF3U0ok+pTWRTIqLKvJi8N+jn0DTegcuPZA2eRaFlvvAjq2sEF3 uYfV9I9EF51JqLAhATDPy0FS3WA+mIULCEKSsFcUJn5CSH4O06eKsqf4lXTmDHokeqzU HqFOmTJBIVNCOJMtgEMs5CQPbIvKbD/XkfZN9mE3txN5YGZcQACNV1XIUguZtiUy2zfx G3m7mnKoBjNaAp5HFTQFb+Pu6RhvUDqQmc9yiCHDx3RlQ0iYluv2o3UJR9dR1r7suKmF Uzuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704606920; x=1705211720; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=npkPTWZbSrPT/J2qTivWUqWZDlbUUJa861d4n1crd6s=; b=gy51E87u6kzsjsbyYoonJZ6IiQ0FUe/uQmeazBXiTTQ5sIrSqtHAoHfEvAlTePhC8o uwUeqalgHrEOF37mXioCIMEmwv9rIn0ed4ljPvz1oo6fJvHDxfjUlqRBNTKNsCT37o6n pYQufUhQ136bwb2kZ34B9XAjmDlh2gcfZjU61+FeH7jFNWGskWcfTSf8LVTk17GPre4Z GQZb/bFcbJA35jisV5wSnSpDHY59d7e2x9ART1hw2WdHL2ltniw3cT9c60FyMT2nEqfI jCoDGcDbjVd5QXrxPb1kGeWc9NPlGdKiJEFnh4q1w85gpi2ssQj0U4i2iHFf41Pnii9a JAsQ== X-Gm-Message-State: AOJu0YzrcovpzdxgAeKMshA7Rx7m05v/JrTDXuzwjOz40PXiBHBY7Z2T NOLxviD51wfRdU/3uNVg3Xo9Rz/6mXOL X-Google-Smtp-Source: AGHT+IGyYHLcrSwSasOKfyMhzH4xhR/SbgU0ri+aHf3n40oDj/JY/IkyQis8SJwfZ2Us7GRm5TN95g== X-Received: by 2002:a05:6a20:7a82:b0:199:8953:6e0c with SMTP id u2-20020a056a207a8200b0019989536e0cmr1255512pzh.52.1704606920277; Sat, 06 Jan 2024 21:55:20 -0800 (PST) Received: from thinkpad ([103.197.115.97]) by smtp.gmail.com with ESMTPSA id 9-20020a17090a018900b0028a4c85a55csm4287287pjc.27.2024.01.06.21.55.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 21:55:19 -0800 (PST) Date: Sun, 7 Jan 2024 11:25:10 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v7 13/16] PCI: imx6: Clean up get addr_space code Message-ID: <20240107055510.GM3416@thinkpad> References: <20231227182727.1747435-1-Frank.Li@nxp.com> <20231227182727.1747435-14-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231227182727.1747435-14-Frank.Li@nxp.com> On Wed, Dec 27, 2023 at 01:27:24PM -0500, Frank Li wrote: Subject: PCI: imx6: Rely on DWC core to fetch 'addr_space' region > The common dw_pcie_ep_init() already do the same thing. Needn't platform > driver do it again. > 'Since the dw_pcie_ep_init() function is already fetching the 'addr_space' region, no need to do the same in this driver.' > Signed-off-by: Frank Li With above changes, Reviewed-by: Manivannan Sadhasivam - Mani > --- > > Notes: > Change from v1 to v3 > - new patches > > drivers/pci/controller/dwc/pci-imx6.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 9e60ab6f1885a..4b2b9aafad1b4 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1080,7 +1080,6 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie, > int ret; > unsigned int pcie_dbi2_offset; > struct dw_pcie_ep *ep; > - struct resource *res; > struct dw_pcie *pci = imx6_pcie->pci; > struct dw_pcie_rp *pp = &pci->pp; > struct device *dev = pci->dev; > @@ -1099,14 +1098,8 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie, > pcie_dbi2_offset = SZ_4K; > break; > } > - pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset; > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space"); > - if (!res) > - return -EINVAL; > > - ep->phys_base = res->start; > - ep->addr_size = resource_size(res); > - ep->page_size = SZ_64K; > + pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset; > > ret = dw_pcie_ep_init(ep); > if (ret) { > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78F8FC47073 for ; Sun, 7 Jan 2024 05:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sG46hi7K/mkgUw7371VgiGGBwKFNzKpFTZ6ir84XL+M=; b=r7Styb9AFFHOcW euIWvayoBNKMoOtX6jJTcSnYVfd7V7J3louzLhCV2cpRp79Z4geBKgeeYNZ33v8thC0rr1ohEMt70 +Z5/swuBxoh0wcCZ+MZ5a3F7XTTjfpGqfrF2BtMz3mjd+TIi1nFkawhO3W1liE0yc8BjaTk9C3KID XGl4FIpEES0QVL6H6BFjX1t5yO2AKLObT9lDzVzf0U8WEkrBbnKcFbgEA8x9zgFOlY3a59UH6Kj+H AXGh6P/K8u6X3sB0l5mtrtkiTjioVgHzul5eD9XtCSbZyNa1SYn9YsL9An1k6C/J8F/4CrBfOcRfo blOhbUoEI3uIR54+XeQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rMM88-002QwU-0V; Sun, 07 Jan 2024 05:55:28 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rMM85-002QvC-1L for linux-arm-kernel@lists.infradead.org; Sun, 07 Jan 2024 05:55:26 +0000 Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-28bd623c631so771999a91.3 for ; Sat, 06 Jan 2024 21:55:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704606920; x=1705211720; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=npkPTWZbSrPT/J2qTivWUqWZDlbUUJa861d4n1crd6s=; b=ZNx5RMDNo9zTDfbcbCa7/1bYv1vCL9FSSWt/JPEWJRV5WxFeEi+HBZ5J3XWKqZR6gy F2qrzunUBWwtpbuu+gr/E+h9PBfVkJ1N0cf8fgTX1ddfczBKH1iSJTOLvr9wq7TB20/H ZjFE41EphQxFxRHBuIcLGyqWkfx6zTRJNOpUb8yCE4x+mtj+5p8UJLWMMYLx5VGUWL38 aVUghkKaQXB8kbgqPMz06CYHPoGC7lU/LdBzRWd4cRvdtLLwBwB+g1wfnuWRyFY36VDe KIsZi0l5UIhRVCvR6i5aN5JZ/WbpiJkWzccWfYS8BRyEYox3RHO/MBy9WCA2Gaid4UUw ETPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704606920; x=1705211720; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=npkPTWZbSrPT/J2qTivWUqWZDlbUUJa861d4n1crd6s=; b=grSy1im9QrIsiDez9/rf41uhOdy9wDz6Aa2J+9U8XxrBVymo8faJ9nT5qfadHcpEc2 7A3ZR5QjuQHIr0t35bpT28nQ5oOZClx1ZIISY7wHsubSUIqviYC7U5Fdj/tzXjHZNgxn rIcfyzVvoE/Fx6wddstjHf/EKZdQg2KIJi8S9YiOur5+CwZFt/SKQ6E4Aypzoiep601u +lvfoKR2ezkXAXvmuWCypy71GjfL5zAR9FXN8iS6VhrXJ93Zla8vWpXmNrcG+N7Eq5Ng hZxaeOy+o5pujAdRHayLJpqa1lJqBv39TOObaqt5WF2uCeJdd7Rr84miUrtf/IYKg7Zl Udcw== X-Gm-Message-State: AOJu0Yy6iG7je2/dpZGDLOm0jE2VfSDQOE2GIq9NPWHr3mzwK7Jc6Km8 FuR8Pvy1NWk5gpZ7IdvLBHKL1n4Qs1ap X-Google-Smtp-Source: AGHT+IGyYHLcrSwSasOKfyMhzH4xhR/SbgU0ri+aHf3n40oDj/JY/IkyQis8SJwfZ2Us7GRm5TN95g== X-Received: by 2002:a05:6a20:7a82:b0:199:8953:6e0c with SMTP id u2-20020a056a207a8200b0019989536e0cmr1255512pzh.52.1704606920277; Sat, 06 Jan 2024 21:55:20 -0800 (PST) Received: from thinkpad ([103.197.115.97]) by smtp.gmail.com with ESMTPSA id 9-20020a17090a018900b0028a4c85a55csm4287287pjc.27.2024.01.06.21.55.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 21:55:19 -0800 (PST) Date: Sun, 7 Jan 2024 11:25:10 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v7 13/16] PCI: imx6: Clean up get addr_space code Message-ID: <20240107055510.GM3416@thinkpad> References: <20231227182727.1747435-1-Frank.Li@nxp.com> <20231227182727.1747435-14-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231227182727.1747435-14-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240106_215525_461839_3CAB0311 X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBEZWMgMjcsIDIwMjMgYXQgMDE6Mjc6MjRQTSAtMDUwMCwgRnJhbmsgTGkgd3JvdGU6 CgpTdWJqZWN0OiBQQ0k6IGlteDY6IFJlbHkgb24gRFdDIGNvcmUgdG8gZmV0Y2ggJ2FkZHJfc3Bh Y2UnIHJlZ2lvbiAKCj4gVGhlIGNvbW1vbiBkd19wY2llX2VwX2luaXQoKSBhbHJlYWR5IGRvIHRo ZSBzYW1lIHRoaW5nLiBOZWVkbid0IHBsYXRmb3JtCj4gZHJpdmVyIGRvIGl0IGFnYWluLgo+IAoK J1NpbmNlIHRoZSBkd19wY2llX2VwX2luaXQoKSBmdW5jdGlvbiBpcyBhbHJlYWR5IGZldGNoaW5n IHRoZSAnYWRkcl9zcGFjZScKcmVnaW9uLCBubyBuZWVkIHRvIGRvIHRoZSBzYW1lIGluIHRoaXMg ZHJpdmVyLicKCj4gU2lnbmVkLW9mZi1ieTogRnJhbmsgTGkgPEZyYW5rLkxpQG54cC5jb20+CgpX aXRoIGFib3ZlIGNoYW5nZXMsCgpSZXZpZXdlZC1ieTogTWFuaXZhbm5hbiBTYWRoYXNpdmFtIDxt YW5pdmFubmFuLnNhZGhhc2l2YW1AbGluYXJvLm9yZz4KCi0gTWFuaQoKPiAtLS0KPiAKPiBOb3Rl czoKPiAgICAgQ2hhbmdlIGZyb20gdjEgdG8gdjMKPiAgICAgLSBuZXcgcGF0Y2hlcwo+IAo+ICBk cml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jIHwgOSArLS0tLS0tLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCA4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jIGIvZHJpdmVycy9wY2kv Y29udHJvbGxlci9kd2MvcGNpLWlteDYuYwo+IGluZGV4IDllNjBhYjZmMTg4NWEuLjRiMmI5YWFm YWQxYjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWlteDYu Ywo+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMKPiBAQCAtMTA4 MCw3ICsxMDgwLDYgQEAgc3RhdGljIGludCBpbXg2X2FkZF9wY2llX2VwKHN0cnVjdCBpbXg2X3Bj aWUgKmlteDZfcGNpZSwKPiAgCWludCByZXQ7Cj4gIAl1bnNpZ25lZCBpbnQgcGNpZV9kYmkyX29m ZnNldDsKPiAgCXN0cnVjdCBkd19wY2llX2VwICplcDsKPiAtCXN0cnVjdCByZXNvdXJjZSAqcmVz Owo+ICAJc3RydWN0IGR3X3BjaWUgKnBjaSA9IGlteDZfcGNpZS0+cGNpOwo+ICAJc3RydWN0IGR3 X3BjaWVfcnAgKnBwID0gJnBjaS0+cHA7Cj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSBwY2ktPmRl djsKPiBAQCAtMTA5OSwxNCArMTA5OCw4IEBAIHN0YXRpYyBpbnQgaW14Nl9hZGRfcGNpZV9lcChz dHJ1Y3QgaW14Nl9wY2llICppbXg2X3BjaWUsCj4gIAkJcGNpZV9kYmkyX29mZnNldCA9IFNaXzRL Owo+ICAJCWJyZWFrOwo+ICAJfQo+IC0JcGNpLT5kYmlfYmFzZTIgPSBwY2ktPmRiaV9iYXNlICsg cGNpZV9kYmkyX29mZnNldDsKPiAtCXJlcyA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZV9ieW5hbWUo cGRldiwgSU9SRVNPVVJDRV9NRU0sICJhZGRyX3NwYWNlIik7Cj4gLQlpZiAoIXJlcykKPiAtCQly ZXR1cm4gLUVJTlZBTDsKPiAgCj4gLQllcC0+cGh5c19iYXNlID0gcmVzLT5zdGFydDsKPiAtCWVw LT5hZGRyX3NpemUgPSByZXNvdXJjZV9zaXplKHJlcyk7Cj4gLQllcC0+cGFnZV9zaXplID0gU1pf NjRLOwo+ICsJcGNpLT5kYmlfYmFzZTIgPSBwY2ktPmRiaV9iYXNlICsgcGNpZV9kYmkyX29mZnNl dDsKPiAgCj4gIAlyZXQgPSBkd19wY2llX2VwX2luaXQoZXApOwo+ICAJaWYgKHJldCkgewo+IC0t IAo+IDIuMzQuMQo+IAoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCvjSDgrprgrqTgrr7g rprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK