Re: [PATCH net-next] net: dsa: mt7530: support OF-based registration of switch MDIO bus

From: Simon Horman <horms@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "Arınç ÜNAL" <arinc.unal@arinc9.com>,
	"Daniel Golle" <daniel@makrotopia.org>,
	"Landen Chao" <Landen.Chao@mediatek.com>,
	"DENG Qingfang" <dqfext@gmail.com>,
	"Sean Wang" <sean.wang@mediatek.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"David Bauer" <mail@david-bauer.net>,
	mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
	"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next] net: dsa: mt7530: support OF-based registration of switch MDIO bus
Date: Mon, 8 Jan 2024 11:15:03 +0000	[thread overview]
Message-ID: <20240108111503.GI132648@kernel.org> (raw)
In-Reply-To: <20240108110000.aujqhlufehngtkjj@skbuf>

On Mon, Jan 08, 2024 at 01:00:00PM +0200, Vladimir Oltean wrote:
> On Mon, Jan 08, 2024 at 01:22:18PM +0300, Arınç ÜNAL wrote:
> > > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> > > > index 391c4dbdff42..39d7e7ad7154 100644
> > > > --- a/drivers/net/dsa/mt7530.c
> > > > +++ b/drivers/net/dsa/mt7530.c
> > > > @@ -2153,17 +2153,25 @@ mt7530_free_irq(struct mt7530_priv *priv)
> > > >   static int
> > > >   mt7530_setup_mdio(struct mt7530_priv *priv)
> > > >   {
> > > > +	struct device_node *mnp, *np = priv->dev->of_node;
> > > >   	struct dsa_switch *ds = priv->ds;
> > > >   	struct device *dev = priv->dev;
> > > >   	struct mii_bus *bus;
> > > >   	static int idx;
> > > > -	int ret;
> > > > +	int ret = 0;
> > > > +
> > > > +	mnp = of_get_child_by_name(np, "mdio");
> > > > +
> > > > +	if (mnp && !of_device_is_available(mnp))
> > > > +		goto out;
> > > 
> > > nit: I think it would easier on the eyes to simply
> > > 
> > > 		return 0;
> 
> Actually "return 0" leaks "mnp". An of_node_put() is needed.

Yes, sorry for not noticing that.