From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hanna Reitz" <hreitz@redhat.com>,
qemu-riscv@nongnu.org, "Roman Bolshakov" <rbolshakov@ddn.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Thomas Huth" <thuth@redhat.com>,
qemu-block@nongnu.org,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Fam Zheng" <fam@euphon.net>, "Gerd Hoffmann" <kraxel@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"John Snow" <jsnow@redhat.com>,
"Stafford Horne" <shorne@gmail.com>,
"Weiwei Li" <liwei1518@gmail.com>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
"Cameron Esfahani" <dirty@apple.com>,
"Alexander Graf" <agraf@csgraf.de>,
"David Hildenbrand" <david@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-s390x@nongnu.org, "Jiri Slaby" <jslaby@suse.cz>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Eric Blake" <eblake@redhat.com>,
"Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Fabiano Rosas" <farosas@suse.de>,
"Michael Roth" <michael.roth@amd.com>,
"Paul Durrant" <paul@xen.org>,
"Jagannathan Raman" <jag.raman@oracle.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Hyman Huang" <yong.huang@smartx.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
xen-devel@lists.xenproject.org,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Song Gao" <gaosong@loongson.cn>, "Kevin Wolf" <kwolf@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Reinoud Zandijk" <reinoud@netbsd.org>,
qemu-ppc@nongnu.org, "Marcelo Tosatti" <mtosatti@redhat.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Bin Meng" <bin.meng@windriver.com>,
qemu-arm@nongnu.org, "Anthony Perard" <anthony.perard@citrix.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Hailiang Zhang" <zhanghailiang@xfusion.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
kvm@vger.kernel.org, "Palmer Dabbelt" <palmer@dabbelt.com>,
"Eric Farman" <farman@linux.ibm.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>
Subject: Re: [PATCH v3 0/5] Make Big QEMU Lock naming consistent
Date: Mon, 8 Jan 2024 11:36:19 -0500 [thread overview]
Message-ID: <20240108163619.GA216787@fedora> (raw)
In-Reply-To: <20240102153529.486531-1-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 7497 bytes --]
On Tue, Jan 02, 2024 at 10:35:24AM -0500, Stefan Hajnoczi wrote:
> v3:
> - Rebase
> - Define bql_lock() macro on a single line [Akihiko Odaki]
> v2:
> - Rename APIs bql_*() [PeterX]
> - Spell out "Big QEMU Lock (BQL)" in doc comments [PeterX]
> - Rename "iolock" variables in hw/remote/mpqemu-link.c [Harsh]
> - Fix bql_auto_lock() indentation in Patch 2 [Ilya]
> - "with BQL taken" -> "with the BQL taken" [Philippe]
> - "under BQL" -> "under the BQL" [Philippe]
>
> The Big QEMU Lock ("BQL") has two other names: "iothread lock" and "QEMU global
> mutex". The term "iothread lock" is easily confused with the unrelated --object
> iothread (iothread.c).
>
> This series updates the code and documentation to consistently use "BQL". This
> makes the code easier to understand.
>
> Stefan Hajnoczi (5):
> system/cpus: rename qemu_mutex_lock_iothread() to bql_lock()
> qemu/main-loop: rename QEMU_IOTHREAD_LOCK_GUARD to BQL_LOCK_GUARD
> qemu/main-loop: rename qemu_cond_wait_iothread() to
> qemu_cond_wait_bql()
> Replace "iothread lock" with "BQL" in comments
> Rename "QEMU global mutex" to "BQL" in comments and docs
>
> docs/devel/multi-thread-tcg.rst | 7 +-
> docs/devel/qapi-code-gen.rst | 2 +-
> docs/devel/replay.rst | 2 +-
> docs/devel/reset.rst | 2 +-
> docs/devel/multiple-iothreads.txt | 14 ++--
> hw/display/qxl.h | 2 +-
> include/block/aio-wait.h | 2 +-
> include/block/blockjob.h | 6 +-
> include/exec/cpu-common.h | 2 +-
> include/exec/memory.h | 4 +-
> include/exec/ramblock.h | 2 +-
> include/io/task.h | 2 +-
> include/migration/register.h | 8 +-
> include/qemu/coroutine-core.h | 2 +-
> include/qemu/coroutine.h | 2 +-
> include/qemu/main-loop.h | 68 ++++++++-------
> include/qemu/thread.h | 2 +-
> target/arm/internals.h | 4 +-
> accel/accel-blocker.c | 10 +--
> accel/dummy-cpus.c | 8 +-
> accel/hvf/hvf-accel-ops.c | 4 +-
> accel/kvm/kvm-accel-ops.c | 4 +-
> accel/kvm/kvm-all.c | 22 ++---
> accel/tcg/cpu-exec.c | 26 +++---
> accel/tcg/cputlb.c | 20 ++---
> accel/tcg/tcg-accel-ops-icount.c | 6 +-
> accel/tcg/tcg-accel-ops-mttcg.c | 12 +--
> accel/tcg/tcg-accel-ops-rr.c | 18 ++--
> accel/tcg/tcg-accel-ops.c | 2 +-
> accel/tcg/translate-all.c | 2 +-
> cpu-common.c | 4 +-
> dump/dump.c | 4 +-
> hw/block/dataplane/virtio-blk.c | 8 +-
> hw/block/virtio-blk.c | 2 +-
> hw/core/cpu-common.c | 6 +-
> hw/display/virtio-gpu.c | 2 +-
> hw/i386/intel_iommu.c | 6 +-
> hw/i386/kvm/xen_evtchn.c | 30 +++----
> hw/i386/kvm/xen_gnttab.c | 2 +-
> hw/i386/kvm/xen_overlay.c | 2 +-
> hw/i386/kvm/xen_xenstore.c | 2 +-
> hw/intc/arm_gicv3_cpuif.c | 2 +-
> hw/intc/s390_flic.c | 18 ++--
> hw/mips/mips_int.c | 2 +-
> hw/misc/edu.c | 4 +-
> hw/misc/imx6_src.c | 2 +-
> hw/misc/imx7_src.c | 2 +-
> hw/net/xen_nic.c | 8 +-
> hw/ppc/pegasos2.c | 2 +-
> hw/ppc/ppc.c | 6 +-
> hw/ppc/spapr.c | 2 +-
> hw/ppc/spapr_events.c | 2 +-
> hw/ppc/spapr_rng.c | 4 +-
> hw/ppc/spapr_softmmu.c | 4 +-
> hw/remote/mpqemu-link.c | 22 ++---
> hw/remote/vfio-user-obj.c | 2 +-
> hw/s390x/s390-skeys.c | 2 +-
> hw/scsi/virtio-scsi-dataplane.c | 6 +-
> migration/block-dirty-bitmap.c | 14 ++--
> migration/block.c | 38 ++++-----
> migration/colo.c | 62 +++++++-------
> migration/dirtyrate.c | 12 +--
> migration/migration.c | 54 ++++++------
> migration/ram.c | 16 ++--
> net/tap.c | 2 +-
> replay/replay-internal.c | 2 +-
> semihosting/console.c | 8 +-
> stubs/iothread-lock.c | 6 +-
> system/cpu-throttle.c | 6 +-
> system/cpus.c | 55 +++++++------
> system/dirtylimit.c | 4 +-
> system/memory.c | 2 +-
> system/physmem.c | 14 ++--
> system/runstate.c | 2 +-
> system/watchpoint.c | 4 +-
> target/arm/arm-powerctl.c | 14 ++--
> target/arm/helper.c | 6 +-
> target/arm/hvf/hvf.c | 8 +-
> target/arm/kvm.c | 8 +-
> target/arm/ptw.c | 6 +-
> target/arm/tcg/helper-a64.c | 8 +-
> target/arm/tcg/m_helper.c | 6 +-
> target/arm/tcg/op_helper.c | 24 +++---
> target/arm/tcg/psci.c | 2 +-
> target/hppa/int_helper.c | 8 +-
> target/i386/hvf/hvf.c | 6 +-
> target/i386/kvm/hyperv.c | 4 +-
> target/i386/kvm/kvm.c | 28 +++----
> target/i386/kvm/xen-emu.c | 16 ++--
> target/i386/nvmm/nvmm-accel-ops.c | 6 +-
> target/i386/nvmm/nvmm-all.c | 20 ++---
> target/i386/tcg/sysemu/fpu_helper.c | 6 +-
> target/i386/tcg/sysemu/misc_helper.c | 4 +-
> target/i386/whpx/whpx-accel-ops.c | 6 +-
> target/i386/whpx/whpx-all.c | 24 +++---
> target/loongarch/csr_helper.c | 4 +-
> target/mips/kvm.c | 4 +-
> target/mips/tcg/sysemu/cp0_helper.c | 4 +-
> target/openrisc/sys_helper.c | 16 ++--
> target/ppc/excp_helper.c | 14 ++--
> target/ppc/helper_regs.c | 2 +-
> target/ppc/kvm.c | 4 +-
> target/ppc/misc_helper.c | 8 +-
> target/ppc/timebase_helper.c | 8 +-
> target/riscv/cpu_helper.c | 4 +-
> target/s390x/kvm/kvm.c | 4 +-
> target/s390x/tcg/misc_helper.c | 118 +++++++++++++--------------
> target/sparc/int32_helper.c | 2 +-
> target/sparc/int64_helper.c | 6 +-
> target/sparc/win_helper.c | 20 ++---
> target/xtensa/exc_helper.c | 8 +-
> ui/spice-core.c | 6 +-
> util/async.c | 2 +-
> util/main-loop.c | 8 +-
> util/qsp.c | 6 +-
> util/rcu.c | 16 ++--
> audio/coreaudio.m | 8 +-
> memory_ldst.c.inc | 18 ++--
> target/i386/hvf/README.md | 2 +-
> ui/cocoa.m | 56 ++++++-------
> 120 files changed, 641 insertions(+), 643 deletions(-)
>
> --
> 2.43.0
>
Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-01-08 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 15:35 [PATCH v3 0/5] Make Big QEMU Lock naming consistent Stefan Hajnoczi
2024-01-02 15:35 ` [PATCH v3 1/5] system/cpus: rename qemu_mutex_lock_iothread() to bql_lock() Stefan Hajnoczi
2024-01-02 15:35 ` [PATCH v3 2/5] qemu/main-loop: rename QEMU_IOTHREAD_LOCK_GUARD to BQL_LOCK_GUARD Stefan Hajnoczi
2024-01-02 15:35 ` [PATCH v3 3/5] qemu/main-loop: rename qemu_cond_wait_iothread() to qemu_cond_wait_bql() Stefan Hajnoczi
2024-01-02 15:35 ` [PATCH v3 4/5] Replace "iothread lock" with "BQL" in comments Stefan Hajnoczi
2024-01-02 16:02 ` Cédric Le Goater
2024-01-02 15:35 ` [PATCH v3 5/5] Rename "QEMU global mutex" to "BQL" in comments and docs Stefan Hajnoczi
2024-01-02 16:05 ` Cédric Le Goater
2024-01-04 12:10 ` [PATCH v3 0/5] Make Big QEMU Lock naming consistent Akihiko Odaki
2024-01-08 16:36 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240108163619.GA216787@fedora \
--to=stefanha@redhat.com \
--cc=agraf@csgraf.de \
--cc=akihiko.odaki@daynix.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=andrew.smirnov@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=balaton@eik.bme.hu \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=dirty@apple.com \
--cc=dwmw2@infradead.org \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=elena.ufimtseva@oracle.com \
--cc=fam@euphon.net \
--cc=farman@linux.ibm.com \
--cc=farosas@suse.de \
--cc=gaosong@loongson.cn \
--cc=harshpb@linux.ibm.com \
--cc=hreitz@redhat.com \
--cc=iii@linux.ibm.com \
--cc=jag.raman@oracle.com \
--cc=jasowang@redhat.com \
--cc=jcd@tribudubois.net \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=jslaby@suse.cz \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=leobras@redhat.com \
--cc=liwei1518@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pasic@linux.ibm.com \
--cc=paul@xen.org \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quintela@redhat.com \
--cc=rbolshakov@ddn.com \
--cc=reinoud@netbsd.org \
--cc=richard.henderson@linaro.org \
--cc=shorne@gmail.com \
--cc=sstabellini@kernel.org \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=xen-devel@lists.xenproject.org \
--cc=yong.huang@smartx.com \
--cc=zhanghailiang@xfusion.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.