From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Moti Haimovski <mhaimovski@habana.ai>,
Matt Roper <matthew.d.roper@intel.com>
Subject: [PATCH 3/4] drm/xe: Annotate multiple mmio pointers with __iomem
Date: Tue, 9 Jan 2024 12:24:04 +0100 [thread overview]
Message-ID: <20240109112405.108136-4-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20240109112405.108136-1-thomas.hellstrom@linux.intel.com>
There are a couple of pointers pointing to MMIO space. Annotate them
with __iomem and fix the corresponding sparse warnings.
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Fixes: 3b0d4a557996 ("drm/xe: Move register MMIO into xe_tile")
Fixes: 399a13323f0d ("drm/xe: add 28-bit address support in struct xe_reg")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Koby Elbaz <kelbaz@habana.ai>
Cc: Ofir Bitton <obitton@habana.ai>
Cc: Moti Haimovski <mhaimovski@habana.ai>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/xe/xe_device_types.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index 171e8615d184..e0da2e3ca426 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -147,7 +147,7 @@ struct xe_tile {
size_t size;
/** @regs: pointer to tile's MMIO space (starting with registers) */
- void *regs;
+ void __iomem *regs;
} mmio;
/**
@@ -160,7 +160,7 @@ struct xe_tile {
size_t size;
/** @regs: pointer to tile's additional MMIO-extension space */
- void *regs;
+ void __iomem *regs;
} mmio_ext;
/** @mem: memory management info for tile */
@@ -306,7 +306,7 @@ struct xe_device {
/** @size: size of MMIO space for device */
size_t size;
/** @regs: pointer to MMIO space for device */
- void *regs;
+ void __iomem *regs;
} mmio;
/** @mem: memory info for device */
--
2.43.0
next prev parent reply other threads:[~2024-01-09 11:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 11:24 [PATCH 0/4] drm/xe: Silence a number of sparse warnings Thomas Hellström
2024-01-09 11:24 ` [PATCH 1/4] drm/xe: Use __iomem for the regs pointer Thomas Hellström
2024-01-09 14:48 ` Lucas De Marchi
2024-01-09 11:24 ` [PATCH 2/4] drm/xe: Annotate xe_mem_region::mapping with __iomem Thomas Hellström
2024-01-09 14:52 ` Lucas De Marchi
2024-01-09 11:24 ` Thomas Hellström [this message]
2024-01-09 14:53 ` [PATCH 3/4] drm/xe: Annotate multiple mmio pointers " Lucas De Marchi
2024-01-09 15:27 ` Matt Roper
2024-01-09 11:24 ` [PATCH 4/4] drm/xe: Annotate xe_ttm_stolen_mgr::mapping " Thomas Hellström
2024-01-09 14:55 ` Lucas De Marchi
2024-01-09 13:01 ` ✓ CI.Patch_applied: success for drm/xe: Silence a number of sparse warnings Patchwork
2024-01-09 13:01 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-09 13:02 ` ✓ CI.KUnit: success " Patchwork
2024-01-09 13:10 ` ✓ CI.Build: " Patchwork
2024-01-09 13:10 ` ✓ CI.Hooks: " Patchwork
2024-01-09 13:11 ` ✓ CI.checksparse: " Patchwork
2024-01-09 13:46 ` ✓ CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240109112405.108136-4-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=mhaimovski@habana.ai \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.