All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Lewis Donzis <lew@perftech.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	dev <dev@dpdk.org>, "Wang, Yong" <yongwang@vmware.com>
Subject: Re: vmxnet3 no longer functional on DPDK 21.11
Date: Tue, 9 Jan 2024 15:55:27 -0800	[thread overview]
Message-ID: <20240109155527.7eed113e@hermes.local> (raw)
In-Reply-To: <ZZ0eENQ96wcFsnN6@bricha3-MOBL.ger.corp.intel.com>

On Tue, 9 Jan 2024 10:21:04 +0000
Bruce Richardson <bruce.richardson@intel.com> wrote:

> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index e49191718a..d088b42d35 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -1129,6 +1129,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
>         /* Setting proper Rx Mode and issue Rx Mode Update command */
>         vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
>  
> +#ifndef RTE_EXEC_ENV_FREEBSD
>         /* Setup interrupt callback  */
>         rte_intr_callback_register(dev->intr_handle,
>                                    vmxnet3_interrupt_handler, dev);
> @@ -1140,6 +1141,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
>  
>         /* enable all intrs */
>         vmxnet3_enable_all_intrs(hw);
> +#endif
>  
>         vmxnet3_process_events(dev);
>  

Probably need to go further with this.
 - what about unreigster in vmxnet3_dev_stop
 - vmxnet3_interrupt_handler is then dead code, should it be #ifdef guarded?
 - and vmxnet3_dev_rx_queue_intr_enable/disable
 - and vmxnet3_enable_intr
 - and vmxnet3_configure_msix
 - and checks for rte_eth_intr_conf bits? in configure


  parent reply	other threads:[~2024-01-09 23:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 20:45 vmxnet3 no longer functional on DPDK 21.11 Lewis Donzis
2021-11-30  8:53 ` Ferruh Yigit
2021-11-30 13:42 ` Bruce Richardson
2021-12-06  1:52   ` Lewis Donzis
2021-12-06  9:16     ` Bruce Richardson
2021-12-06 12:08       ` Ananyev, Konstantin
2021-12-06 13:58         ` Lewis Donzis
2022-06-03 13:19         ` Lewis Donzis
2022-06-03 15:25           ` Ferruh Yigit
2024-01-06 14:50           ` Lewis Donzis
2024-01-09 10:21             ` Bruce Richardson
2024-01-09 13:46               ` Lewis Donzis
2024-01-09 14:28                 ` Bruce Richardson
2024-01-09 15:21                   ` Lewis Donzis
2024-01-09 15:35                     ` Bruce Richardson
2024-01-09 23:55               ` Stephen Hemminger [this message]
2024-01-10 13:36                 ` Lewis Donzis
2024-01-09 14:23             ` [PATCH] net/vmxnet3: fix use of interrupts on FreeBSD Bruce Richardson
2024-01-09 16:00               ` Lewis Donzis
2024-01-11 12:03                 ` Ferruh Yigit
2024-01-24 12:34                   ` Lewis Donzis
2024-01-24 13:58                     ` Ferruh Yigit
2024-01-24 14:04                       ` Lewis Donzis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240109155527.7eed113e@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=lew@perftech.com \
    --cc=yongwang@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.