From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: Jiri Pirko <jiri@resnulli.us>,
Sabrina Dubroca <sd@queasysnail.net>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v5 2/5] netdevsim: allow two netdevsim ports to be connected
Date: Tue, 9 Jan 2024 17:53:48 -0800 [thread overview]
Message-ID: <20240109175348.34208e1e@kernel.org> (raw)
In-Reply-To: <725ad89a-038a-45bb-b710-24c2798f0dba@davidwei.uk>
On Tue, 9 Jan 2024 08:57:59 -0800 David Wei wrote:
> >> + ret = sscanf(buf, "%u %u", &id, &port);
> >> + if (ret != 2) {
> >> + pr_err("Format is peer netdevsim \"id port\" (uint uint)\n");
> >
> > netif_err() or dev_err() ? Granted the rest of the file seems to use
> > pr_err(), but I'm not sure why...
>
> I can change it to use one of these two in this patchset, then I can
> chnage the others separately in another patch. How does that sound?
Separate patch and separate series. Let's not load more unrelated
patches into this series :)
next prev parent reply other threads:[~2024-01-10 1:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 1:46 [PATCH net-next v5 0/5] netdevsim: link and forward skbs between ports David Wei
2023-12-28 1:46 ` [PATCH net-next v5 1/5] netdevsim: maintain a list of probed netdevsims David Wei
2024-01-02 11:04 ` Jiri Pirko
2024-01-03 21:48 ` David Wei
2023-12-28 1:46 ` [PATCH net-next v5 2/5] netdevsim: allow two netdevsim ports to be connected David Wei
2024-01-02 11:11 ` Jiri Pirko
2024-01-03 21:56 ` David Wei
2024-01-04 9:30 ` Jiri Pirko
2024-01-04 1:39 ` Jakub Kicinski
2024-01-09 16:57 ` David Wei
2024-01-10 1:53 ` Jakub Kicinski [this message]
2023-12-28 1:46 ` [PATCH net-next v5 3/5] netdevsim: forward skbs from one connected port to another David Wei
2024-01-02 11:13 ` Jiri Pirko
2024-01-03 22:36 ` David Wei
2024-01-04 9:31 ` Jiri Pirko
2024-01-09 16:58 ` David Wei
2024-01-02 11:20 ` Eric Dumazet
2024-01-03 21:57 ` David Wei
2023-12-28 1:46 ` [PATCH net-next v5 4/5] netdevsim: add selftest for forwarding skb between connected ports David Wei
2023-12-28 1:46 ` [PATCH net-next v5 5/5] netdevsim: add Makefile for selftests David Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240109175348.34208e1e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.