All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>,
	"Margolin, Michael" <mrgolin@amazon.com>
Cc: linux-rdma@vger.kernel.org, sleybo@amazon.com, matua@amazon.com,
	gal.pressman@linux.dev, Anas Mousa <anasmous@amazon.com>,
	Firas Jahjah <firasj@amazon.com>
Subject: Re: [PATCH for-next v4] RDMA/efa: Add EFA query MR support
Date: Tue, 9 Jan 2024 20:05:23 +0200	[thread overview]
Message-ID: <20240109180523.GA7488@unreal> (raw)
In-Reply-To: <86765443-4292-44b4-824e-d2ea5ebebc18@app.fastmail.com>

On Mon, Jan 08, 2024 at 09:40:32PM +0200, Leon Romanovsky wrote:
> 
> 
> On Mon, Jan 8, 2024, at 20:06, Jason Gunthorpe wrote:
> > On Mon, Jan 08, 2024 at 08:01:40PM +0200, Leon Romanovsky wrote:
> >> > I was saying in the rdma-core PR that this field shouldn't even
> >> > exist..
> >> 
> >> Something like that?
> >
> > Yeah, like that. However it is difficult to get the out valid uattr
> > back in the rdma-core side.
> >
> > This is best if the ID's can have well defined not-valid values such
> > as 0 or -1.
> 
> Michael tried something like that in previous versions by defining 0xffff as not valid.
> 
> I didn't like it because there's no promise from PCI core that it is invalid value.

Michael,
What do you think?

Thanks

> 
> 
> 
> >
> > Jason
> 

  reply	other threads:[~2024-01-09 18:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04  9:51 [PATCH for-next v4] RDMA/efa: Add EFA query MR support Michael Margolin
2024-01-07 10:02 ` Leon Romanovsky
2024-01-08 12:25   ` Margolin, Michael
2024-01-08 13:05   ` Jason Gunthorpe
2024-01-08 18:01     ` Leon Romanovsky
2024-01-08 18:06       ` Jason Gunthorpe
2024-01-08 19:40         ` Leon Romanovsky
2024-01-09 18:05           ` Leon Romanovsky [this message]
2024-01-10 10:00             ` Margolin, Michael
2024-01-07 10:03 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240109180523.GA7488@unreal \
    --to=leon@kernel.org \
    --cc=anasmous@amazon.com \
    --cc=firasj@amazon.com \
    --cc=gal.pressman@linux.dev \
    --cc=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matua@amazon.com \
    --cc=mrgolin@amazon.com \
    --cc=sleybo@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.