From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CD1C47F7B for ; Wed, 10 Jan 2024 12:13:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="Hjz2K9n+" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2cca8eb0509so46364791fa.3 for ; Wed, 10 Jan 2024 04:13:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; s=google; t=1704888799; x=1705493599; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=sul2vRO9Fzn0UMSUus+BZBPqeYHWDQxaw3bzygHSyZc=; b=Hjz2K9n+E4TEUFPx1YmvKuBiMGZ+YbKgLC8Qp0bogk4tkBLizvHa8CDvKdWSIFTULh S8e6zunhLQ7+6u6ILuOWQxjpWC3B1kg5jHea783ALsmdv0q8L9ExMJAykMz2pE8t9hj/ H+45hF2MsKfC9lW+4Jl+jC1PHH+8SNQTnc3ta9IUoQFri3R4cPk1Wie2NrtumArwbgRl siHkWoPu07Zt8ksX4g0l3MPaCmtGKRdISbdyjuCaZfqyxRQm5Zdfx8jQsxoGRM0D05BW OqRdlm8R4tRF1wRboXrpHDozc4BpM0IK2cLG1lAOq6YY3gCFaUsX9OdwQfr2nYPxQ0Ax S1Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704888799; x=1705493599; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sul2vRO9Fzn0UMSUus+BZBPqeYHWDQxaw3bzygHSyZc=; b=FxRXtpwQ8XXnK/Tev+chdzBuILxBX+HJtIFSUorymO4d5UTg2slf6s9NrF8q7sNMYE n9n0o+q7i+RKSaDGsfWz68crksqAV+XObV0zAANWzdIIMhL9fVEZttUSCeohU51AF28/ aQhi1s+FUFRG2hei1io2v6IV2EWdFTSENIHyuReZYNYyf0h6BupMtEcub8N8Vm8NkbsW 1LpYGq7ZRa8oy0gt2w7mhzTnurNbkyj8G8euplLLZqbAx79lQ6pu6EJ8rPHGPZOl4K1F E2uQGYlPDIeRFI4QIUu9O0QyvyGslhHZtAhe2r91kMYCUnhzIFsuo2V2x5DCCQL9Anzv L8Ug== X-Gm-Message-State: AOJu0YyZpLEKx32f6CNcoOiXIj1knXtSmsn48d3r7VtIQ3AOcx8LANPb l/QMJdcgTcIsPmEkbadjoKEe4f6mLRkgwQ== X-Google-Smtp-Source: AGHT+IF1BKGjGmz8LspFign6ek2eCcSN5Ct8qEn/F4AJ37X/svKfK3A0NBeEYN5c5XQWGzNUoY3rlA== X-Received: by 2002:a05:6512:3991:b0:50e:b1b7:9301 with SMTP id j17-20020a056512399100b0050eb1b79301mr396237lfu.81.1704888799672; Wed, 10 Jan 2024 04:13:19 -0800 (PST) Received: from localhost (h-46-59-36-113.A463.priv.bahnhof.se. [46.59.36.113]) by smtp.gmail.com with ESMTPSA id d8-20020a193848000000b0050e7d58e58csm659305lfj.174.2024.01.10.04.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 04:13:19 -0800 (PST) Date: Wed, 10 Jan 2024 13:13:18 +0100 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Geert Uytterhoeven Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Magnus Damm , Catalin Marinas , Will Deacon , Ulf Hansson , Cong Dang , Duy Nguyen , Hai Pham , Linh Phung , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 07/15] clk: renesas: rcar-gen4: Add support for FRQCRC1 Message-ID: <20240110121318.GG1625657@ragnatech.se> References: Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Geert, Thanks for your work. On 2024-01-08 16:33:46 +0100, Geert Uytterhoeven wrote: > R-Car V4H and V4M have a second Frequency Control Register C. > Add support for this by treating bit field offsets beyond 31 as > referring to the second register. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund > --- > Tested by enabling CLOCK_ALLOW_WRITE_DEBUGFS and checking the impact of > CPU core clk rate on CPU core speed on R-Car V4M. > --- > drivers/clk/renesas/rcar-gen4-cpg.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/renesas/rcar-gen4-cpg.c b/drivers/clk/renesas/rcar-gen4-cpg.c > index c68d8b987054131b..a2bbdad021ed8e95 100644 > --- a/drivers/clk/renesas/rcar-gen4-cpg.c > +++ b/drivers/clk/renesas/rcar-gen4-cpg.c > @@ -179,7 +179,8 @@ static struct clk * __init cpg_pll_clk_register(const char *name, > */ > #define CPG_FRQCRB 0x00000804 > #define CPG_FRQCRB_KICK BIT(31) > -#define CPG_FRQCRC 0x00000808 > +#define CPG_FRQCRC0 0x00000808 > +#define CPG_FRQCRC1 0x000008e0 > > struct cpg_z_clk { > struct clk_hw hw; > @@ -304,7 +305,12 @@ static struct clk * __init cpg_z_clk_register(const char *name, > init.parent_names = &parent_name; > init.num_parents = 1; > > - zclk->reg = reg + CPG_FRQCRC; > + if (offset < 32) { > + zclk->reg = reg + CPG_FRQCRC0; > + } else { > + zclk->reg = reg + CPG_FRQCRC1; > + offset -= 32; > + } > zclk->kick_reg = reg + CPG_FRQCRB; > zclk->hw.init = &init; > zclk->mask = GENMASK(offset + 4, offset); > -- > 2.34.1 > > -- Kind Regards, Niklas Söderlund From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68A7CC4707B for ; Wed, 10 Jan 2024 12:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fyTtf3sOtfkqlepqr6zJNqE+vlZcqLCZpb4A0M83Yfs=; b=DBmpC0PI42sozN pb7YtoUT0KNg/YIcaGsX0pMRr4ka66bGGA3fHCs3TI5Tguy0n4qVbNlngHLhknllU9DOwd3oH/a+r M+8edRkfMkxJ5DHAZzp8Ru7ewRfX0j+NoyqFN/lslElLxjYENvNfjbwg3DyflWdbO1NRb5htXCsyb A+PCVa12hlG2ESWyidAhsqE0KDFyeeZyMOTkYkIRi8H8NNjcPF9e8Sl0YF5z93Xg6TUZA4jzTsLcV osPlZevjqtA11eIVoH1FHad8fbL83CNj8LNYa/ZNKO169huBMk+9vNxnJYQGVYFOobV9kRZ+8lhCY Ec59/HWNJPVguq0veuUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNXSY-00BeHX-1P; Wed, 10 Jan 2024 12:13:26 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNXSV-00BeGO-1n for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 12:13:24 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50e7b273352so4253511e87.1 for ; Wed, 10 Jan 2024 04:13:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; s=google; t=1704888799; x=1705493599; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=sul2vRO9Fzn0UMSUus+BZBPqeYHWDQxaw3bzygHSyZc=; b=H+VEUs/xBUuL8tkUFDEDZ7jTqEC+sHpEbiAUTOCLOoZMd7gHC2mVoNpNykSh8BfjgG IXejBm/s4jfan9vCB6ylGGfTWK20D6I6wnpBCTf5c23GyVON0peWuitQcp2l0gmdPqbz Ng4Ynr4Q/Gh5J16dkhfebJ2vDnyl/9Txm0nRjuOZSt+86NgRqoGxajSUoTBbGTuhYkQ7 0TvGjvXBHDsTeGVCz+vahVTEuanlKOwiIuatzn0tUU5YD/nLfHeXGOuu9Rxz2QoU3TeS TnOIsXKK2CnkyKHfHrJ6JOCt1sKXNTT21aKjcSyG8Lp3z1YUWhFmvTEgeBJtJXhnh9yl pkMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704888799; x=1705493599; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sul2vRO9Fzn0UMSUus+BZBPqeYHWDQxaw3bzygHSyZc=; b=c+gnCFn3zBP2zQcghYq0Llx45b/wgnD2VuB2N/EBwywb9qTBCYDoV7hH2pPkSS1Ofl YIu6KFllPhmqEydqImbazOxVDAq4UooEPoGP4Q45Fgm8lCtrUNadzR8gSY4kIky6wyU/ UITIr70d733ZiCuTQx5qxeb9yX3bFHzIV+IamvzrGdAMCpJa+Zo5ktXeXm1FCQ9lyetP vITy6+3kF3R1iZl80mFUxcZXMlMfx3ST/ui5Cj8f49dWTLKKlE86B5oLvHwacpS2Jjaf bLbgJqsYSVyP01KN2m5TZ3XgKhJSzS4x0X/+39Y0+SN8XNjQN/NBj1LQEOlf9hiWoenv UEcg== X-Gm-Message-State: AOJu0YxpY9dY4a6HAxt1HPCddnvRoguhJTAM1ak7H7uPbZ+/orO3+vVK Sx5PKFDei3Xd4k3rJ5Xf9Ukn1vagG0NzIQ== X-Google-Smtp-Source: AGHT+IF1BKGjGmz8LspFign6ek2eCcSN5Ct8qEn/F4AJ37X/svKfK3A0NBeEYN5c5XQWGzNUoY3rlA== X-Received: by 2002:a05:6512:3991:b0:50e:b1b7:9301 with SMTP id j17-20020a056512399100b0050eb1b79301mr396237lfu.81.1704888799672; Wed, 10 Jan 2024 04:13:19 -0800 (PST) Received: from localhost (h-46-59-36-113.A463.priv.bahnhof.se. [46.59.36.113]) by smtp.gmail.com with ESMTPSA id d8-20020a193848000000b0050e7d58e58csm659305lfj.174.2024.01.10.04.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 04:13:19 -0800 (PST) Date: Wed, 10 Jan 2024 13:13:18 +0100 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Geert Uytterhoeven Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Magnus Damm , Catalin Marinas , Will Deacon , Ulf Hansson , Cong Dang , Duy Nguyen , Hai Pham , Linh Phung , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 07/15] clk: renesas: rcar-gen4: Add support for FRQCRC1 Message-ID: <20240110121318.GG1625657@ragnatech.se> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_041323_648696_0D42B290 X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgR2VlcnQsCgpUaGFua3MgZm9yIHlvdXIgd29yay4KCk9uIDIwMjQtMDEtMDggMTY6MzM6NDYg KzAxMDAsIEdlZXJ0IFV5dHRlcmhvZXZlbiB3cm90ZToKPiBSLUNhciBWNEggYW5kIFY0TSBoYXZl IGEgc2Vjb25kIEZyZXF1ZW5jeSBDb250cm9sIFJlZ2lzdGVyIEMuCj4gQWRkIHN1cHBvcnQgZm9y IHRoaXMgYnkgdHJlYXRpbmcgYml0IGZpZWxkIG9mZnNldHMgYmV5b25kIDMxIGFzCj4gcmVmZXJy aW5nIHRvIHRoZSBzZWNvbmQgcmVnaXN0ZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogR2VlcnQgVXl0 dGVyaG9ldmVuIDxnZWVydCtyZW5lc2FzQGdsaWRlci5iZT4KClJldmlld2VkLWJ5OiBOaWtsYXMg U8O2ZGVybHVuZCA8bmlrbGFzLnNvZGVybHVuZCtyZW5lc2FzQHJhZ25hdGVjaC5zZT4KCj4gLS0t Cj4gVGVzdGVkIGJ5IGVuYWJsaW5nIENMT0NLX0FMTE9XX1dSSVRFX0RFQlVHRlMgYW5kIGNoZWNr aW5nIHRoZSBpbXBhY3Qgb2YKPiBDUFUgY29yZSBjbGsgcmF0ZSBvbiBDUFUgY29yZSBzcGVlZCBv biBSLUNhciBWNE0uCj4gLS0tCj4gIGRyaXZlcnMvY2xrL3JlbmVzYXMvcmNhci1nZW40LWNwZy5j IHwgMTAgKysrKysrKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAyIGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Nsay9yZW5lc2FzL3JjYXItZ2Vu NC1jcGcuYyBiL2RyaXZlcnMvY2xrL3JlbmVzYXMvcmNhci1nZW40LWNwZy5jCj4gaW5kZXggYzY4 ZDhiOTg3MDU0MTMxYi4uYTJiYmRhZDAyMWVkOGU5NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2Ns ay9yZW5lc2FzL3JjYXItZ2VuNC1jcGcuYwo+ICsrKyBiL2RyaXZlcnMvY2xrL3JlbmVzYXMvcmNh ci1nZW40LWNwZy5jCj4gQEAgLTE3OSw3ICsxNzksOCBAQCBzdGF0aWMgc3RydWN0IGNsayAqIF9f aW5pdCBjcGdfcGxsX2Nsa19yZWdpc3Rlcihjb25zdCBjaGFyICpuYW1lLAo+ICAgKi8KPiAgI2Rl ZmluZSBDUEdfRlJRQ1JCCQkJMHgwMDAwMDgwNAo+ICAjZGVmaW5lIENQR19GUlFDUkJfS0lDSwkJ CUJJVCgzMSkKPiAtI2RlZmluZSBDUEdfRlJRQ1JDCQkJMHgwMDAwMDgwOAo+ICsjZGVmaW5lIENQ R19GUlFDUkMwCQkJMHgwMDAwMDgwOAo+ICsjZGVmaW5lIENQR19GUlFDUkMxCQkJMHgwMDAwMDhl MAo+ICAKPiAgc3RydWN0IGNwZ196X2NsayB7Cj4gIAlzdHJ1Y3QgY2xrX2h3IGh3Owo+IEBAIC0z MDQsNyArMzA1LDEyIEBAIHN0YXRpYyBzdHJ1Y3QgY2xrICogX19pbml0IGNwZ196X2Nsa19yZWdp c3Rlcihjb25zdCBjaGFyICpuYW1lLAo+ICAJaW5pdC5wYXJlbnRfbmFtZXMgPSAmcGFyZW50X25h bWU7Cj4gIAlpbml0Lm51bV9wYXJlbnRzID0gMTsKPiAgCj4gLQl6Y2xrLT5yZWcgPSByZWcgKyBD UEdfRlJRQ1JDOwo+ICsJaWYgKG9mZnNldCA8IDMyKSB7Cj4gKwkJemNsay0+cmVnID0gcmVnICsg Q1BHX0ZSUUNSQzA7Cj4gKwl9IGVsc2Ugewo+ICsJCXpjbGstPnJlZyA9IHJlZyArIENQR19GUlFD UkMxOwo+ICsJCW9mZnNldCAtPSAzMjsKPiArCX0KPiAgCXpjbGstPmtpY2tfcmVnID0gcmVnICsg Q1BHX0ZSUUNSQjsKPiAgCXpjbGstPmh3LmluaXQgPSAmaW5pdDsKPiAgCXpjbGstPm1hc2sgPSBH RU5NQVNLKG9mZnNldCArIDQsIG9mZnNldCk7Cj4gLS0gCj4gMi4zNC4xCj4gCj4gCgotLSAKS2lu ZCBSZWdhcmRzLApOaWtsYXMgU8O2ZGVybHVuZAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=