From: Lee Jones <lee@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Marek Behún" <kabel@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Daniel Golle" <daniel@makrotopia.org>,
"David S. Miller" <davem@davemloft.net>,
"Li Zetao" <lizetao1@huawei.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v6 1/2] leds: trigger: netdev: display only supported link speed attribute
Date: Wed, 10 Jan 2024 12:54:54 +0000 [thread overview]
Message-ID: <20240110125454.GI7948@google.com> (raw)
In-Reply-To: <659e8adc.5d0a0220.a73cd.069f@mx.google.com>
On Wed, 10 Jan 2024, Christian Marangi wrote:
> On Thu, Dec 21, 2023 at 06:11:24PM +0100, Christian Marangi wrote:
> > With the addition of more link speed mode to the netdev trigger, it was
> > pointed out that there may be a problem with bloating the attribute list
> > with modes that won't ever be supported by the trigger as the attached
> > device name doesn't support them.
> >
> > To clear and address this problem, change the logic where these
> > additional trigger modes are listed.
> >
> > Since the netdev trigger REQUIRE a device name to be set, attach to the
> > device name change function additional logic to parse the supported link
> > speed modes using ethtool APIs and show only the supported link speed
> > modes attribute.
> >
> > Link speed attribute are refreshed on device_name set and on
> > NETDEV_CHANGE events.
> >
> > This only apply to the link speed modes and every other mode is still
> > provided by default.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > Reviewed-by: Marek Behún <kabel@kernel.org>
>
> Any news for this?
Not yet. It's on the list. Holidays, merge window, etc.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-01-10 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 17:11 [PATCH v6 1/2] leds: trigger: netdev: display only supported link speed attribute Christian Marangi
2023-12-21 17:11 ` [PATCH v6 2/2] docs: ABI: sysfs-class-led-trigger-netdev: Document now hidable link_* Christian Marangi
2024-01-11 11:26 ` Lee Jones
2024-01-10 12:06 ` [PATCH v6 1/2] leds: trigger: netdev: display only supported link speed attribute Christian Marangi
2024-01-10 12:54 ` Lee Jones [this message]
2024-01-11 11:25 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240110125454.GI7948@google.com \
--to=lee@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.