All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Gibson <warthog618@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Phil Howard <phil@gadgetoid.com>,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-doc@vger.kernel.org, brgl@bgdev.pl, andy@kernel.org,
	corbet@lwn.net
Subject: Re: [PATCH 1/7] Documentation: gpio: add chardev userspace API documentation
Date: Wed, 10 Jan 2024 22:34:28 +0800	[thread overview]
Message-ID: <20240110143428.GA47193@rigel> (raw)
In-Reply-To: <CACRpkdY9yXknHVQMq09Ep_y_Hk6iOkNqDS8icAKFW+fLDdwi-Q@mail.gmail.com>

On Wed, Jan 10, 2024 at 03:27:50PM +0100, Linus Walleij wrote:
> On Wed, Jan 10, 2024 at 2:02 PM Kent Gibson <warthog618@gmail.com> wrote:
> > On Wed, Jan 10, 2024 at 11:40:34AM +0000, Phil Howard wrote:
>
> > > You catch more flies with honey than with vinegar, so I'd probably soften to:
> > >
> > > Before abusing userspace APIs to bitbash drivers for your hardware you should
> > > read Documentation/driver-api/gpio/drivers-on-gpio.rst to see if your device has
> > > an existing kernel driver. If not, please consider contributing one.
> > >
> >
> > The note is is a rewording of a section of the existing sysfs documentation:
> >
> >     DO NOT ABUSE SYSFS TO CONTROL HARDWARE THAT HAS PROPER KERNEL DRIVERS.
> >     PLEASE READ THE DOCUMENT AT Subsystem drivers using GPIO TO AVOID REINVENTING
> >     KERNEL WHEELS IN USERSPACE. I MEAN IT. REALLY.
> >
> > So I've already toned down the vineger.
>
> I wrote that and I recognized the strong wording.
>
> I have come with great regret to the conclusion that it is better to
> shout like this,
> note that the sentence is not directed to any specific person and that means
> it is more OK to be harsh. It is not feedback to anyone, it is black-and-yellow
> warning tape to not go into this dangerous area.
>
> I like the current wording.
>

Can you clarify which current wording?
Are you ok with the proposed chardev wording, or should I be more
closely following the sysfs?

Cheers,
Kent.

  reply	other threads:[~2024-01-10 14:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09 13:59 [PATCH 0/7] Documentation: gpio: add character device userspace API documentation Kent Gibson
2024-01-09 13:59 ` [PATCH 1/7] Documentation: gpio: add chardev " Kent Gibson
2024-01-10 11:40   ` Phil Howard
2024-01-10 12:20     ` Andy Shevchenko
2024-01-10 13:01     ` Kent Gibson
2024-01-10 14:27       ` Linus Walleij
2024-01-10 14:34         ` Kent Gibson [this message]
2024-01-10 14:50           ` Linus Walleij
2024-01-10 14:53             ` Kent Gibson
2024-01-09 13:59 ` [PATCH 2/7] Documentation: gpio: move sysfs into a deprecated section Kent Gibson
2024-01-09 13:59 ` [PATCH 3/7] Documentation: gpio: update sysfs documentation to reference new chardev doc Kent Gibson
2024-01-09 13:59 ` [PATCH 4/7] Documentation: gpio: add chardev v1 userspace API documentation Kent Gibson
2024-01-09 13:59 ` [PATCH 5/7] Documentation: gpio: capitalize GPIO in index title Kent Gibson
2024-01-09 13:59 ` [PATCH 6/7] Documentation: gpio: document gpio-mockup as obsoleted by gpio-sim Kent Gibson
2024-01-09 13:59 ` [PATCH 7/7] Documentation: gpio: move gpio-mockup into deprecated section Kent Gibson
2024-01-09 20:00 ` [PATCH 0/7] Documentation: gpio: add character device userspace API documentation Andy Shevchenko
2024-01-09 23:45   ` Kent Gibson
2024-01-10  8:16     ` Vegard Nossum
2024-01-10 11:10       ` Andy Shevchenko
2024-01-12  1:03         ` Kent Gibson
2024-01-14  2:47 ` Kent Gibson
2024-01-14 12:01   ` Andy Shevchenko
2024-01-14 12:55     ` Kent Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240110143428.GA47193@rigel \
    --to=warthog618@gmail.com \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=corbet@lwn.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phil@gadgetoid.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.