Re: [PATCH] xfs: fix backwards logic in xfs_bmap_alloc_account

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Jan 10, 2024 at 03:41:32PM +0530, Chandan Babu R wrote:
> On Mon, Jan 08, 2024 at 06:17:34 PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > We're only allocating from the realtime device if the inode is marked
> > for realtime and we're /not/ allocating into the attr fork.
> >
> > Fixes: 8a3cf489410dd ("xfs: also use xfs_bmap_btalloc_accounting for RT allocations")
> 
> The commit ID should be 58643460546d
> (https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git/commit/?id=58643460546da1dc61593fc6fd78762798b4534f)
> right?
> 
> If yes, I will fix it before pushing it for-next.

Yes.  Apparently I ran git blame on the wrong branch. :(

--D

> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> >  fs/xfs/libxfs/xfs_bmap.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> > index ed7e11697249e..e1f2e61cb308e 100644
> > --- a/fs/xfs/libxfs/xfs_bmap.c
> > +++ b/fs/xfs/libxfs/xfs_bmap.c
> > @@ -3320,7 +3320,7 @@ xfs_bmap_alloc_account(
> >  	struct xfs_bmalloca	*ap)
> >  {
> >  	bool			isrt = XFS_IS_REALTIME_INODE(ap->ip) &&
> > -					(ap->flags & XFS_BMAPI_ATTRFORK);
> > +					!(ap->flags & XFS_BMAPI_ATTRFORK);
> >  	uint			fld;
> >  
> >  	if (ap->flags & XFS_BMAPI_COWFORK) {
> 
> -- 
> Chandan
>