Re: [Buildroot] [PATCH v2] package/sunxi-mali-utgard: support the wayland driver

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Mon, 24 Apr 2023 10:40:12 +0300
Adrian Perez de Castro <aperez@igalia.com> wrote:

> Add a choice to allow using the Wayland variant of the r6p2 Mali driver.
> When selected, the package is marked as provider for libgbm as
> libMali.so includes the symbols and a libgbm.so symlink is installed;
> and both BR2_PACKAGE_HAS_{LIBGBM,LIBEGL_WAYLAND} are selected
> accordingly.
> 
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> Changes v1 -> v2:
>   - Make Wayland support depend on version r6p2 (suggested by
>     Giulio Benetti).

Thanks, I have applied, with two changes. See below.


> +config BR2_PACKAGE_SUNXI_MALI_UTGARD_WAYLAND
> +	bool "wayland"
> +	depends on BR2_PACKAGE_SUNXI_MALI_UTGARD_R6P2
> +	select BR2_PACKAGE_HAS_LIBEGL_WAYLAND
> +	select BR2_PACKAGE_HAS_LIBGBM

	select BR2_PACKAGE_WAYLAND

was missing here. Indeed, you have "wayland" in the <pkg>_DEPENDENCIES,
but you didn't select it, causing a build failure.

> -	cp -rf $(@D)/$(SUNXI_MALI_UTGARD_REV)/$(SUNXI_MALI_UTGARD_ARCH)/fbdev/*.so* \
> +	cp -rf $(@D)/$(SUNXI_MALI_UTGARD_REV)/$(SUNXI_MALI_UTGARD_ARCH)/$(BR2_PACKAGE_SUNXI_MALI_UTGARD_PLATFORM)/*.so* \

I have introduced an intermediate SUNXI_MALI_UTGARD_PLATFORM which
contains the qstripped value of BR2_PACKAGE_SUNXI_MALI_UTGARD_PLATFORM,
to keep things a bit nicer and aligned with what the package was
already doing for other variables.

Thanks a lot for this contribution, and sorry for the huge delay!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot