From: Matthew Auld <matthew.auld@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t] tests/intel/xe_exec_store: don't pass gt_id as bind queue
Date: Thu, 11 Jan 2024 09:01:52 +0000 [thread overview]
Message-ID: <20240111090152.296752-1-matthew.auld@intel.com> (raw)
The gt_id of the engine is not a valid bind queue. Typically it is zero
so we likely don't notice anything, but that might not always be the
case.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Jagmeet Randhawa <jagmeet.randhawa@intel.com>
---
tests/intel/xe_exec_store.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/intel/xe_exec_store.c b/tests/intel/xe_exec_store.c
index 870394d3c..3ec84295b 100644
--- a/tests/intel/xe_exec_store.c
+++ b/tests/intel/xe_exec_store.c
@@ -217,7 +217,7 @@ static void store_cachelines(int fd, struct drm_xe_engine_class_instance *eci,
dst_offset[i] = intel_allocator_alloc_with_strategy(ahnd, bo[i],
bo_size, 0,
ALLOC_STRATEGY_LOW_TO_HIGH);
- xe_vm_bind_async(fd, vm, eci->gt_id, bo[i], 0, dst_offset[i], bo_size, sync, 1);
+ xe_vm_bind_async(fd, vm, 0, bo[i], 0, dst_offset[i], bo_size, sync, 1);
}
batch_map = xe_bo_map(fd, bo[i-1], bo_size);
@@ -303,7 +303,7 @@ static void persistent(int fd)
vram_if_possible(fd, engine->instance.gt_id),
DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
- xe_vm_bind_async(fd, vm, engine->instance.gt_id, sd_batch, 0, addr, batch_size, &sync, 1);
+ xe_vm_bind_async(fd, vm, 0, sd_batch, 0, addr, batch_size, &sync, 1);
sd_data = xe_bo_map(fd, sd_batch, batch_size);
prt_data = xe_bo_map(fd, prt_batch, batch_size);
--
2.43.0
next reply other threads:[~2024-01-11 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 9:01 Matthew Auld [this message]
2024-01-11 11:01 ` ✓ Fi.CI.BAT: success for tests/intel/xe_exec_store: don't pass gt_id as bind queue Patchwork
2024-01-11 11:20 ` ✗ CI.xeBAT: failure " Patchwork
2024-01-12 17:43 ` Kamil Konieczny
2024-01-18 11:16 ` Illipilli, TejasreeX
2024-01-11 13:08 ` ✓ Fi.CI.IGT: success " Patchwork
2024-01-11 20:32 ` [PATCH i-g-t] " Randhawa, Jagmeet
2024-01-11 20:32 ` Randhawa, Jagmeet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111090152.296752-1-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.