From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5370515482; Thu, 11 Jan 2024 11:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gXydpx5Y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0942C433C7; Thu, 11 Jan 2024 11:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704971012; bh=bI1Tet5jDj/QH09wURUJK1NElS1yuV/fwxx+hGurCKQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gXydpx5YYq7Gt4XhTMlirofDbH/GMG4JFQlhuY7CLC45RscIa+dfuNP803StsPw4j n/UR34vmiBCA5F5LI5+rTkeauMcYorGlS7G839valCfkC8HrstTBx/HJsz6aG/7HPW 0Dc/Zw10+M/cbeekw5rO3Q4C8RFcHWRO0oUmMto6iyj7jTZEYb/tzmOLpyuIpMrkle rT74OZ9SuM4hEjuUvmH/w+kcmqEybvzeiuRI5mLvZvnafUfn+u4YJWb7y0p2tW7toF 0YZdGHN5h95Yfef+oqzDKrSKm8BoCpRNP7GIQ5gIchh5x8DU1Sg6DKuGEhiBjyddh0 ws0TlA9d2M/Dg== Date: Thu, 11 Jan 2024 11:03:25 +0000 From: Lee Jones To: Christian Marangi Cc: Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Russell King , Jacek Anaszewski , =?iso-8859-1?Q?Fern=E1ndez?= Rojas , Sven Schwermer , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [net-next PATCH v9 1/5] dt-bindings: net: phy: Make LED active-low property common Message-ID: <20240111110325.GE1678981@google.com> References: <20240105142719.11042-1-ansuelsmth@gmail.com> <20240105142719.11042-2-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240105142719.11042-2-ansuelsmth@gmail.com> On Fri, 05 Jan 2024, Christian Marangi wrote: > Move LED active-low property to common.yaml. This property is currently > defined multiple times by bcm LEDs. This property will now be supported > in a generic way for PHY LEDs with the use of a generic function. > > With active-low bool property not defined, active-high is always > assumed. > > Signed-off-by: Christian Marangi > --- > Changes v5: > - Make active-low generic > Changes v4: > - Drop support for global active-low > - Rework to polarity option (for marvell10g series support) > Changes v3: > - Out of RFC > Changes v2: > - Add this patch > > Documentation/devicetree/bindings/leds/common.yaml | 6 ++++++ > Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 4 ---- > Documentation/devicetree/bindings/leds/leds-bcm6328.yaml | 4 ---- > Documentation/devicetree/bindings/leds/leds-bcm6358.txt | 2 -- > .../devicetree/bindings/leds/leds-pwm-multicolor.yaml | 4 ---- > Documentation/devicetree/bindings/leds/leds-pwm.yaml | 5 ----- > 6 files changed, 6 insertions(+), 19 deletions(-) If the DT Maintainers are happy, so am I. Acked-by: Lee Jones -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7582EC4707B for ; Thu, 11 Jan 2024 11:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I2O8hKi1tqP16IpD3WLZ79VWDRyVUqSMfpMirOgWk28=; b=0ub6Sc66hHJ9ZE ecbstW+GNoGMJYUZwxvLizDjxp1N23WeUgVxCadIkVPsX4bqJFJ0bWlU1+xL1rcliOc54oBw3/M4S 7I8jQ9lXVDGQYn132wIJ9MJYJKFSmC/dT/Epm3YewIkQ2aaSsRcDJXgnbxbDp1TospBBkb0ZGNYF2 w18o7vDXNx5RKW6iPMNUF6aZwd+CTf/2oFaQxi7AiBy62iHEiFo/5b3W73fXUJX47Llr9e5Tkqui4 NYbgKFsx7EVmtyrWvGOMXCIsr8UgQ7Fj0eWyQL8VvYU6qut6wH6XTBXIe8PRUs4ZIQ7QRaymkOxOM JiytrrOtDKysvOQm6CIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNsqW-00HA1q-0o; Thu, 11 Jan 2024 11:03:36 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNsqT-00HA0c-2U for linux-arm-kernel@lists.infradead.org; Thu, 11 Jan 2024 11:03:35 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EBCE06194F; Thu, 11 Jan 2024 11:03:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0942C433C7; Thu, 11 Jan 2024 11:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704971012; bh=bI1Tet5jDj/QH09wURUJK1NElS1yuV/fwxx+hGurCKQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gXydpx5YYq7Gt4XhTMlirofDbH/GMG4JFQlhuY7CLC45RscIa+dfuNP803StsPw4j n/UR34vmiBCA5F5LI5+rTkeauMcYorGlS7G839valCfkC8HrstTBx/HJsz6aG/7HPW 0Dc/Zw10+M/cbeekw5rO3Q4C8RFcHWRO0oUmMto6iyj7jTZEYb/tzmOLpyuIpMrkle rT74OZ9SuM4hEjuUvmH/w+kcmqEybvzeiuRI5mLvZvnafUfn+u4YJWb7y0p2tW7toF 0YZdGHN5h95Yfef+oqzDKrSKm8BoCpRNP7GIQ5gIchh5x8DU1Sg6DKuGEhiBjyddh0 ws0TlA9d2M/Dg== Date: Thu, 11 Jan 2024 11:03:25 +0000 From: Lee Jones To: Christian Marangi Cc: Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Russell King , Jacek Anaszewski , =?iso-8859-1?Q?Fern=E1ndez?= Rojas , Sven Schwermer , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [net-next PATCH v9 1/5] dt-bindings: net: phy: Make LED active-low property common Message-ID: <20240111110325.GE1678981@google.com> References: <20240105142719.11042-1-ansuelsmth@gmail.com> <20240105142719.11042-2-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240105142719.11042-2-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240111_030333_852131_BF41F596 X-CRM114-Status: GOOD ( 15.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAwNSBKYW4gMjAyNCwgQ2hyaXN0aWFuIE1hcmFuZ2kgd3JvdGU6Cgo+IE1vdmUgTEVE IGFjdGl2ZS1sb3cgcHJvcGVydHkgdG8gY29tbW9uLnlhbWwuIFRoaXMgcHJvcGVydHkgaXMgY3Vy cmVudGx5Cj4gZGVmaW5lZCBtdWx0aXBsZSB0aW1lcyBieSBiY20gTEVEcy4gVGhpcyBwcm9wZXJ0 eSB3aWxsIG5vdyBiZSBzdXBwb3J0ZWQKPiBpbiBhIGdlbmVyaWMgd2F5IGZvciBQSFkgTEVEcyB3 aXRoIHRoZSB1c2Ugb2YgYSBnZW5lcmljIGZ1bmN0aW9uLgo+IAo+IFdpdGggYWN0aXZlLWxvdyBi b29sIHByb3BlcnR5IG5vdCBkZWZpbmVkLCBhY3RpdmUtaGlnaCBpcyBhbHdheXMKPiBhc3N1bWVk Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBNYXJhbmdpIDxhbnN1ZWxzbXRoQGdtYWls LmNvbT4KPiAtLS0KPiBDaGFuZ2VzIHY1Ogo+IC0gTWFrZSBhY3RpdmUtbG93IGdlbmVyaWMKPiBD aGFuZ2VzIHY0Ogo+IC0gRHJvcCBzdXBwb3J0IGZvciBnbG9iYWwgYWN0aXZlLWxvdwo+IC0gUmV3 b3JrIHRvIHBvbGFyaXR5IG9wdGlvbiAoZm9yIG1hcnZlbGwxMGcgc2VyaWVzIHN1cHBvcnQpCj4g Q2hhbmdlcyB2MzoKPiAtIE91dCBvZiBSRkMKPiBDaGFuZ2VzIHYyOgo+IC0gQWRkIHRoaXMgcGF0 Y2gKPiAKPiAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2xlZHMvY29tbW9uLnlh bWwgICAgICAgICAgfCA2ICsrKysrKwo+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvbGVkcy9sZWRzLWJjbTYzMTM4LnlhbWwgICB8IDQgLS0tLQo+ICBEb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvbGVkcy9sZWRzLWJjbTYzMjgueWFtbCAgICB8IDQgLS0tLQo+ICBE b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbGVkcy9sZWRzLWJjbTYzNTgudHh0ICAg ICB8IDIgLS0KPiAgLi4uL2RldmljZXRyZWUvYmluZGluZ3MvbGVkcy9sZWRzLXB3bS1tdWx0aWNv bG9yLnlhbWwgICAgICAgfCA0IC0tLS0KPiAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2xlZHMvbGVkcy1wd20ueWFtbCAgICAgICAgfCA1IC0tLS0tCj4gIDYgZmlsZXMgY2hhbmdl ZCwgNiBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkKCklmIHRoZSBEVCBNYWludGFpbmVy cyBhcmUgaGFwcHksIHNvIGFtIEkuCgpBY2tlZC1ieTogTGVlIEpvbmVzIDxsZWVAa2VybmVsLm9y Zz4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK