From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EAC3C47258 for ; Thu, 11 Jan 2024 13:12:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D73E983F84; Thu, 11 Jan 2024 13:12:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D73E983F84 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1704978728; bh=oK+SZpxVP9dfPBRC2MhR/At6h6YXSK4ven1Z6Tfv30k=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=dOINyMOyjuBEpdmOYcgK3NKgVdw8InjN8KsmFDb+HVP3nPbXehIGYBcbPTJGh1yA0 9Djg3LX91EMFY3PBvEFob6zEg193QDTVzbiweasMzLk11Hnt6s/lecPfuTVnfelfPX xWfsZS09m0v4H7KIX9rnYn0pK0wDQVt4PbBl0fy8v1ns/kyrj+TpoCiu/DWCqHtZUQ KBgxjn2Da1604I7byR+tO0di/mXh6clLJniK26Hk7PEjTK6JeTNNuVO3d1ZKKtOWiF olap2tF/qJGc4dWJr7P0C0ajvjwqzYjEJ65QvAqhaAwS+dITsTyJ8alyswzuqlXMaZ EXaeoJQc6j2tg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bRiHIabynize; Thu, 11 Jan 2024 13:12:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 4FD7A83F46; Thu, 11 Jan 2024 13:12:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4FD7A83F46 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id B36721BF990 for ; Thu, 11 Jan 2024 13:12:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 97D1E83F43 for ; Thu, 11 Jan 2024 13:12:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 97D1E83F43 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ge0Z8z145xgB for ; Thu, 11 Jan 2024 13:12:03 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 390C583F3D for ; Thu, 11 Jan 2024 13:12:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 390C583F3D Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1E264CE1FAC; Thu, 11 Jan 2024 13:11:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 094CBC43390; Thu, 11 Jan 2024 13:11:44 +0000 (UTC) Date: Thu, 11 Jan 2024 13:11:42 +0000 From: Simon Horman To: Tony Nguyen Message-ID: <20240111131142.GA45291@kernel.org> References: <20240111003927.2362752-1-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111003927.2362752-1-anthony.l.nguyen@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704978706; bh=dEUoOzbDSUs2ajAA/+VFBTHK/an89vyrW+ZYe9968ts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=olppppiJwdWh9QNKijoUO5xiB1QNBaAzpx2fhXu6wY9rgbnfiUGNinohXzzdJ7Us3 I7raQAFAkz8S6GFodC3upVdpqyRX3hOh58IPnArlpnbbTM/P+6IRaljZAho0KVceLZ pDH8IEFVYs8OjirJ3nbQiiM0W+X515VBo/A+EydDH1Eph2/8fZNZO8lF7a7xR+l8rm qTC7nVpWaZQKoh1o5qvu8YLNvt29031s/YIZ8KqnEc33Y1olBuqQ41PE/3MUY1RS+M NbeY2KaYs5tZk12maPdisQ4HNNz/WV5Ekb1q41TqqvOsvmnrS7trtRpbBP9rHZuQXq q3+GN9SphHZ0g== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=olppppiJ Subject: Re: [Intel-wired-lan] [PATCH iwl-net] i40e: Include types.h to some headers X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ivecera@redhat.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Martin Zaharinov , Jesse Brandeburg Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Jan 10, 2024 at 04:39:25PM -0800, Tony Nguyen wrote: > Commit 56df345917c0 ("i40e: Remove circular header dependencies and fix > headers") redistributed a number of includes from one large header file > to the locations they were needed. In some environments, types.h is not > included and causing compile issues. The driver should not rely on > implicit inclusion from other locations; explicitly include it to these > files. > > Snippet of issue. Entire log can be seen through the Closes: link. > > In file included from drivers/net/ethernet/intel/i40e/i40e_diag.h:7, > from drivers/net/ethernet/intel/i40e/i40e_diag.c:4: > drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h:33:9: error: unknown type name '__le16' > 33 | __le16 flags; > | ^~~~~~ > drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h:34:9: error: unknown type name '__le16' > 34 | __le16 opcode; > | ^~~~~~ > ... > drivers/net/ethernet/intel/i40e/i40e_diag.h:22:9: error: unknown type name 'u32' > 22 | u32 elements; /* number of elements if array */ > | ^~~ > drivers/net/ethernet/intel/i40e/i40e_diag.h:23:9: error: unknown type name 'u32' > 23 | u32 stride; /* bytes between each element */ > > Reported-by: Martin Zaharinov > Closes: https://lore.kernel.org/netdev/21BBD62A-F874-4E42-B347-93087EEA8126@gmail.com/ > Fixes: 56df345917c0 ("i40e: Remove circular header dependencies and fix headers") > Reviewed-by: Jesse Brandeburg > Signed-off-by: Tony Nguyen Hi Tony, I agree this is a good change to make. But I am curious to know if you were able to reproduce the problem reported at the link above. Or perhaps more to the point, do you have a config that breaks without this patch? From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7BFE171AE for ; Thu, 11 Jan 2024 13:11:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="olppppiJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 094CBC43390; Thu, 11 Jan 2024 13:11:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704978706; bh=dEUoOzbDSUs2ajAA/+VFBTHK/an89vyrW+ZYe9968ts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=olppppiJwdWh9QNKijoUO5xiB1QNBaAzpx2fhXu6wY9rgbnfiUGNinohXzzdJ7Us3 I7raQAFAkz8S6GFodC3upVdpqyRX3hOh58IPnArlpnbbTM/P+6IRaljZAho0KVceLZ pDH8IEFVYs8OjirJ3nbQiiM0W+X515VBo/A+EydDH1Eph2/8fZNZO8lF7a7xR+l8rm qTC7nVpWaZQKoh1o5qvu8YLNvt29031s/YIZ8KqnEc33Y1olBuqQ41PE/3MUY1RS+M NbeY2KaYs5tZk12maPdisQ4HNNz/WV5Ekb1q41TqqvOsvmnrS7trtRpbBP9rHZuQXq q3+GN9SphHZ0g== Date: Thu, 11 Jan 2024 13:11:42 +0000 From: Simon Horman To: Tony Nguyen Cc: intel-wired-lan@lists.osuosl.org, ivecera@redhat.com, netdev@vger.kernel.org, Martin Zaharinov , Jesse Brandeburg Subject: Re: [PATCH iwl-net] i40e: Include types.h to some headers Message-ID: <20240111131142.GA45291@kernel.org> References: <20240111003927.2362752-1-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111003927.2362752-1-anthony.l.nguyen@intel.com> On Wed, Jan 10, 2024 at 04:39:25PM -0800, Tony Nguyen wrote: > Commit 56df345917c0 ("i40e: Remove circular header dependencies and fix > headers") redistributed a number of includes from one large header file > to the locations they were needed. In some environments, types.h is not > included and causing compile issues. The driver should not rely on > implicit inclusion from other locations; explicitly include it to these > files. > > Snippet of issue. Entire log can be seen through the Closes: link. > > In file included from drivers/net/ethernet/intel/i40e/i40e_diag.h:7, > from drivers/net/ethernet/intel/i40e/i40e_diag.c:4: > drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h:33:9: error: unknown type name '__le16' > 33 | __le16 flags; > | ^~~~~~ > drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h:34:9: error: unknown type name '__le16' > 34 | __le16 opcode; > | ^~~~~~ > ... > drivers/net/ethernet/intel/i40e/i40e_diag.h:22:9: error: unknown type name 'u32' > 22 | u32 elements; /* number of elements if array */ > | ^~~ > drivers/net/ethernet/intel/i40e/i40e_diag.h:23:9: error: unknown type name 'u32' > 23 | u32 stride; /* bytes between each element */ > > Reported-by: Martin Zaharinov > Closes: https://lore.kernel.org/netdev/21BBD62A-F874-4E42-B347-93087EEA8126@gmail.com/ > Fixes: 56df345917c0 ("i40e: Remove circular header dependencies and fix headers") > Reviewed-by: Jesse Brandeburg > Signed-off-by: Tony Nguyen Hi Tony, I agree this is a good change to make. But I am curious to know if you were able to reproduce the problem reported at the link above. Or perhaps more to the point, do you have a config that breaks without this patch?