From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
zlang@redhat.com, fstests@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: check that the mountpoint is actually mounted in _supports_xfs_scrub
Date: Thu, 11 Jan 2024 18:25:56 +0100 [thread overview]
Message-ID: <20240111172556.GB22255@lst.de> (raw)
In-Reply-To: <20240111172022.GO723010@frogsfrogsfrogs>
On Thu, Jan 11, 2024 at 09:20:22AM -0800, Darrick J. Wong wrote:
> > + mountpoint $mountpoint >/dev/null || echo "$mountpoint is not mounted"
>
> The helper needs to return nonzero on failure, e.g.
>
> if ! mountpoint -q $mountpoint; then
> echo "$mountpoint is not mounted"
> return 1
> fi
No, it doesn't.. I actually did exactly that first, but that causes the
test to be _notrun instead of reporting the error and thus telling the
author that they usage of this helper is wrong.
next prev parent reply other threads:[~2024-01-11 17:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 14:24 _supports_xfs_scrub cleanups Christoph Hellwig
2024-01-11 14:24 ` [PATCH 1/3] xfs: check that the mountpoint is actually mounted in _supports_xfs_scrub Christoph Hellwig
2024-01-11 17:20 ` Darrick J. Wong
2024-01-11 17:25 ` Christoph Hellwig [this message]
2024-01-11 21:17 ` Zorro Lang
2024-01-12 2:17 ` Darrick J. Wong
2024-01-12 4:42 ` Christoph Hellwig
2024-01-12 4:41 ` Christoph Hellwig
2024-01-11 14:24 ` [PATCH 2/3] xfs: add a _scratch_require_xfs_scrub helper Christoph Hellwig
2024-01-11 17:20 ` Darrick J. Wong
2024-01-11 14:24 ` [PATCH 3/3] xfs/262: call _scratch_require_xfs_scrub Christoph Hellwig
2024-01-11 17:20 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111172556.GB22255@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.