From: Robert Hoo <robert.hoo.linux@gmail.com>
To: seanjc@google.com, pbonzini@redhat.com, kvm@vger.kernel.org
Cc: Robert Hoo <robert.hoo.linux@gmail.com>
Subject: [PATCH] KVM: VMX: Correct *intr_info content and *info2 for EPT_VIOLATION in get_exit_info()
Date: Fri, 12 Jan 2024 14:51:59 +0800 [thread overview]
Message-ID: <20240112065159.982-1-robert.hoo.linux@gmail.com> (raw)
Fill vmx::idt_vectoring_info in *intr_info, to align with
svm_get_exit_info(), where *intr_info is for complement information about
intercepts occurring during event delivery through IDT (APM 15.7.2
Intercepts During IDT Interrupt Delivery), whose counterpart in
VMX is IDT_VECTORING_INFO_FIELD (SDM 25.9.3 Information for VM Exits
That Occur During Event Delivery), rather than VM_EXIT_INTR_INFO.
Fill *info2 with GUEST_PHYSICAL_ADDRESS in case of EPT_VIOLATION, also
to align with SVM. It can be filled with other info for different exit
reasons, like SVM's EXITINFO2.
Fixes: 235ba74f008d ("KVM: x86: Add intr/vectoring info and error code to kvm_exit tracepoint")
Signed-off-by: Robert Hoo <robert.hoo.linux@gmail.com>
---
arch/x86/kvm/vmx/vmx.c | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index d21f55f323ea..f1bf9f1fc561 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -6141,14 +6141,26 @@ static void vmx_get_exit_info(struct kvm_vcpu *vcpu, u32 *reason,
*reason = vmx->exit_reason.full;
*info1 = vmx_get_exit_qual(vcpu);
+
if (!(vmx->exit_reason.failed_vmentry)) {
- *info2 = vmx->idt_vectoring_info;
- *intr_info = vmx_get_intr_info(vcpu);
+ *intr_info = vmx->idt_vectoring_info;
if (is_exception_with_error_code(*intr_info))
- *error_code = vmcs_read32(VM_EXIT_INTR_ERROR_CODE);
+ *error_code = vmcs_read32(IDT_VECTORING_ERROR_CODE);
else
*error_code = 0;
- } else {
+
+ /* various *info2 semantics according to exit reason */
+ switch (vmx->exit_reason.basic) {
+ case EXIT_REASON_EPT_VIOLATION:
+ *info2 = vmcs_read64(GUEST_PHYSICAL_ADDRESS);
+ break;
+ /* To do: *info2 for other exit reasons */
+ default:
+ *info2 = 0;
+ break;
+ }
+
+ } else {
*info2 = 0;
*intr_info = 0;
*error_code = 0;
base-commit: 1c6d984f523f67ecfad1083bb04c55d91977bb15
--
2.39.3
next reply other threads:[~2024-01-12 6:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 6:51 Robert Hoo [this message]
2024-01-26 20:45 ` [PATCH] KVM: VMX: Correct *intr_info content and *info2 for EPT_VIOLATION in get_exit_info() Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112065159.982-1-robert.hoo.linux@gmail.com \
--to=robert.hoo.linux@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.