From: Stephen Hemminger <stephen@networkplumber.org>
To: madhuker.mythri@oracle.com
Cc: dev@dpdk.org, ferruh.yigit@amd.com
Subject: Re: [PATCH] net/tap: Modified TAP BPF program as per the Kernel-version upgrade requirements.
Date: Fri, 12 Jan 2024 08:46:48 -0800 [thread overview]
Message-ID: <20240112084648.7f7ff52a@hermes.local> (raw)
In-Reply-To: <20240112134821.2067-1-madhuker.mythri@oracle.com>
On Fri, 12 Jan 2024 19:18:21 +0530
madhuker.mythri@oracle.com wrote:
> struct ipv4_l3_l4_tuple v4_tuple = {
> - .src_addr = IPv4(*(src_dst_addr + 0),
> - *(src_dst_addr + 1),
> - *(src_dst_addr + 2),
> - *(src_dst_addr + 3)),
> - .dst_addr = IPv4(*(src_dst_addr + 4),
> - *(src_dst_addr + 5),
> - *(src_dst_addr + 6),
> - *(src_dst_addr + 7)),
> + .src_addr = bpf_ntohl(nh.iph.saddr),
> + .dst_addr = bpf_ntohl(nh.iph.daddr),
Not sure this is correct.
The RSS calculation (Toeplitz) expects that data is in network
byte order. See app/test/test_thash.c for example.
next prev parent reply other threads:[~2024-01-12 16:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 13:48 [PATCH] net/tap: Modified TAP BPF program as per the Kernel-version upgrade requirements madhuker.mythri
2024-01-12 16:40 ` Stephen Hemminger
2024-01-12 16:41 ` Stephen Hemminger
2024-01-13 17:50 ` [External] : " Madhuker Mythri
2024-01-13 18:05 ` Stephen Hemminger
2024-01-16 16:43 ` Stephen Hemminger
2024-01-12 16:42 ` Stephen Hemminger
2024-01-13 17:52 ` [External] : " Madhuker Mythri
2024-01-13 18:06 ` Stephen Hemminger
2024-01-16 5:43 ` Madhuker Mythri
2024-01-16 16:40 ` Stephen Hemminger
2024-01-17 3:25 ` Stephen Hemminger
2024-01-17 16:19 ` Madhuker Mythri
2024-01-12 16:43 ` Stephen Hemminger
2024-01-12 16:46 ` Stephen Hemminger [this message]
2024-01-13 17:55 ` [External] : " Madhuker Mythri
2024-01-12 17:53 ` [RFC v3] tap: rework the BPF header parsing Stephen Hemminger
2024-02-07 18:55 ` [PATCH] net/tap: Modified TAP BPF program as per the Kernel-version upgrade requirements Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112084648.7f7ff52a@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=madhuker.mythri@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.