From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] man/tc-mirred: don't recommend modprobe
Date: Fri, 12 Jan 2024 09:09:15 -0800 [thread overview]
Message-ID: <20240112090915.67f2417a@hermes.local> (raw)
In-Reply-To: <ZaE0PxX_NjxNyMEA@nanopsycho>
On Fri, 12 Jan 2024 13:44:47 +0100
Jiri Pirko <jiri@resnulli.us> wrote:
> Thu, Jan 11, 2024 at 08:34:44PM CET, stephen@networkplumber.org wrote:
> >Use ip link add instead of explicit modprobe.
> >Kernel will do correct module loading if necessary.
> >
> >Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >---
> > man/man8/tc-mirred.8 | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> >diff --git a/man/man8/tc-mirred.8 b/man/man8/tc-mirred.8
> >index 38833b452d92..2d9795b1b16f 100644
> >--- a/man/man8/tc-mirred.8
> >+++ b/man/man8/tc-mirred.8
> >@@ -84,8 +84,7 @@ interface, it is possible to send ingress traffic through an instance of
> >
> > .RS
> > .EX
> >-# modprobe ifb
> >-# ip link set ifb0 up
> >+# ip link add dev ifb0 type ifb
>
> RTNETLINK answers: File exists
>
> You can't add "ifb0" like this, it is created implicitly on module probe
> time. Pick a different name.
Right.
Looks like ifb is behaving differently than other devices.
For example, doing modprobe of dummy creates no device.
next prev parent reply other threads:[~2024-01-12 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 19:34 [PATCH iproute2] man/tc-mirred: don't recommend modprobe Stephen Hemminger
2024-01-12 12:44 ` Jiri Pirko
2024-01-12 17:09 ` Stephen Hemminger [this message]
2024-01-12 18:21 ` Jiri Pirko
2024-01-12 18:42 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112090915.67f2417a@hermes.local \
--to=stephen@networkplumber.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.