All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Carlos Maiolino <cmaiolino@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/4] libxfs: also query log device topology in get_topology
Date: Fri, 12 Jan 2024 08:52:44 -0800	[thread overview]
Message-ID: <20240112165244.GW722975@frogsfrogsfrogs> (raw)
In-Reply-To: <20240112044743.2254211-4-hch@lst.de>

On Fri, Jan 12, 2024 at 05:47:42AM +0100, Christoph Hellwig wrote:
> Also query the log device topology in get_topology, which we'll need
> in mkfs in a bit.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  libxfs/topology.c | 1 +
>  libxfs/topology.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/libxfs/topology.c b/libxfs/topology.c
> index 227f8c44f..991f82706 100644
> --- a/libxfs/topology.c
> +++ b/libxfs/topology.c
> @@ -346,4 +346,5 @@ get_topology(
>  {
>  	get_device_topology(&xi->data, &ft->data, force_overwrite);
>  	get_device_topology(&xi->rt, &ft->rt, force_overwrite);
> +	get_device_topology(&xi->log, &ft->log, force_overwrite);
>  }
> diff --git a/libxfs/topology.h b/libxfs/topology.h
> index ba0c8f669..fa0a23b77 100644
> --- a/libxfs/topology.h
> +++ b/libxfs/topology.h
> @@ -20,6 +20,7 @@ struct device_topology {
>  struct fs_topology {
>  	struct device_topology	data;
>  	struct device_topology	rt;
> +	struct device_topology	log;
>  };
>  
>  void
> -- 
> 2.39.2
> 
> 

  reply	other threads:[~2024-01-12 16:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12  4:47 fix log sector size detection Christoph Hellwig
2024-01-12  4:47 ` [PATCH 1/4] libxfs: remove the unused fs_topology_t typedef Christoph Hellwig
2024-01-12 16:44   ` Darrick J. Wong
2024-01-12 16:48     ` Christoph Hellwig
2024-01-12 16:54       ` Darrick J. Wong
2024-01-12  4:47 ` [PATCH 2/4] libxfs: refactor the fs_topology structure Christoph Hellwig
2024-01-12 16:52   ` Darrick J. Wong
2024-01-12  4:47 ` [PATCH 3/4] libxfs: also query log device topology in get_topology Christoph Hellwig
2024-01-12 16:52   ` Darrick J. Wong [this message]
2024-01-12  4:47 ` [PATCH 4/4] mkfs: use a sensible log sector size default Christoph Hellwig
2024-01-12 16:53   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240112165244.GW722975@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=cmaiolino@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.