From: "Michal Koutný" <mkoutny@suse.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, cake@lists.bufferbloat.net
Cc: "David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Cong Wang" <xiyou.wangcong@gmail.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Stanislav Fomichev" <sdf@google.com>,
"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Vinicius Costa Gomes" <vinicius.gomes@intel.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Petr Pavlu" <ppavlu@suse.cz>,
"Michal Kubecek" <mkubecek@suse.cz>,
"Martin Wilck" <mwilck@suse.com>
Subject: [PATCH v3 4/4] net/sched: Remove aliases of act_xt and sch_clsact
Date: Fri, 12 Jan 2024 19:06:46 +0100 [thread overview]
Message-ID: <20240112180646.13232-5-mkoutny@suse.com> (raw)
In-Reply-To: <20240112180646.13232-1-mkoutny@suse.com>
The modules act_ipt and sch_ingress standout among net/sched modules
because they provide multiple act/sch functionalities in a single .ko.
They have aliases to make autoloading work for any of the provided
functionalities.
Since the autoloading was changed to uniformly request any functionality
under its alias, the non-systemic aliases can be removed now (i.e.
assuming the alias were only used to ensure autoloading).
Signed-off-by: Michal Koutný <mkoutny@suse.com>
---
net/sched/act_ipt.c | 1 -
net/sched/sch_ingress.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/net/sched/act_ipt.c b/net/sched/act_ipt.c
index 098ea7e06f4c..d2fb6b19f7f0 100644
--- a/net/sched/act_ipt.c
+++ b/net/sched/act_ipt.c
@@ -436,7 +436,6 @@ static struct pernet_operations xt_net_ops = {
MODULE_AUTHOR("Jamal Hadi Salim(2002-13)");
MODULE_DESCRIPTION("Iptables target actions");
MODULE_LICENSE("GPL");
-MODULE_ALIAS("act_xt");
static int __init ipt_init_module(void)
{
diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c
index 48a800131e99..c2ef9dcf91d2 100644
--- a/net/sched/sch_ingress.c
+++ b/net/sched/sch_ingress.c
@@ -370,6 +370,5 @@ static void __exit ingress_module_exit(void)
module_init(ingress_module_init);
module_exit(ingress_module_exit);
-MODULE_ALIAS("sch_clsact");
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Ingress and clsact based ingress and egress qdiscs");
--
2.43.0
next prev parent reply other threads:[~2024-01-12 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 18:06 [PATCH v3 0/4] net/sched: Load modules via alias Michal Koutný
2024-01-12 18:06 ` [PATCH v3 1/4] net/sched: Add helper macros with module names Michal Koutný
2024-01-12 18:38 ` Pedro Tammela
2024-01-15 12:16 ` Michal Koutný
2024-01-12 18:06 ` [PATCH v3 2/4] net/sched: Add module aliases for cls_,sch_,act_ modules Michal Koutný
2024-01-12 18:06 ` [PATCH v3 3/4] net/sched: Load modules via their alias Michal Koutný
2024-01-12 18:06 ` Michal Koutný [this message]
2024-01-13 1:33 ` [PATCH v3 0/4] net/sched: Load modules via alias Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112180646.13232-5-mkoutny@suse.com \
--to=mkoutny@suse.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cake@lists.bufferbloat.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mkubecek@suse.cz \
--cc=mwilck@suse.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ppavlu@suse.cz \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=stephen@networkplumber.org \
--cc=toke@toke.dk \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.