From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B315C4707C for ; Fri, 12 Jan 2024 19:27:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 85DDE60ABF; Fri, 12 Jan 2024 19:27:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 85DDE60ABF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1705087679; bh=nvCx8/7esfX6t4l0yfeOH4JGQFb1VpHpvLJuqyFwK1A=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=lDMFkN2g4Wv7o/hG6cR0ENGvo4RY6dZPuKbplJ/cX+CK3/4U6VbC3oW/RmkiM89/5 u4M/sDk0H0Ip/DahXa43kwJqQnWtYBEkr6++priHGpEFUYDOkEfMYSJGCNdjC9VQFa 9Mrnf30GBXeC+IZHjdK+iZz/itzNAxvJSH7Rq34trqihoxETyZzGP1mTMBBtwVClho ot1pmq5egpyrLWoKFjZ+E8e0CfjtsLHALgpsTRNVJcRr9ZCdxrK4bTNsthCPPL8Na3 oo7d/e6n5pKHJgIBtFTnVIWOTs/qmPj4KhtHiCVB+qhf5d18/bPK1FsK9Dznn0gOV/ 9prFOC1+KG2Ng== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YSeVlY_47gdu; Fri, 12 Jan 2024 19:27:58 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 88BDA60BE0; Fri, 12 Jan 2024 19:27:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 88BDA60BE0 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 790211BF489 for ; Fri, 12 Jan 2024 19:27:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 41220403B8 for ; Fri, 12 Jan 2024 19:27:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 41220403B8 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ysv6VP-c7-f0 for ; Fri, 12 Jan 2024 19:27:54 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id 2411540280 for ; Fri, 12 Jan 2024 19:27:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2411540280 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DD5EC61CE8; Fri, 12 Jan 2024 19:27:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E296C433C7; Fri, 12 Jan 2024 19:27:51 +0000 (UTC) Date: Fri, 12 Jan 2024 19:27:48 +0000 From: Simon Horman To: Tony Nguyen Message-ID: <20240112192748.GB392144@kernel.org> References: <20240111003927.2362752-1-anthony.l.nguyen@intel.com> <20240111131142.GA45291@kernel.org> <81e01a6b-2dd4-731a-570c-58944c5fc9b0@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81e01a6b-2dd4-731a-570c-58944c5fc9b0@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705087672; bh=/htuLTQELgiq2v9t2djukaAwxAo9F9LALpfsK5RHuVo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jb2Cm4XiRM0rFTwhfu9xiC+nda1zDdFa8R2+umuEDwKAzexXPyeRvw6j12kM0CUyi YcRjJDXCsA8C7rHMGAhmL58WK9CkwprJ+x6JbjNP17V7wgFiaADKpuPbFty64Qsfeq ocggNifBBhmrOZZxTK56qPHONTAYfdApr6TBnMD8iJH/iGDcEPVzhZJ27txvUoGrUZ ElNIzk7JfvdbotQIuACUmkZYFxJMrWD/Xjuyon+wAoLRWPAoFlTXl6Vv+zAy5qeffO PuiQnZwTcKhfVwcmvt6NkqCvTUTLOHrUMtd1Zb3Jqv98Yk5o3rgxRWgP7t07X0JRt2 Glxr6i2QJLcIQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Jb2Cm4Xi Subject: Re: [Intel-wired-lan] [PATCH iwl-net] i40e: Include types.h to some headers X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ivecera@redhat.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Martin Zaharinov , Jesse Brandeburg Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Jan 11, 2024 at 09:00:30AM -0800, Tony Nguyen wrote: > > > On 1/11/2024 5:11 AM, Simon Horman wrote: > > On Wed, Jan 10, 2024 at 04:39:25PM -0800, Tony Nguyen wrote: > > > Commit 56df345917c0 ("i40e: Remove circular header dependencies and fix > > > headers") redistributed a number of includes from one large header file > > > to the locations they were needed. In some environments, types.h is not > > > included and causing compile issues. The driver should not rely on > > > implicit inclusion from other locations; explicitly include it to these > > > files. > > > > > > Snippet of issue. Entire log can be seen through the Closes: link. > > > > > > In file included from drivers/net/ethernet/intel/i40e/i40e_diag.h:7, > > > from drivers/net/ethernet/intel/i40e/i40e_diag.c:4: > > > drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h:33:9: error: unknown type name '__le16' > > > 33 | __le16 flags; > > > | ^~~~~~ > > > drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h:34:9: error: unknown type name '__le16' > > > 34 | __le16 opcode; > > > | ^~~~~~ > > > ... > > > drivers/net/ethernet/intel/i40e/i40e_diag.h:22:9: error: unknown type name 'u32' > > > 22 | u32 elements; /* number of elements if array */ > > > | ^~~ > > > drivers/net/ethernet/intel/i40e/i40e_diag.h:23:9: error: unknown type name 'u32' > > > 23 | u32 stride; /* bytes between each element */ > > > > > > Reported-by: Martin Zaharinov > > > Closes: https://lore.kernel.org/netdev/21BBD62A-F874-4E42-B347-93087EEA8126@gmail.com/ > > > Fixes: 56df345917c0 ("i40e: Remove circular header dependencies and fix headers") > > > Reviewed-by: Jesse Brandeburg > > > Signed-off-by: Tony Nguyen > > > > Hi Tony, > > > > I agree this is a good change to make. > > But I am curious to know if you were able to reproduce > > the problem reported at the link above. > > Or perhaps more to the point, do you have a config that breaks > > without this patch? > > Hi Simon, > > Unfortunately, I was not able to reproduce the problem. Since it was > fairly straightforward on what was happening, I made the patch and Martin > confirmed it resolved his issue. Thanks, I agree this seems straightforward. Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15AB015AC9 for ; Fri, 12 Jan 2024 19:27:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jb2Cm4Xi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E296C433C7; Fri, 12 Jan 2024 19:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705087672; bh=/htuLTQELgiq2v9t2djukaAwxAo9F9LALpfsK5RHuVo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jb2Cm4XiRM0rFTwhfu9xiC+nda1zDdFa8R2+umuEDwKAzexXPyeRvw6j12kM0CUyi YcRjJDXCsA8C7rHMGAhmL58WK9CkwprJ+x6JbjNP17V7wgFiaADKpuPbFty64Qsfeq ocggNifBBhmrOZZxTK56qPHONTAYfdApr6TBnMD8iJH/iGDcEPVzhZJ27txvUoGrUZ ElNIzk7JfvdbotQIuACUmkZYFxJMrWD/Xjuyon+wAoLRWPAoFlTXl6Vv+zAy5qeffO PuiQnZwTcKhfVwcmvt6NkqCvTUTLOHrUMtd1Zb3Jqv98Yk5o3rgxRWgP7t07X0JRt2 Glxr6i2QJLcIQ== Date: Fri, 12 Jan 2024 19:27:48 +0000 From: Simon Horman To: Tony Nguyen Cc: intel-wired-lan@lists.osuosl.org, ivecera@redhat.com, netdev@vger.kernel.org, Martin Zaharinov , Jesse Brandeburg Subject: Re: [PATCH iwl-net] i40e: Include types.h to some headers Message-ID: <20240112192748.GB392144@kernel.org> References: <20240111003927.2362752-1-anthony.l.nguyen@intel.com> <20240111131142.GA45291@kernel.org> <81e01a6b-2dd4-731a-570c-58944c5fc9b0@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81e01a6b-2dd4-731a-570c-58944c5fc9b0@intel.com> On Thu, Jan 11, 2024 at 09:00:30AM -0800, Tony Nguyen wrote: > > > On 1/11/2024 5:11 AM, Simon Horman wrote: > > On Wed, Jan 10, 2024 at 04:39:25PM -0800, Tony Nguyen wrote: > > > Commit 56df345917c0 ("i40e: Remove circular header dependencies and fix > > > headers") redistributed a number of includes from one large header file > > > to the locations they were needed. In some environments, types.h is not > > > included and causing compile issues. The driver should not rely on > > > implicit inclusion from other locations; explicitly include it to these > > > files. > > > > > > Snippet of issue. Entire log can be seen through the Closes: link. > > > > > > In file included from drivers/net/ethernet/intel/i40e/i40e_diag.h:7, > > > from drivers/net/ethernet/intel/i40e/i40e_diag.c:4: > > > drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h:33:9: error: unknown type name '__le16' > > > 33 | __le16 flags; > > > | ^~~~~~ > > > drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h:34:9: error: unknown type name '__le16' > > > 34 | __le16 opcode; > > > | ^~~~~~ > > > ... > > > drivers/net/ethernet/intel/i40e/i40e_diag.h:22:9: error: unknown type name 'u32' > > > 22 | u32 elements; /* number of elements if array */ > > > | ^~~ > > > drivers/net/ethernet/intel/i40e/i40e_diag.h:23:9: error: unknown type name 'u32' > > > 23 | u32 stride; /* bytes between each element */ > > > > > > Reported-by: Martin Zaharinov > > > Closes: https://lore.kernel.org/netdev/21BBD62A-F874-4E42-B347-93087EEA8126@gmail.com/ > > > Fixes: 56df345917c0 ("i40e: Remove circular header dependencies and fix headers") > > > Reviewed-by: Jesse Brandeburg > > > Signed-off-by: Tony Nguyen > > > > Hi Tony, > > > > I agree this is a good change to make. > > But I am curious to know if you were able to reproduce > > the problem reported at the link above. > > Or perhaps more to the point, do you have a config that breaks > > without this patch? > > Hi Simon, > > Unfortunately, I was not able to reproduce the problem. Since it was > fairly straightforward on what was happening, I made the patch and Martin > confirmed it resolved his issue. Thanks, I agree this seems straightforward. Reviewed-by: Simon Horman