All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, Hao Li <hao3.li@intel.com>
Subject: [intel-lts:6.1/dovetail-xenomai 15688/15708] net/socket.c:586:60: error: 'SOCK_OOB' undeclared
Date: Sat, 13 Jan 2024 04:54:55 +0800	[thread overview]
Message-ID: <202401130456.HOrRzVVT-lkp@intel.com> (raw)

Hi Philippe,

FYI, the error/warning still remains.

tree:   https://github.com/intel/linux-intel-lts.git 6.1/dovetail-xenomai
head:   b21b4201c7eb0370e452a439cb4ce6e97c732972
commit: c36cad6eceb9b8b5ac81ccf043b06f0772c41182 [15688/15708] net: dovetail: enable out-of-band networking (EXPERIMENTAL)
config: mips-gpr_defconfig (https://download.01.org/0day-ci/archive/20240113/202401130456.HOrRzVVT-lkp@intel.com/config)
compiler: mipsel-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240113/202401130456.HOrRzVVT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401130456.HOrRzVVT-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/socket.c: In function 'sock_map_fd':
>> net/socket.c:586:60: error: 'SOCK_OOB' undeclared (first use in this function)
     586 |                 if (IS_ENABLED(CONFIG_NET_OOB) && (flags & SOCK_OOB)) {
         |                                                            ^~~~~~~~
   net/socket.c:586:60: note: each undeclared identifier is reported only once for each function it appears in
   In file included from <command-line>:
   net/socket.c: In function '__sys_socket_create':
   net/socket.c:1731:22: error: 'SOCK_OOB' undeclared (first use in this function)
    1731 |         BUILD_BUG_ON(SOCK_OOB & SOCK_TYPE_MASK);
         |                      ^~~~~~~~
   include/linux/compiler_types.h:337:23: note: in definition of macro '__compiletime_assert'
     337 |                 if (!(condition))                                       \
         |                       ^~~~~~~~~
   include/linux/compiler_types.h:357:9: note: in expansion of macro '_compiletime_assert'
     357 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^~~~~~~~~~~~~~~~~~~
   include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
      39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
         |                                     ^~~~~~~~~~~~~~~~~~
   include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
      50 |         BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
         |         ^~~~~~~~~~~~~~~~
   net/socket.c:1731:9: note: in expansion of macro 'BUILD_BUG_ON'
    1731 |         BUILD_BUG_ON(SOCK_OOB & SOCK_TYPE_MASK);
         |         ^~~~~~~~~~~~
   net/socket.c: In function '__sys_getsockopt':
   net/socket.c:2410:13: warning: variable 'max_optlen' set but not used [-Wunused-but-set-variable]
    2410 |         int max_optlen;
         |             ^~~~~~~~~~


vim +/SOCK_OOB +586 net/socket.c

   574	
   575	static int sock_map_fd(struct socket *sock, int flags)
   576	{
   577		struct file *newfile;
   578		int fd = get_unused_fd_flags(flags), ret;
   579		if (unlikely(fd < 0)) {
   580			sock_release(sock);
   581			return fd;
   582		}
   583	
   584		newfile = sock_alloc_file(sock, flags, NULL);
   585		if (!IS_ERR(newfile)) {
 > 586			if (IS_ENABLED(CONFIG_NET_OOB) && (flags & SOCK_OOB)) {
   587				ret = sock_oob_attach(sock);
   588				if (ret < 0) {
   589					put_unused_fd(fd);
   590					sock_release(sock);
   591					return ret;
   592				}
   593			}
   594			fd_install(fd, newfile);
   595			return fd;
   596		}
   597	
   598		put_unused_fd(fd);
   599		return PTR_ERR(newfile);
   600	}
   601	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-01-12 20:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202401130456.HOrRzVVT-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=hao3.li@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.