From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6FE17C7B for ; Mon, 15 Jan 2024 17:21:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ii4ZQbpN" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-40e7e2e04f0so6981035e9.1 for ; Mon, 15 Jan 2024 09:21:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705339289; x=1705944089; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IjkFYZF4OJsSCux1ae0KuULOn1wykr+CXrlgMJayfq0=; b=ii4ZQbpNn+VpHZoDLjK3ZkDmdggSBxUJ+uid6MeMEI2OL9Of/yRkoklnBdiYtvNdwO 6hvvn0zrrNshMmIglQW6EZOPwFxPZewGScw+yGEdzp6gw0QkE2MRrp+8CmiiLSsEdYPF ZXbfq6sSyp8xXrfIiTw1B0kzAaQ1at62qeoi5LGQ+YgVlfp5QvR4lufoljfKAf1OO1Jo tt+voRkrCFGdKXqjPazTnHU432acDA+JQMHlRGaHb4MiXURe4U7avEnaeitHQ3Y56p7i XsY64A+wTC2a3Nf3P/W6EXrKPL7Dq4/bgO8ZKjIDlVyDEZ8k9pHzOTd+yE9nQ8JQc6CT MPMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705339289; x=1705944089; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IjkFYZF4OJsSCux1ae0KuULOn1wykr+CXrlgMJayfq0=; b=ekjfJ94rze62wMfE1qifrr6K+I54UTPuALqQShusq5xz9/NH/jCWTd+Aqnr+JhUTzH aOpsVUwK8jcDya7YpKvXHmuY+5Ixs+G1FFeUIDpaB04ZRdylO7QVgRx9Nxntou8p4uvu aJk8krdMJbKcqF0alntZ/Sjq7bR9TezJMn4klXLstu1yFuFOLdJjNBCKs+h5095pagaR D+Hi1JB3vG6Zyp7Aqyu+BJj+lVgQf8U8BEtc+y1emVwsWyC4zQbLLQct3SmFSpc2WExs juzvN45eYl4i4czf6wa1u5YkbIPMy5D5LEATNdoNlnU9py+WxZPZ4jNopltVQoxtLa6u 58kw== X-Gm-Message-State: AOJu0YwFVbdrLAK7lY34JOYPEWhhK19GPQAHynyfal+vx4I46UWGizpB shqJQqkpg4ee//aI9GEXwd5O+U9viUSAdQ== X-Google-Smtp-Source: AGHT+IGEIWTLvbhgXwT8d2oD5iyG6zHn0v20sib1KcKMQWPEWI9LPUGG9Iy5hCJrKDalyprRbZDANg== X-Received: by 2002:a05:600c:44f:b0:40d:3fee:97f6 with SMTP id s15-20020a05600c044f00b0040d3fee97f6mr3339548wmb.34.1705339288709; Mon, 15 Jan 2024 09:21:28 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id l6-20020a7bc346000000b0040d81ca11casm16167428wmj.28.2024.01.15.09.21.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 09:21:28 -0800 (PST) Date: Mon, 15 Jan 2024 17:21:26 +0000 From: Daniel Thompson To: Andy Shevchenko Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Jingoo Han , Helge Deller , Dan Carpenter Subject: Re: [PATCH v1 1/1] backlight: hx8357: Fix potential NULL pointer dereference Message-ID: <20240115172126.GA31203@aspen.lan> References: <20240114143921.550736-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240114143921.550736-1-andriy.shevchenko@linux.intel.com> On Sun, Jan 14, 2024 at 04:39:21PM +0200, Andy Shevchenko wrote: > The "im" pins are optional. Add missing check in the hx8357_probe(). > > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/r/642e1230-3358-4006-a17f-3f297897ae74@moroto.mountain > Fixes: 7d84a63a39b7 ("backlight: hx8357: Convert to agnostic GPIO API") > Signed-off-by: Andy Shevchenko Reviewed-by: Daniel Thompson Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B64A0C3DA79 for ; Mon, 15 Jan 2024 17:21:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 42C9110E25D; Mon, 15 Jan 2024 17:21:31 +0000 (UTC) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50BCA10E25D for ; Mon, 15 Jan 2024 17:21:30 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40e78238db9so11222315e9.3 for ; Mon, 15 Jan 2024 09:21:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705339289; x=1705944089; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IjkFYZF4OJsSCux1ae0KuULOn1wykr+CXrlgMJayfq0=; b=WM1vmzB/WT2vD9EgLZVlZO1G8D6/0lxl4XoCP62Fsp1O/BfKy99fA1DCxCAIK+tS3U C5S1ETuvorCf2oSTSeAlXTn3Exk5dzAG9ylV6X68raILWsLhzpnujyuELiEDoYSElJrO om+wiZ2zuT4eSoZwuuXlq+0Y13NA04OLyzF28pUcX4Qmyoh68QS69ey370yiY1tRsy8H Np4zXi7LF4mghjUWZiJkFUhfak92MoHFdDs4prE9OqFVqJ0fc4AF50InT2nLoVFUq/yr FvI43ON1az1AA6kX8x/f52oo0qyPHep+pmQiHAayXU5rXbk7XVArvtyIe6U1CxnxUhzP e/rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705339289; x=1705944089; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IjkFYZF4OJsSCux1ae0KuULOn1wykr+CXrlgMJayfq0=; b=UyGI8zMndyS+ToribWCM9m77y5W0dLF4zJ7frIDDdGC1QqnbHRYZCl2tyY9IF0XKst d6jNpEkyrMbaiac7YCpfK/YlQv5FU4EgFVAriKG9tb2rHivhq1oYG6Ei3aDoXzGykzO2 8GUvAgq2/NH5Y6SdCZaHVNxEEyFbh0rpl2XfsOC/lzrXK8mG0dyBu+8LZtSIf4135o6n G0RJYF3UkVlQxG54Ej2BLls3OK53DooxXHUhUsneKy5PN1m254MozsG2rVGn0mk9s5Jg HqP3KR1b1uHmqk8fXDoaqNEhhvcoEoQv5zolBZn/Xt2XPnHNXN85ynTWUx27lSEAKA0z 6FxA== X-Gm-Message-State: AOJu0Yxo3Kl/4nQS/3dW/FyLCgC4QpO+0clJ6P9ocTyl8hkgBL9Q8Vkc U+NzM2QYgCewNJRHWeb7oH8aP3pnFFZpBQ== X-Google-Smtp-Source: AGHT+IGEIWTLvbhgXwT8d2oD5iyG6zHn0v20sib1KcKMQWPEWI9LPUGG9Iy5hCJrKDalyprRbZDANg== X-Received: by 2002:a05:600c:44f:b0:40d:3fee:97f6 with SMTP id s15-20020a05600c044f00b0040d3fee97f6mr3339548wmb.34.1705339288709; Mon, 15 Jan 2024 09:21:28 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id l6-20020a7bc346000000b0040d81ca11casm16167428wmj.28.2024.01.15.09.21.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 09:21:28 -0800 (PST) Date: Mon, 15 Jan 2024 17:21:26 +0000 From: Daniel Thompson To: Andy Shevchenko Subject: Re: [PATCH v1 1/1] backlight: hx8357: Fix potential NULL pointer dereference Message-ID: <20240115172126.GA31203@aspen.lan> References: <20240114143921.550736-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240114143921.550736-1-andriy.shevchenko@linux.intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Jingoo Han , Helge Deller , Lee Jones , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dan Carpenter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Jan 14, 2024 at 04:39:21PM +0200, Andy Shevchenko wrote: > The "im" pins are optional. Add missing check in the hx8357_probe(). > > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/r/642e1230-3358-4006-a17f-3f297897ae74@moroto.mountain > Fixes: 7d84a63a39b7 ("backlight: hx8357: Convert to agnostic GPIO API") > Signed-off-by: Andy Shevchenko Reviewed-by: Daniel Thompson Daniel.