All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Alex Shi <alexs@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [alexshi:master 7/8] kernel/sched/fair.c:9768:32: error: unknown type name 'sched_domain'; did you mean 'sched_domain_mask_f'?
Date: Wed, 17 Jan 2024 08:13:41 +0800	[thread overview]
Message-ID: <202401170859.ZvmCANPD-lkp@intel.com> (raw)

tree:   https://github.com/alexshi/linux.git master
head:   2669828cf33eb2f62d8b52a1c1e73fa03d921498
commit: 897ed5bd9fb059d29348b23ed4ccfeb790fe503c [7/8] sched/fair: add a func _sched_asym
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20240117/202401170859.ZvmCANPD-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240117/202401170859.ZvmCANPD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401170859.ZvmCANPD-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/sched/fair.c:9768:32: error: unknown type name 'sched_domain'; did you mean 'sched_domain_mask_f'?
    9768 | static inline bool _sched_asym(sched_domain *sd, int dst_cpu, int repl_cpu)
         |                                ^~~~~~~~~~~~
         |                                sched_domain_mask_f
   kernel/sched/fair.c: In function 'sched_asym':
>> kernel/sched/fair.c:9784:17: error: implicit declaration of function '_sched_asym'; did you mean 'sched_asym'? [-Werror=implicit-function-declaration]
    9784 |                 _sched_asym(env->sd, env->dst_cpu, group->asym_prefer_cpu);
         |                 ^~~~~~~~~~~
         |                 sched_asym
   cc1: some warnings being treated as errors


vim +9768 kernel/sched/fair.c

  9747	
  9748	/**
  9749	 * sched_asym - Check if the destination CPU can do asym_packing load balance
  9750	 * @env:	The load balancing environment
  9751	 * @sgs:	Load-balancing statistics of the candidate busiest group
  9752	 * @group:	The candidate busiest group
  9753	 *
  9754	 * @env::dst_cpu can do asym_packing if it has higher priority than the
  9755	 * preferred CPU of @group.
  9756	 *
  9757	 * SMT is a special case. If we are balancing load between cores, @env::dst_cpu
  9758	 * can do asym_packing balance only if all its SMT siblings are idle. Also, it
  9759	 * can only do it if @group is an SMT group and has exactly on busy CPU. Larger
  9760	 * imbalances in the number of CPUS are dealt with in find_busiest_group().
  9761	 *
  9762	 * If we are balancing load within an SMT core, or at PKG domain level, always
  9763	 * proceed.
  9764	 *
  9765	 * Return: true if @env::dst_cpu can do with asym_packing load balance. False
  9766	 * otherwise.
  9767	 */
> 9768	static inline bool _sched_asym(sched_domain *sd, int dst_cpu, int repl_cpu)
  9769	{
  9770		/* Ensure that the whole local core is idle, if applicable. */
  9771		return sched_use_asym_prio(sd, dst_cpu) &&
  9772				sched_asym_prefer(dst_cpu, repl_cpu);
  9773	}
  9774	
  9775	static inline bool
  9776	sched_asym(struct lb_env *env, struct sg_lb_stats *sgs, struct sched_group *group)
  9777	{
  9778		/*
  9779		 * CPU priorities does not make sense for SMT cores with more than one
  9780		 * busy sibling.
  9781		 */
  9782		return !(group->flags & SD_SHARE_CPUCAPACITY &&
  9783				sgs->group_weight - sgs->idle_cpus != 1) &&
> 9784			_sched_asym(env->sd, env->dst_cpu, group->asym_prefer_cpu);
  9785	}
  9786	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-01-17  0:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202401170859.ZvmCANPD-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=alexs@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.