From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, vladimir.oltean@nxp.com
Subject: Re: [PATCH net] net: netdevsim: don't try to destroy PHC on VFs
Date: Wed, 17 Jan 2024 09:15:02 +0000 [thread overview]
Message-ID: <20240117091502.GJ588419@kernel.org> (raw)
In-Reply-To: <20240116191400.2098848-1-kuba@kernel.org>
On Tue, Jan 16, 2024 at 11:14:00AM -0800, Jakub Kicinski wrote:
> PHC gets initialized in nsim_init_netdevsim(), which
> is only called if (nsim_dev_port_is_pf()).
>
> Create a counterpart of nsim_init_netdevsim() and
> move the mock_phc_destroy() there.
>
> This fixes a crash trying to destroy netdevsim with
> VFs instantiated, as caught by running the devlink.sh test:
>
> BUG: kernel NULL pointer dereference, address: 00000000000000b8
> RIP: 0010:mock_phc_destroy+0xd/0x30
> Call Trace:
> <TASK>
> nsim_destroy+0x4a/0x70 [netdevsim]
> __nsim_dev_port_del+0x47/0x70 [netdevsim]
> nsim_dev_reload_destroy+0x105/0x120 [netdevsim]
> nsim_drv_remove+0x2f/0xb0 [netdevsim]
> device_release_driver_internal+0x1a1/0x210
> bus_remove_device+0xd5/0x120
> device_del+0x159/0x490
> device_unregister+0x12/0x30
> del_device_store+0x11a/0x1a0 [netdevsim]
> kernfs_fop_write_iter+0x130/0x1d0
> vfs_write+0x30b/0x4b0
> ksys_write+0x69/0xf0
> do_syscall_64+0xcc/0x1e0
> entry_SYSCALL_64_after_hwframe+0x6f/0x77
>
> Fixes: b63e78fca889 ("net: netdevsim: use mock PHC driver")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-01-17 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 19:14 [PATCH net] net: netdevsim: don't try to destroy PHC on VFs Jakub Kicinski
2024-01-17 9:15 ` Simon Horman [this message]
2024-01-17 11:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240117091502.GJ588419@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.