All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: David Howells <dhowells@redhat.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] keyctl05: Improve the dns_res_payload for boundary testing
Date: Thu, 18 Jan 2024 15:23:25 +0100	[thread overview]
Message-ID: <20240118142325.GB2774347@pevik> (raw)
In-Reply-To: <Zakb4b4EKURkixiC@yuki>

> Hi!
> > NOTE: I would wait with this to at least v6.8-rc2. Ideally it should be
> > released, when the commit reaches any stable tree or when v6.8 is released.

> What is the status here? Shall we include this for the January stable
> release? Did the kernel patch got backported to stable kernels allready?

I guess the question was to David (and I prefer him to clarify).

I see patches backported to stable already, e.g. for 6.6.x stable:

$ git show afc360e8a1256acb7579a6f5b6f2c30b85b39301
commit afc360e8a1256acb7579a6f5b6f2c30b85b39301
Author: David Howells <dhowells@redhat.com>
Date:   Sat Dec 9 00:41:55 2023 +0000

    keys, dns: Allow key types (eg. DNS) to be reclaimed immediately on expiry

    [ Upstream commit 39299bdd2546688d92ed9db4948f6219ca1b9542 ]
...

$ git tag --contains afc360e8a1256acb7579a6f5b6f2c30b85b39301
v6.6.10
v6.6.11
v6.6.12
v6.6.9

And Greg had it in his stable-queue [1]:

$ git grep -l 39299bdd2546688d92ed9db4948f6219ca1b9542
releases/5.10.206/keys-dns-allow-key-types-eg.-dns-to-be-reclaimed-imm.patch
releases/5.15.146/keys-dns-allow-key-types-eg.-dns-to-be-reclaimed-imm.patch
releases/6.1.70/keys-dns-allow-key-types-eg.-dns-to-be-reclaimed-imm.patch
releases/6.6.9/keys-dns-allow-key-types-eg.-dns-to-be-reclaimed-imm.patch

(Although it fixes the original addition of the module in 1a4240f4764a from
v2.6.36-rc1, it was probably unportable to 5.4.x and 4.19.x.)

=> I guess we can merge even the fix itself has not been released yet (there is
not even v6.8-rc1, but I suppose it will be tagged before we release LTP).

Credit for the Edward, who suggested to fix keyctl05.c [2]:

	The reason for the failure of add_key() is that the length of the incoming data
	is 5, which is less than sizeof(*v1), so keyctl05.c failed.
	Suggest modifying keyctl05.c to increase the length of the incoming data to 6
	bytes or more.

Suggested-by: Edward Adam Davis <eadavis@qq.com>

Kind regards,
Petr

[1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/
[2] https://lore.kernel.org/all/tencent_CF4FEF0D9B25A08DD7920E5D93DDBC194E07@qq.com/

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-01-18 14:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11 10:06 [LTP] [PATCH 1/1] keyctl05: Improve the dns_res_payload for boundary testing Petr Vorel
2024-01-11 10:12 ` Petr Vorel
2024-01-18 12:38 ` Cyril Hrubis
2024-01-18 14:23   ` Petr Vorel [this message]
2024-01-22  7:47     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240118142325.GB2774347@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=dhowells@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.