From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v3 01/21] drm/i915/psr: Add some documentation of variables used in psr code
Date: Fri, 19 Jan 2024 12:10:04 +0200 [thread overview]
Message-ID: <20240119101024.1060812-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240119101024.1060812-1-jouni.hogander@intel.com>
We are adding more boolean variable into intel_psr and intel_crtc_state
structs. Add some documentation about these for sake of clarity.
v2: Modify has_psr + has_panel_replay to mean panel replay
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 696d5d32ca9d..b9d2f6ceb568 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -171,6 +171,22 @@
*
* The rest of the bits are more self-explanatory and/or
* irrelevant for normal operation.
+ *
+ * Description of intel_crtc_state variables. has_psr, has_panel_replay and
+ * has_sel_update:
+ *
+ * has_psr (alone): PSR1
+ * has_psr + has_sel_update: PSR2
+ * has_psr + has_panel_replay: Panel Replay
+ * has_psr + has_panel_replay + has_sel_update: Panel Replay Selective Update
+ *
+ * Description of some intel_psr varibles. enabled, panel_replay_enabled,
+ * sel_update_enabled
+ *
+ * enabled (alone): PSR1
+ * enabled + sel_update_enabled: PSR2
+ * enabled + panel_replay_enabled: Panel Replay
+ * enabled + panel_replay_enabled + sel_update_enabled: Panel Replay SU
*/
#define CAN_PSR(intel_dp) ((intel_dp)->psr.sink_support && \
--
2.34.1
next prev parent reply other threads:[~2024-01-19 10:10 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 10:10 [PATCH v3 00/21] Panel replay selective update support Jouni Högander
2024-01-19 10:10 ` Jouni Högander [this message]
2024-02-02 6:18 ` [PATCH v3 01/21] drm/i915/psr: Add some documentation of variables used in psr code Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 02/21] drm/i915/psr: Set intel_crtc_state->has_psr on panel replay as well Jouni Högander
2024-02-02 6:21 ` Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 03/21] drm/i915/psr: Intel_psr_pause/resume needs to support panel replay Jouni Högander
2024-01-19 10:10 ` [PATCH v3 04/21] drm/i915/psr: Rename intel_psr_enabled Jouni Högander
2024-02-02 7:34 ` Manna, Animesh
2024-02-02 7:47 ` Hogander, Jouni
2024-02-05 4:50 ` Manna, Animesh
2024-04-02 9:54 ` Hogander, Jouni
2024-01-19 10:10 ` [PATCH v3 05/21] drm/i915/psr: Do not update phy power state in case of panel replay Jouni Högander
2024-02-02 7:55 ` Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 06/21] drm/i915/psr: Check possible errors for panel replay as well Jouni Högander
2024-02-02 8:10 ` Manna, Animesh
2024-02-02 8:20 ` Hogander, Jouni
2024-02-05 4:54 ` Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 07/21] drm/i915/psr: Do not write registers/bits not applicable for panel replay Jouni Högander
2024-02-02 10:42 ` Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 08/21] drm/i915/psr: Unify panel replay enable/disable sink Jouni Högander
2024-02-02 11:11 ` Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 09/21] drm/i915/psr: Panel replay has to be enabled before link training Jouni Högander
2024-01-23 17:39 ` Jani Nikula
2024-01-23 17:41 ` Jani Nikula
2024-02-02 11:21 ` Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 10/21] drm/i915/psr: Rename has_psr2 as has_sel_update Jouni Högander
2024-02-02 11:22 ` Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 11/21] drm/i915/psr: Modify VSC SDP calculation to support panel replay + su Jouni Högander
2024-02-02 13:58 ` Manna, Animesh
2024-02-05 13:43 ` Hogander, Jouni
2024-01-19 10:10 ` [PATCH v3 12/21] drm/i915/psr: Rename psr2_enabled as sel_update_enabled Jouni Högander
2024-01-19 10:10 ` [PATCH v3 13/21] drm/panelreplay: dpcd register definition for panelreplay SU Jouni Högander
2024-02-02 14:29 ` Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 14/21] drm/i915/psr: Detect panel replay selective update support Jouni Högander
2024-02-02 14:31 ` Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 15/21] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay Jouni Högander
2024-02-02 14:39 ` Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 16/21] drm/i915/psr: Ensure early transport is not enabled for " Jouni Högander
2024-02-05 4:40 ` Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 17/21] drm/i915/psr: Panel replay uses SRD_STATUS to track it's status Jouni Högander
2024-01-19 10:10 ` [PATCH v3 18/21] drm/i915/psr: Do not apply workarounds in case of panel replay Jouni Högander
2024-01-19 10:10 ` [PATCH v3 19/21] drm/i915/psr: Update PSR module parameter descriptions Jouni Högander
2024-02-05 4:43 ` Manna, Animesh
2024-01-19 10:10 ` [PATCH v3 20/21] drm/i915/psr: Split intel_psr2_config_valid for panel replay Jouni Högander
2024-01-19 10:10 ` [PATCH v3 21/21] drm/i915/psr: Add panel replay sel update support to debugfs interface Jouni Högander
2024-01-19 11:36 ` ✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support (rev3) Patchwork
2024-01-19 11:36 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-19 11:56 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-19 15:39 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240119101024.1060812-2-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.