From: Christoph Hellwig <hch@lst.de>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Christoph Hellwig <hch@lst.de>,
bfoster@redhat.com, linux-bcachefs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] bcachefs: fix incorrect usage of REQ_OP_FLUSH
Date: Mon, 22 Jan 2024 07:50:38 +0100 [thread overview]
Message-ID: <20240122065038.GA24601@lst.de> (raw)
In-Reply-To: <eyyg26ls45xqdyjrvowm7hfusfr7ezr3pjve6ojikg4znys6dx@rd2ugzmo44r4>
On Mon, Jan 22, 2024 at 01:37:45AM -0500, Kent Overstreet wrote:
> > Without this patch as in current mainline you will get -EOPNOTSUPP
> > because sending REQ_OP_FLUSH and finally check for that to catch bugs
> > like the one fixed with this patch.
>
> Then why did the user report -EOPNOTSUPP with the patch, which went away
> when reverted?
I have no idea, as we never return -EOPNOTSUPP for
REQ_OP_WRITE | REQ_PREFLUSH this would be odd. According to your
report the users runs a Fedora kernel and this commit never went
upstream or even into linux-next, which doesn't quite add a up to me
either.
But in the end just try it yourself. On current mainline with the buggy
REQ_OP_FLUSH you should be seeing -EOPNOTSUPP every single time you
try a data integrity operation, without it you should not. Even the most
basic test should be catching this.
next prev parent reply other threads:[~2024-01-22 6:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 7:36 [PATCH] bcachefs: fix incorrect usage of REQ_OP_FLUSH Christoph Hellwig
2024-01-11 16:37 ` Kent Overstreet
2024-01-19 21:32 ` Kent Overstreet
2024-01-22 6:30 ` Christoph Hellwig
2024-01-22 6:37 ` Kent Overstreet
2024-01-22 6:50 ` Christoph Hellwig [this message]
2024-01-22 17:37 ` Kent Overstreet
2024-01-22 17:38 ` Christoph Hellwig
2024-01-22 17:42 ` Kent Overstreet
2024-01-22 18:41 ` Christoph Hellwig
2024-01-23 0:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122065038.GA24601@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.