All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Qais Yousef <qyousef@layalina.io>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [qais-yousef:uclamp-max-aggregation 13/13] kernel/sched/core.c:4904:7: error: implicit declaration of function '__ignore_task_perf'; did you mean '__init_task_data'?
Date: Mon, 22 Jan 2024 08:25:13 +0800	[thread overview]
Message-ID: <202401220820.R4Ty2Udn-lkp@intel.com> (raw)

tree:   https://github.com/qais-yousef/linux uclamp-max-aggregation
head:   a29c26f9317cede0f3141904d910d3125f8a82ea
commit: a29c26f9317cede0f3141904d910d3125f8a82ea [13/13] sched: Make iowait boost per task
config: i386-randconfig-011-20240122 (https://download.01.org/0day-ci/archive/20240122/202401220820.R4Ty2Udn-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240122/202401220820.R4Ty2Udn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401220820.R4Ty2Udn-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/sched/core.c: In function 'update_cpufreq_ctx_switch':
   kernel/sched/core.c:4896:14: error: 'struct cfs_rq' has no member named 'decayed'
      if (rq->cfs.decayed) {
                 ^
   kernel/sched/core.c:4897:11: error: 'struct cfs_rq' has no member named 'decayed'
       rq->cfs.decayed = false;
              ^
>> kernel/sched/core.c:4904:7: error: implicit declaration of function '__ignore_task_perf'; did you mean '__init_task_data'? [-Werror=implicit-function-declaration]
      if (__ignore_task_perf(current))
          ^~~~~~~~~~~~~~~~~~
          __init_task_data
>> kernel/sched/core.c:4908:16: error: implicit declaration of function '__uclamp_eff_value'; did you mean 'uclamp_eff_value'? [-Werror=implicit-function-declaration]
      uclamp_min = __uclamp_eff_value(current, UCLAMP_MIN);
                   ^~~~~~~~~~~~~~~~~~
                   uclamp_eff_value
   kernel/sched/core.c:4910:20: error: 'struct cfs_rq' has no member named 'avg'
      rq_util = rq->cfs.avg.util_avg;
                       ^
   cc1: some warnings being treated as errors


vim +4904 kernel/sched/core.c

  4877	
  4878	static inline void update_cpufreq_ctx_switch(struct rq *rq)
  4879	{
  4880		if (unlikely(current->sched_class == &stop_sched_class))
  4881			return;
  4882	
  4883		if (unlikely(current->sched_class == &idle_sched_class))
  4884			return;
  4885	
  4886		if (unlikely(task_has_idle_policy(current)))
  4887			return;
  4888	
  4889		if (likely(fair_policy(current->policy))) {
  4890			unsigned long uclamp_min, uclamp_max;
  4891			unsigned long rq_util;
  4892	
  4893			/*
  4894			 * Allow cpufreq updates once for every update_load_avg() decay.
  4895			 */
  4896			if (rq->cfs.decayed) {
  4897				rq->cfs.decayed = false;
  4898				goto force_update;
  4899			}
  4900	
  4901			if (current->in_iowait)
  4902				goto force_update;
  4903	
> 4904			if (__ignore_task_perf(current))
  4905				return;
  4906	
  4907			/* Force an update if perf hints are required to be applied */
> 4908			uclamp_min = __uclamp_eff_value(current, UCLAMP_MIN);
  4909			uclamp_max = __uclamp_eff_value(current, UCLAMP_MAX);
  4910			rq_util = rq->cfs.avg.util_avg;
  4911	
  4912			if (uclamp_min > rq_util || uclamp_max < rq_util)
  4913				goto force_update;
  4914	
  4915			return;
  4916		}
  4917	
  4918		/* RT and DL should always send a freq update */
  4919	
  4920		/* XXX ignore updates for sugov worker thread */
  4921	
  4922	force_update:
  4923	
  4924		/*
  4925		 * Request freq update after __balance_callbacks to take into account
  4926		 * any changes to rq.
  4927		 */
  4928		cpufreq_update_util(rq, 0);
  4929	}
  4930	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-01-22  0:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202401220820.R4Ty2Udn-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=qyousef@layalina.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.